mirror of
https://bitbucket.org/smil3y/kde-extraapps.git
synced 2025-02-24 10:52:53 +00:00
658e812f74
KUrl has QVariant operator meaning it should be QVariant from QVariant
(i.e. copy constructor) but the testModel() function (see the history model
test) explicitly converts it to KUrl while the StartMainPage class was
converting it to QUrl (via QVariant::toUrl()).
qVariantFromValue<T>() has type before QVariant specialization
side note, try compiling the following (with proper Makefile):
#include <qurl.h>
#include <qvariant.h>
#include <qdebug.h>
#include <kurl.h>
int main (int argc, char** argv)
{
QVariant v(QUrl());
qDebug() << v.type() << v.userType();
QVariant v2(KUrl());
qDebug() << v2.type() << v2.userType();
return 0;
}
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
119 lines
3.5 KiB
C++
119 lines
3.5 KiB
C++
/*
|
|
Gwenview: an image viewer
|
|
Copyright 2009 Aurélien Gâteau <agateau@kde.org>
|
|
|
|
This program is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU General Public License
|
|
as published by the Free Software Foundation; either version 2
|
|
of the License, or (at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
|
|
*/
|
|
#include "moc_historymodeltest.cpp"
|
|
|
|
// Qt
|
|
#include <QDir>
|
|
|
|
// KDE
|
|
#include <KDebug>
|
|
#include <KFilePlacesModel>
|
|
#include <KTempDir>
|
|
#include <qtest_kde.h>
|
|
|
|
// Local
|
|
#include "../lib/historymodel.h"
|
|
|
|
QTEST_KDEMAIN(HistoryModelTest, GUI)
|
|
|
|
using namespace Gwenview;
|
|
|
|
void testModel(const HistoryModel& model, const KUrl& u1, const KUrl& u2)
|
|
{
|
|
QModelIndex index;
|
|
KUrl url;
|
|
QCOMPARE(model.rowCount(), 2);
|
|
|
|
index = model.index(0, 0);
|
|
QVERIFY(index.isValid());
|
|
url = model.data(index, KFilePlacesModel::UrlRole).value<KUrl>();
|
|
QCOMPARE(url, u1);
|
|
|
|
index = model.index(1, 0);
|
|
QVERIFY(index.isValid());
|
|
url = model.data(index, KFilePlacesModel::UrlRole).value<KUrl>();
|
|
QCOMPARE(url, u2);
|
|
|
|
}
|
|
|
|
void HistoryModelTest::testAddUrl()
|
|
{
|
|
KUrl u1 = KUrl::fromPath("/home");
|
|
QDateTime d1 = QDateTime::fromString("2008-02-03T12:34:56", Qt::ISODate);
|
|
KUrl u2 = KUrl::fromPath("/root");
|
|
QDateTime d2 = QDateTime::fromString("2009-01-29T23:01:47", Qt::ISODate);
|
|
KTempDir dir;
|
|
{
|
|
HistoryModel model(0, dir.name());
|
|
model.addUrl(u1, d1);
|
|
model.addUrl(u2, d2);
|
|
testModel(model, u2, u1);
|
|
}
|
|
|
|
HistoryModel model(0, dir.name());
|
|
testModel(model, u2, u1);
|
|
|
|
// Make u1 the most recent
|
|
QDateTime d3 = QDateTime::fromString("2009-03-24T22:42:15", Qt::ISODate);
|
|
model.addUrl(u1, d3);
|
|
testModel(model, u1, u2);
|
|
}
|
|
|
|
void HistoryModelTest::testGarbageCollect()
|
|
{
|
|
KUrl u1 = KUrl::fromPath("/home");
|
|
QDateTime d1 = QDateTime::fromString("2008-02-03T12:34:56", Qt::ISODate);
|
|
KUrl u2 = KUrl::fromPath("/root");
|
|
QDateTime d2 = QDateTime::fromString("2009-01-29T23:01:47", Qt::ISODate);
|
|
KUrl u3 = KUrl::fromPath("/usr");
|
|
QDateTime d3 = QDateTime::fromString("2009-03-24T22:42:15", Qt::ISODate);
|
|
|
|
KTempDir dir;
|
|
{
|
|
HistoryModel model(0, dir.name(), 2);
|
|
model.addUrl(u1, d1);
|
|
model.addUrl(u2, d2);
|
|
testModel(model, u2, u1);
|
|
model.addUrl(u3, d3);
|
|
}
|
|
|
|
// Create a model with a larger history so that if garbage collecting fails
|
|
// to remove the collected url, the size of the model won't pass
|
|
// testModel()
|
|
HistoryModel model(0, dir.name(), 10);
|
|
testModel(model, u3, u2);
|
|
}
|
|
|
|
void HistoryModelTest::testRemoveRows()
|
|
{
|
|
KUrl u1 = KUrl::fromPath("/home");
|
|
QDateTime d1 = QDateTime::fromString("2008-02-03T12:34:56", Qt::ISODate);
|
|
KUrl u2 = KUrl::fromPath("/root");
|
|
QDateTime d2 = QDateTime::fromString("2009-01-29T23:01:47", Qt::ISODate);
|
|
|
|
KTempDir dir;
|
|
HistoryModel model(0, dir.name(), 2);
|
|
model.addUrl(u1, d1);
|
|
model.addUrl(u2, d2);
|
|
model.removeRows(0, 1);
|
|
QCOMPARE(model.rowCount(), 1);
|
|
QDir qDir(dir.name());
|
|
QCOMPARE(qDir.entryList(QDir::Files | QDir::NoDotAndDotDot).count(), 1);
|
|
}
|