make it protected so that it is reusable and implement permissions
for LibArchiveInterface via it while at it
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
other changes such as syncing properties, updating some of the URLs,
adding missing feature information, removing of redundant checks and
variables and indentation were done in the process while testing if the
changes work as intended.
replacing find_package() with macro_optional_find_package() was also done
where applicable however it's usage is questionable due to the CMake
`CMAKE_DISABLE_FIND_PACKAGE_<PACKAGE>` option.
there is a lot to be done, mostly updating package properties so I am
thinking of either providing a package properties file (like the
MacroLibrary) which sets properties for packages globablly or setting
package properties from the CMake modules shipped with kdelibs. the first
solution may override properties for packages if other projects define them
however a check to ensure that is not done should suffice. the second
solution will cover only DESCRIPTION and URL meaning PURPOSE and TYPE will
still have to be specified in the build systems.
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
this ensures tarballs with .tar.gz extension, for an example, will not be
opened and displayed as .tar archive containing other archive
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
nowdays .tar.gz and .tar.bz2 files are recognized as
application/x-bzip and application/x-gzip respectively.
also added application/x-gzip-compressed-tar because
application/x-bzip-compressed-tar is in the list and I
think that's a legacy one but should not hurt.
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
since CMake 2.8.3 (according to Raphael) FindLibArchive module is
bundled with it, to avoid dublication drop the bundled one.
in addition, libarchive does not conditionally define support of
archives and will just bail out if the format is not recognized
thus dropping the ifdef's in the handler
TODO: the format does not get recognized via archive_format() when
called on existing archive created with Ark, what the heck? is it
a libarchive bug (test with git checkout)? if it is then checking
the format in the case when the filter is ARCHIVE_FILTER_NONE with
another switch would do the job without manually checking the
extensions for zip and 7z.
