because the data engines are not parented to anything the destruction
happens too late otherwise and triggers fatal message in
Plasma::DataEngineManager that it is accessed after destruction
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
much more reliable than chopping the path into pieces to figure out the
package name. also because KGlobal::dirs()->findDirs() returns paths with
trailing slash the previous method was returning empty string
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
functionally the same except that it is not bound to the QIconEngine class
and if QIconEngine changes it does not have to be adjusted
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
where zero time timers do not make sense, e.g. when the frame applet
slideshow should be updated (never updating the slideshow automatically
could be a feature because the frame shows arrows to switch between images
but zero time for the slideshow is not handled by the frame applet)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
KImageIO::pattern() returns pattern for use in QFileDialog (glob and MIME
comment included) which is not valid filter for QDirIterator
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
in case the button text is not shown for some reason, also visually
indicating what the button will do
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
otherwise if the applet is resized to, say, 100x100 the icon would be still
16x16 - very small for applet with a 100x100 size
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
color can be now drag-n-dropped from kcolorchooser for example, dragging
the color that kolourpicker has picked may be implemented in the future
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
also not emitting the configValueChanged() signal while searching to not
trigger changes on the weather applet side while that is happening (after
search the source will be changed after selecting location item)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
by not using the location widget to display error and by not setting the
line edit widget text behind the back of KComboBox a lot of quirks are
fixed
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
so that all default and validated sources can (potentially, eventually) be
shown in the configuration location widget
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
because different applets use data that is provided by different ion, for
example wettercom provides forecast while noaa provides wind conditions.
on a side note noaa uses mostly station names rather than city names so
expect applects that default to noaa ion to require configuration by
default in most cases
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
how valid the source is is entirely different thing, more than one
weather source can match a given location (look for "multiple" in the ions
and think why it is a thing)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
out of 4 geolocation data engine providers 3 provide data for the city,
requires the following commit from kde-workspace:
d28608da5bb8b874cad1c6a9b50a5b9bfb358317
for reference:
https://github.com/fluxer/katana/issues/26
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
because the previous dict data engine source became not a thing the dict
data engine was reimplemented and now supports only english (en)
dictionary, also qstardict is not a valid data engine
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
requires the following commit from kde-workspace:
6cfe505af4ede2843d7faa3d302e09cb171d823d
and because the runner is running in its own thread it is still not
thread-safe, that's something to fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
if the LCD widget size is null (QSize(0,0)) then nothing will be painted
even if it is dirty, so it shall remain dirty until the LCD widget size
is not null
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
Plasma::TextBrowser palette is already set and updated internally, the
dictionary data engine does not add links too (unless the example or
definition itself contains such)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
