because the data engines are not parented to anything the destruction
happens too late otherwise and triggers fatal message in
Plasma::DataEngineManager that it is accessed after destruction
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
in case the button text is not shown for some reason, also visually
indicating what the button will do
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
also not emitting the configValueChanged() signal while searching to not
trigger changes on the weather applet side while that is happening (after
search the source will be changed after selecting location item)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
by not using the location widget to display error and by not setting the
line edit widget text behind the back of KComboBox a lot of quirks are
fixed
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
so that all default and validated sources can (potentially, eventually) be
shown in the configuration location widget
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
because different applets use data that is provided by different ion, for
example wettercom provides forecast while noaa provides wind conditions.
on a side note noaa uses mostly station names rather than city names so
expect applects that default to noaa ion to require configuration by
default in most cases
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
how valid the source is is entirely different thing, more than one
weather source can match a given location (look for "multiple" in the ions
and think why it is a thing)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
out of 4 geolocation data engine providers 3 provide data for the city,
requires the following commit from kde-workspace:
d28608da5bb8b874cad1c6a9b50a5b9bfb358317
for reference:
https://github.com/fluxer/katana/issues/26
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
