From ecbdf67627ad0fdc9df89be69945ca2ca799abd1 Mon Sep 17 00:00:00 2001 From: Ivailo Monev Date: Tue, 1 Aug 2023 04:00:06 +0000 Subject: [PATCH] okular: handle negative dates in okularTime() function poppler::get_creation_date() and the other date-related functions are not documented to return such but it happens Signed-off-by: Ivailo Monev --- okular/generators/poppler/generator_pdf.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/okular/generators/poppler/generator_pdf.cpp b/okular/generators/poppler/generator_pdf.cpp index 2479f170..99d1b031 100644 --- a/okular/generators/poppler/generator_pdf.cpp +++ b/okular/generators/poppler/generator_pdf.cpp @@ -13,7 +13,6 @@ #include #include #include -#include #include #include @@ -48,8 +47,12 @@ static QString okularString(const poppler::ustring &popplerstring) static QString okularTime(const popplertimetype &popplertime) { - const KDateTime kdatetime(QDateTime::fromTime_t(popplertime)); - return KGlobal::locale()->formatDateTime(kdatetime, QLocale::NarrowFormat); + if (popplertime <= 0) { + // -1, i.e. not set + return QString(); + } + const QDateTime qdatetime(QDateTime::fromTime_t(popplertime)); + return KGlobal::locale()->formatDateTime(qdatetime, QLocale::NarrowFormat); } static QDateTime okularDateTime(const popplertimetype &popplertime)