kget: remove unused Transfer constructor argument

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
This commit is contained in:
Ivailo Monev 2023-06-04 12:26:01 +03:00
parent 476eb884d7
commit ea9977cf4b
18 changed files with 25 additions and 44 deletions

View file

@ -858,7 +858,7 @@ QList<TransferHandler*> KGet::createTransfers(const QList<TransferData> &dataIte
Transfer *newTransfer = 0; Transfer *newTransfer = 0;
foreach (TransferFactory *factory, m_transferFactories) { foreach (TransferFactory *factory, m_transferFactories) {
kDebug(5001) << "Trying plugin n.plugins=" << m_transferFactories.size(); kDebug(5001) << "Trying plugin n.plugins=" << m_transferFactories.size();
if ((newTransfer = factory->createTransfer(data.src, data.dest, group, m_scheduler, data.e))) { if ((newTransfer = factory->createTransfer(data.src, data.dest, group, m_scheduler))) {
// kDebug(5001) << "KGet::createTransfer -> CREATING NEW TRANSFER ON GROUP: _" << group->name() << "_"; // kDebug(5001) << "KGet::createTransfer -> CREATING NEW TRANSFER ON GROUP: _" << group->name() << "_";
newTransfer->create(); newTransfer->create();
newTransfer->load(data.e); newTransfer->load(data.e);

View file

@ -25,14 +25,12 @@ TransferFactory::TransferFactory(QObject *parent, const QVariantList &args)
Transfer * TransferFactory::createTransfer(const KUrl &srcUrl, const KUrl &destUrl, Transfer * TransferFactory::createTransfer(const KUrl &srcUrl, const KUrl &destUrl,
TransferGroup * parent, TransferGroup * parent,
Scheduler * scheduler, Scheduler * scheduler)
const QDomElement * n)
{ {
Q_UNUSED(srcUrl) Q_UNUSED(srcUrl)
Q_UNUSED(destUrl) Q_UNUSED(destUrl)
Q_UNUSED(parent) Q_UNUSED(parent)
Q_UNUSED(scheduler) Q_UNUSED(scheduler)
Q_UNUSED(n)
return 0; return 0;
} }

View file

@ -57,8 +57,7 @@ class KGET_EXPORT TransferFactory : public KGetPlugin
virtual Transfer * createTransfer( const KUrl &srcUrl, const KUrl &destUrl, virtual Transfer * createTransfer( const KUrl &srcUrl, const KUrl &destUrl,
TransferGroup * parent, TransferGroup * parent,
Scheduler * scheduler, Scheduler * scheduler);
const QDomElement * n = 0 );
virtual TransferHandler * createTransferHandler(Transfer * transfer, virtual TransferHandler * createTransferHandler(Transfer * transfer,
Scheduler * scheduler); Scheduler * scheduler);

View file

@ -42,8 +42,7 @@ const StatusStrings STATUSTEXTS[] = {
const QStringList STATUSICONS = QStringList() << "media-playback-start" << "view-history" << "process-stop" << "dialog-error" << "dialog-ok" << "media-playback-start" << "media-playback-pause"; const QStringList STATUSICONS = QStringList() << "media-playback-start" << "view-history" << "process-stop" << "dialog-error" << "dialog-ok" << "media-playback-start" << "media-playback-pause";
Transfer::Transfer(TransferGroup * parent, TransferFactory * factory, Transfer::Transfer(TransferGroup * parent, TransferFactory * factory,
Scheduler * scheduler, const KUrl & source, const KUrl & dest, Scheduler * scheduler, const KUrl & source, const KUrl & dest)
const QDomElement * e)
: Job(scheduler, parent), : Job(scheduler, parent),
m_source(source), m_dest(dest), m_source(source), m_dest(dest),
m_totalSize(0), m_downloadedSize(0), m_uploadedSize(0), m_totalSize(0), m_downloadedSize(0), m_uploadedSize(0),
@ -52,7 +51,6 @@ Transfer::Transfer(TransferGroup * parent, TransferFactory * factory,
m_capabilities(0), m_visibleUploadLimit(0), m_visibleDownloadLimit(0), m_capabilities(0), m_visibleUploadLimit(0), m_visibleDownloadLimit(0),
m_ratio(0), m_handler(0), m_factory(factory) m_ratio(0), m_handler(0), m_factory(factory)
{ {
Q_UNUSED(e)
} }
Transfer::~Transfer() Transfer::~Transfer()

View file

@ -97,8 +97,7 @@ class KGET_EXPORT Transfer : public Job
Q_DECLARE_FLAGS(DeleteOptions, DeleteOption) Q_DECLARE_FLAGS(DeleteOptions, DeleteOption)
Transfer(TransferGroup * parent, TransferFactory * factory, Transfer(TransferGroup * parent, TransferFactory * factory,
Scheduler * scheduler, const KUrl & src, const KUrl & dest, Scheduler * scheduler, const KUrl & src, const KUrl & dest);
const QDomElement * e = 0);
virtual ~Transfer(); virtual ~Transfer();

View file

@ -106,8 +106,7 @@ void XmlStore::DeleteThread::run()
if(QString::compare(element.attribute("Source"), m_item.source()) == 0) { if(QString::compare(element.attribute("Source"), m_item.source()) == 0) {
root.removeChild(element); root.removeChild(element);
} } else {
else {
TransferHistoryItem item; TransferHistoryItem item;
item.setDest(element.attribute("Dest")); item.setDest(element.attribute("Dest"));
item.setSource(element.attribute("Source")); item.setSource(element.attribute("Source"));

View file

@ -24,9 +24,8 @@
#include <KDebug> #include <KDebug>
TransferKio::TransferKio(TransferGroup * parent, TransferFactory * factory, TransferKio::TransferKio(TransferGroup * parent, TransferFactory * factory,
Scheduler * scheduler, const KUrl & source, const KUrl & dest, Scheduler * scheduler, const KUrl & source, const KUrl & dest)
const QDomElement * e) : Transfer(parent, factory, scheduler, source, dest),
: Transfer(parent, factory, scheduler, source, dest, e),
m_copyjob(nullptr), m_copyjob(nullptr),
m_verifier(nullptr), m_verifier(nullptr),
m_filemodel(nullptr) m_filemodel(nullptr)

View file

@ -28,8 +28,7 @@ class TransferKio : public Transfer
Q_OBJECT Q_OBJECT
public: public:
TransferKio(TransferGroup * parent, TransferFactory * factory, TransferKio(TransferGroup * parent, TransferFactory * factory,
Scheduler * scheduler, const KUrl & src, const KUrl & dest, Scheduler * scheduler, const KUrl & src, const KUrl & dest);
const QDomElement * e = 0);
// --- Job virtual functions --- // --- Job virtual functions ---
void start() final; void start() final;

View file

@ -30,14 +30,12 @@ TransferKioFactory::~TransferKioFactory()
Transfer * TransferKioFactory::createTransfer( const KUrl &srcUrl, const KUrl &destUrl, Transfer * TransferKioFactory::createTransfer( const KUrl &srcUrl, const KUrl &destUrl,
TransferGroup * parent, TransferGroup * parent,
Scheduler * scheduler, Scheduler * scheduler)
const QDomElement * e )
{ {
kDebug(5001) << "TransferKioFactory::createTransfer"; kDebug(5001) << "TransferKioFactory::createTransfer";
if (isSupported(srcUrl)) if (isSupported(srcUrl)) {
{ return new TransferKio(parent, this, scheduler, srcUrl, destUrl);
return new TransferKio(parent, this, scheduler, srcUrl, destUrl, e);
} }
return 0; return 0;
} }

View file

@ -25,8 +25,7 @@ class TransferKioFactory : public TransferFactory
~TransferKioFactory(); ~TransferKioFactory();
Transfer * createTransfer( const KUrl &srcUrl, const KUrl &destUrl, Transfer * createTransfer( const KUrl &srcUrl, const KUrl &destUrl,
TransferGroup * parent, Scheduler * scheduler, TransferGroup * parent, Scheduler * scheduler);
const QDomElement * e = 0 );
bool isSupported(const KUrl &url) const; bool isSupported(const KUrl &url) const;
QStringList addsProtocols() const; QStringList addsProtocols() const;

View file

@ -21,8 +21,8 @@
MmsTransfer::MmsTransfer(TransferGroup * parent, TransferFactory * factory, MmsTransfer::MmsTransfer(TransferGroup * parent, TransferFactory * factory,
Scheduler * scheduler, const KUrl & source, const Scheduler * scheduler, const KUrl & source, const
KUrl &dest, const QDomElement * e) KUrl &dest)
: Transfer(parent, factory, scheduler, source, dest, e), : Transfer(parent, factory, scheduler, source, dest),
m_mmsdownload(NULL), m_mmsdownload(NULL),
m_amountThreads(MmsSettings::threads()), m_amountThreads(MmsSettings::threads()),
m_retryDownload(false) m_retryDownload(false)

View file

@ -34,8 +34,7 @@ class MmsTransfer : public Transfer
public: public:
MmsTransfer(TransferGroup * parent, TransferFactory * factory, MmsTransfer(TransferGroup * parent, TransferFactory * factory,
Scheduler * scheduler, const KUrl & src, const KUrl & dest, Scheduler * scheduler, const KUrl & src, const KUrl & dest);
const QDomElement * e = 0);
~MmsTransfer(); ~MmsTransfer();
public slots: public slots:

View file

@ -34,15 +34,14 @@ MmsTransferFactory::~MmsTransferFactory()
Transfer * MmsTransferFactory::createTransfer( const KUrl &srcUrl, const KUrl &destUrl, Transfer * MmsTransferFactory::createTransfer( const KUrl &srcUrl, const KUrl &destUrl,
TransferGroup * parent, TransferGroup * parent,
Scheduler * scheduler, Scheduler * scheduler)
const QDomElement * e )
{ {
kDebug(5001) << "MmsTransferFactory::createTransfer"; kDebug(5001) << "MmsTransferFactory::createTransfer";
QString prot = srcUrl.protocol(); QString prot = srcUrl.protocol();
kDebug(5001) << "Protocol = " << prot; kDebug(5001) << "Protocol = " << prot;
if (prot == "mms" || prot == "mmsh") { if (prot == "mms" || prot == "mmsh") {
return new MmsTransfer(parent, this, scheduler, srcUrl, destUrl, e); return new MmsTransfer(parent, this, scheduler, srcUrl, destUrl);
} }
return 0; return 0;
} }

View file

@ -35,8 +35,7 @@ class MmsTransferFactory : public TransferFactory
~MmsTransferFactory(); ~MmsTransferFactory();
Transfer * createTransfer( const KUrl &srcUrl, const KUrl &destUrl, Transfer * createTransfer( const KUrl &srcUrl, const KUrl &destUrl,
TransferGroup * parent, Scheduler * scheduler, TransferGroup * parent, Scheduler * scheduler);
const QDomElement * e = 0 );
bool isSupported(const KUrl &url) const; bool isSupported(const KUrl &url) const;
}; };

View file

@ -385,9 +385,8 @@ Qt::ItemFlags TorrentFileModel::flags(const QModelIndex &index) const
} }
TransferTorrent::TransferTorrent(TransferGroup* parent, TransferFactory* factory, TransferTorrent::TransferTorrent(TransferGroup* parent, TransferFactory* factory,
Scheduler* scheduler, const KUrl &source, const KUrl &dest, Scheduler* scheduler, const KUrl &source, const KUrl &dest)
const QDomElement* e) : Transfer(parent, factory, scheduler, source, dest),
: Transfer(parent, factory, scheduler, source, dest, e),
m_startonload(false), m_polltimerid(0), m_resumetimerid(0), m_ltsession(nullptr), m_startonload(false), m_polltimerid(0), m_resumetimerid(0), m_ltsession(nullptr),
m_filemodel(nullptr), m_dirwatch(nullptr) m_filemodel(nullptr), m_dirwatch(nullptr)
{ {

View file

@ -38,8 +38,7 @@ class TransferTorrent : public Transfer
// Transfer reimplementations // Transfer reimplementations
public: public:
TransferTorrent(TransferGroup* parent, TransferFactory* factory, TransferTorrent(TransferGroup* parent, TransferFactory* factory,
Scheduler* scheduler, const KUrl &src, const KUrl &dest, Scheduler* scheduler, const KUrl &src, const KUrl &dest);
const QDomElement* e = 0);
~TransferTorrent(); ~TransferTorrent();
public: public:

View file

@ -37,12 +37,11 @@ TransferTorrentFactory::~TransferTorrentFactory()
Transfer* TransferTorrentFactory::createTransfer(const KUrl &srcUrl, const KUrl &destUrl, Transfer* TransferTorrentFactory::createTransfer(const KUrl &srcUrl, const KUrl &destUrl,
TransferGroup* parent, TransferGroup* parent,
Scheduler* scheduler, Scheduler* scheduler)
const QDomElement* e)
{ {
kDebug(5001) << "TransferTorrentFactory::createTransfer"; kDebug(5001) << "TransferTorrentFactory::createTransfer";
if (isSupported(srcUrl)) { if (isSupported(srcUrl)) {
return new TransferTorrent(parent, this, scheduler, srcUrl, destUrl, e); return new TransferTorrent(parent, this, scheduler, srcUrl, destUrl);
} }
return nullptr; return nullptr;
} }

View file

@ -34,8 +34,7 @@ public:
~TransferTorrentFactory(); ~TransferTorrentFactory();
Transfer* createTransfer(const KUrl &srcUrl, const KUrl &destUrl, Transfer* createTransfer(const KUrl &srcUrl, const KUrl &destUrl,
TransferGroup* parent, Scheduler* scheduler, TransferGroup* parent, Scheduler* scheduler);
const QDomElement* e = 0);
bool isSupported(const KUrl &url) const; bool isSupported(const KUrl &url) const;
QStringList addsProtocols() const; QStringList addsProtocols() const;
}; };