ark: remove redundant kDebug() calls

log nothing

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

ark/app/batchextract.cpp

@@ -154,8 +154,6 @@ void BatchExtract::showFailedFiles()
 
 void BatchExtract::slotResult(KJob *job)
 {
-    kDebug();
-
     // TODO: The user must be informed about which file caused the error, and that the other files
     //       in the queue will not be extracted.
     if (job->error()) {

ark/kerfuffle/addtoarchive.cpp

@@ -118,10 +118,8 @@ void AddToArchive::start()
     QTimer::singleShot(0, this, SLOT(slotStartJob()));
 }
 
-void AddToArchive::slotStartJob(void)
+void AddToArchive::slotStartJob()
 {
-    kDebug();
-
     Kerfuffle::CompressionOptions options;
 
     if (!m_inputs.size()) {
@@ -205,9 +203,7 @@ void AddToArchive::slotStartJob(void)
 
 void AddToArchive::slotFinished(KJob *job)
 {
-    kDebug();
+    if (job->error() != KJob::NoError) {
-
-    if (job->error()) {
         KMessageBox::error(NULL, job->errorText());
     }
 

ark/kerfuffle/archiveinterface.cpp

@@ -34,10 +34,9 @@
 
 namespace Kerfuffle
 {
-ReadOnlyArchiveInterface::ReadOnlyArchiveInterface(QObject *parent, const QVariantList & args)
+ReadOnlyArchiveInterface::ReadOnlyArchiveInterface(QObject *parent, const QVariantList &args)
-        : QObject(parent), m_waitForFinishedSignal(false)
+    : QObject(parent), m_waitForFinishedSignal(false)
 {
-    kDebug();
     m_filename = args.first().toString();
 }
 
@@ -145,8 +144,8 @@ QString ReadOnlyArchiveInterface::permissionsString(mode_t perm)
     return QString::fromLatin1(buffer);
 }
 
-ReadWriteArchiveInterface::ReadWriteArchiveInterface(QObject *parent, const QVariantList & args)
+ReadWriteArchiveInterface::ReadWriteArchiveInterface(QObject *parent, const QVariantList &args)
-        : ReadOnlyArchiveInterface(parent, args)
+    : ReadOnlyArchiveInterface(parent, args)
 {
 }
 

ark/kerfuffle/jobs.cpp

@@ -167,7 +167,6 @@ void Job::onUserQuery(Query *query)
 
 bool Job::doKill()
 {
-    kDebug();
     bool ret = archiveInterface()->doKill();
     if (!ret) {
         kDebug() << "Killing does not seem to be supported here.";

ark/kerfuffle/queries.cpp

@@ -49,9 +49,7 @@ QVariant Query::response()
 
 void Query::waitForResponse()
 {
-    kDebug();
+    // if there is no response set yet, wait
-
-    //if there is no response set yet, wait
     if (!m_data.contains(QLatin1String("response"))) {
         m_responseCondition.wait(&m_responseMutex);
     }
@@ -60,15 +58,13 @@ void Query::waitForResponse()
 
 void Query::setResponse(QVariant response)
 {
-    kDebug();
-
     m_data[QLatin1String( "response" )] = response;
     m_responseCondition.wakeAll();
 }
 
-OverwriteQuery::OverwriteQuery(const QString &filename) :
+OverwriteQuery::OverwriteQuery(const QString &filename)
-        m_noRenameMode(false),
+    : m_noRenameMode(false),
-        m_multiMode(true)
+    m_multiMode(true)
 {
     m_data[QLatin1String( "filename" )] = filename;
 }

ark/part/archivemodel.cpp

@@ -947,7 +947,6 @@ DeleteJob* ArchiveModel::deleteFiles(const QList<QVariant> & files)
 
 void ArchiveModel::slotCleanupEmptyDirs()
 {
-    kDebug();
     QList<QPersistentModelIndex> queue;
     QList<QPersistentModelIndex> nodesToDelete;
 

ark/part/archiveview.cpp

@@ -73,7 +73,6 @@ void ArchiveView::slotDoubleClicked(const QModelIndex& index)
 
 void ArchiveView::setModel(QAbstractItemModel *model)
 {
-    kDebug();
     QTreeView::setModel(model);
     setSelectionMode(QAbstractItemView::ExtendedSelection);
     setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Expanding);

ark/part/part.cpp

@@ -497,9 +497,7 @@ void Part::slotLoadingStarted()
 
 void Part::slotLoadingFinished(KJob *job)
 {
-    kDebug();
+    if (job->error() != KJob::NoError) {
-
-    if (job->error()) {
         if (arguments().metaData()[QLatin1String( "createNewArchive" )] != QLatin1String( "true" )) {
             KMessageBox::sorry(NULL, i18nc("@info", "Loading the archive <tt>%1</tt> failed with the following error: <i>%2</i>", localFilePath(), job->errorText()), i18nc("@title:window", "Error Opening Archive"));
 
@@ -524,7 +522,6 @@ void Part::slotLoadingFinished(KJob *job)
 
 void Part::setReadyGui()
 {
-    kDebug();
     QApplication::restoreOverrideCursor();
     m_busy = false;
     m_view->setEnabled(true);
@@ -533,7 +530,6 @@ void Part::setReadyGui()
 
 void Part::setBusyGui()
 {
-    kDebug();
     QApplication::setOverrideCursor(QCursor(Qt::WaitCursor));
     m_busy = true;
     m_view->setEnabled(false);
@@ -741,8 +737,7 @@ QList<QVariant> Part::selectedFiles()
 
 void Part::slotExtractionDone(KJob* job)
 {
-    kDebug();
+    if (job->error() != KJob::NoError) {
-    if (job->error()) {
         KMessageBox::error(widget(), job->errorString());
     } else {
         ExtractJob *extractJob = qobject_cast<ExtractJob*>(job);
@@ -766,8 +761,6 @@ void Part::slotExtractionDone(KJob* job)
 
 void Part::adjustColumns()
 {
-    kDebug();
-
     m_view->header()->setResizeMode(0, QHeaderView::ResizeToContents);
 }
 
@@ -814,8 +807,6 @@ void Part::slotAddFiles(const QStringList& filesToAdd, const QString& path)
 
 void Part::slotAddFiles()
 {
-    kDebug();
-
     // #264819: passing widget() as the parent will not work as expected.
     //          KFileDialog will create a KFileWidget, which runs an internal
     //          event loop to stat the given directory. This, in turn, leads to
@@ -825,18 +816,22 @@ void Part::slotAddFiles()
     //          non-modal state).
     //          When KFileDialog::exec() is called, the widget is already shown
     //          and nothing happens.
-    const QStringList filesToAdd =
+    const QStringList filesToAdd = KFileDialog::getOpenFileNames(
-        KFileDialog::getOpenFileNames(KUrl("kfiledialog:///ArkAddFiles"),
+        KUrl("kfiledialog:///ArkAddFiles"),
-                                      QString(), widget()->parentWidget(),
+        QString(), widget()->parentWidget(),
-                                      i18nc("@title:window", "Add Files"));
+        i18nc("@title:window", "Add Files")
+    );
 
     slotAddFiles(filesToAdd);
 }
 
 void Part::slotAddDir()
 {
-    kDebug();
+    const QString dirToAdd = KFileDialog::getExistingDirectory(
-    const QString dirToAdd = KFileDialog::getExistingDirectory(KUrl("kfiledialog:///ArkAddFiles"), widget(), i18nc("@title:window", "Add Folder"));
+        KUrl("kfiledialog:///ArkAddFiles"),
+        widget(),
+        i18nc("@title:window", "Add Folder")
+    );
 
     if (!dirToAdd.isEmpty()) {
         slotAddFiles(QStringList() << dirToAdd);
@@ -845,32 +840,29 @@ void Part::slotAddDir()
 
 void Part::slotAddFilesDone(KJob* job)
 {
-    kDebug();
+    if (job->error() != KJob::NoError) {
-    if (job->error()) {
         KMessageBox::error(widget(), job->errorString());
     }
 }
 
 void Part::slotDeleteFilesDone(KJob* job)
 {
-    kDebug();
+    if (job->error() != KJob::NoError) {
-    if (job->error()) {
         KMessageBox::error(widget(), job->errorString());
     }
 }
 
 void Part::slotDeleteFiles()
 {
-    kDebug();
+    const int reallyDelete = KMessageBox::questionYesNo(
-
+        NULL,
-    const int reallyDelete =
+        i18n("Deleting these files is not undoable. Are you sure you want to do this?"),
-        KMessageBox::questionYesNo(NULL,
+        i18nc("@title:window", "Delete files"),
-                                   i18n("Deleting these files is not undoable. Are you sure you want to do this?"),
+        KStandardGuiItem::del(),
-                                   i18nc("@title:window", "Delete files"),
+        KStandardGuiItem::cancel(),
-                                   KStandardGuiItem::del(),
+        QString(),
-                                   KStandardGuiItem::cancel(),
+        KMessageBox::Dangerous | KMessageBox::Notify
-                                   QString(),
+    );
-                                   KMessageBox::Dangerous | KMessageBox::Notify);
 
     if (reallyDelete == KMessageBox::No) {
         return;

ark/plugins/libsinglefileplugin/singlefileplugin.cpp

@@ -108,8 +108,6 @@ bool LibSingleFileInterface::copyFiles(const QList<QVariant> &files, const QStri
 
 bool LibSingleFileInterface::list()
 {
-    kDebug();
-
     const QString filename = uncompressedFileName();
 
     Kerfuffle::ArchiveEntry e;