gwenview: minor optimizations

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
This commit is contained in:
Ivailo Monev 2022-10-16 01:04:41 +03:00
parent 0ca5a4530a
commit 4b105d8244
2 changed files with 4 additions and 6 deletions

View file

@ -272,12 +272,11 @@ void ImageMetaInfoModel::setUrl(const KUrl& url)
d->setGroupEntryValue(GeneralGroup, "General.Size", sizeString); d->setGroupEntryValue(GeneralGroup, "General.Size", sizeString);
d->setGroupEntryValue(GeneralGroup, "General.Time", item.timeString()); d->setGroupEntryValue(GeneralGroup, "General.Time", item.timeString());
KExiv2 kexiv2(url.path()); const KExiv2 kexiv2(url.path());
const KExiv2PropertyList kexiv2metadata = kexiv2.metadata();
KExiv2PropertyList exifprops; KExiv2PropertyList exifprops;
KExiv2PropertyList iptcprops; KExiv2PropertyList iptcprops;
KExiv2PropertyList xmpprops; KExiv2PropertyList xmpprops;
foreach (const KExiv2Property &kexiv2property, kexiv2metadata) { foreach (const KExiv2Property &kexiv2property, kexiv2.metadata()) {
if (kexiv2property.name.startsWith("Exif.")) { if (kexiv2property.name.startsWith("Exif.")) {
exifprops.append(kexiv2property); exifprops.append(kexiv2property);
} else if (kexiv2property.name.startsWith("Xmp.")) { } else if (kexiv2property.name.startsWith("Xmp.")) {

View file

@ -65,8 +65,7 @@ struct CacheItem
} }
const QString path = url.path(); const QString path = url.path();
KExiv2 kexiv2(path); const KExiv2 kexiv2(path);
const KExiv2PropertyList kexiv2metadata = kexiv2.metadata();
// Ordered list of keys to try // Ordered list of keys to try
static QList<QByteArray> datelst = QList<QByteArray>() static QList<QByteArray> datelst = QList<QByteArray>()
<< QByteArray("Exif.Photo.DateTimeOriginal") << QByteArray("Exif.Photo.DateTimeOriginal")
@ -74,7 +73,7 @@ struct CacheItem
<< QByteArray("Exif.Photo.DateTimeDigitized") << QByteArray("Exif.Photo.DateTimeDigitized")
<< QByteArray("Exif.Image.DateTime"); << QByteArray("Exif.Image.DateTime");
QString exifvalue; QString exifvalue;
foreach (const KExiv2Property &kexiv2property, kexiv2metadata) { foreach (const KExiv2Property &kexiv2property, kexiv2.metadata()) {
if (datelst.contains(kexiv2property.name)) { if (datelst.contains(kexiv2property.name)) {
exifvalue = kexiv2property.value; exifvalue = kexiv2property.value;
if (!exifvalue.isEmpty()) { if (!exifvalue.isEmpty()) {