Commit graph

1166 commits

Author SHA1 Message Date
Ivailo Monev
16c1fa18a4 avoid deep copy of strings in QIcuCodec::aliases() and QIcuCodec::allCodecs()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-29 02:59:03 +00:00
Ivailo Monev
b06f2a06ff rely on the fact that default QTime constructor is for null-time in QTime::fromString()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 23:14:34 +00:00
Ivailo Monev
9b37d78530 replace QT_TYPENAME with Q_TYPENAME and remove it
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 23:07:22 +00:00
Ivailo Monev
a6b93cbfdc use single variable assignment in QUuid::fromRfc4122()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 22:59:04 +00:00
Ivailo Monev
3f05b0df24 remove redundant reinterpret_cast<> in QIcuCodec::convertFromUnicode()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 22:17:43 +00:00
Ivailo Monev
9e9f1bc075 deal with QVarLengthArray TODO
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 22:06:28 +00:00
Ivailo Monev
ba20535eaa move qstringmatcher header inclusion from qstringlist header to source file
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 20:57:00 +00:00
Ivailo Monev
7c427a6dc0 remove redundant uint() construct in QDate::setYMD()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 19:24:35 +00:00
Ivailo Monev
77d6a91f74 return object rather than reference from QFileInfoPrivate::getFileTime()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 19:23:39 +00:00
Ivailo Monev
0137e58d6e correct QFileInfoPrivate::getCachedFlag() return value
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 18:28:45 +00:00
Ivailo Monev
d4b64a5536 optimize QSize::scale()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 18:10:05 +00:00
Ivailo Monev
46ed5e716a remove bogus compile-time error in qrect header
there is no topLeft() function that I am aware of

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 17:55:54 +00:00
Ivailo Monev
149801e98e use uninitialized buffer instead of resizing one in QByteDataBuffer::read()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 17:39:30 +00:00
Ivailo Monev
2b7b17b002 mark getSettingsPath() function as static
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 04:19:47 +00:00
Ivailo Monev
8df02dc5c3 mark default case in QCryptographicHash::hash() as unreachable
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 03:31:19 +00:00
Ivailo Monev
7854129cbb avoid struct mirroring by including qobject_p header in qsignaldumper source file
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 02:23:13 +00:00
Ivailo Monev
1867537939 replace C-style casts with static_cast where applicable
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 01:47:40 +00:00
Ivailo Monev
44b3b173b3 plug QDateTime memory leaks
caused by shadowing member

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 01:23:58 +00:00
Ivailo Monev
95f978fddd do not reallocate shared empty/null QByteArray data
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 01:05:48 +00:00
Ivailo Monev
2b6bbedde5 QSharedData ref member does not have to be mutable
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 01:01:03 +00:00
Ivailo Monev
57f3d62aa0 do not free the shared empty and shared null QByteArray data
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 00:23:29 +00:00
Ivailo Monev
5a0fa9fa3a compiler warning fixes
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 00:04:51 +00:00
Ivailo Monev
070bfe9e4a use public QByteArray constructor in QByteArray::trimmed()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-27 15:11:44 +00:00
Ivailo Monev
a62e9bd778 use public QString constructors in QString::simplified() and QString::trimmed()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-27 15:11:11 +00:00
Ivailo Monev
9fc98aab48 QDirIterator destructor does not have to be virtual
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-27 15:09:50 +00:00
Ivailo Monev
3e79fdf69f avoid temporary in QDirIteratorPrivate::pushDirectory()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-27 15:07:56 +00:00
Ivailo Monev
999d86187b avoid temporary in QUrl streaming operator
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-27 14:58:54 +00:00
Ivailo Monev
5660f5ed0d Revert "get rid of QByteArray::shared_empty and QString::shared_empty"
This reverts commit 259252b337.
2019-12-27 12:29:42 +00:00
Ivailo Monev
6cee4d3a5c remove redundant uint() constructs in QString::at() and QString::operator[]
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-27 11:36:07 +00:00
Ivailo Monev
259252b337 get rid of QByteArray::shared_empty and QString::shared_empty
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-27 10:49:10 +00:00
Ivailo Monev
7ef1c71404 inline qstrnlen() function to strnlen()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-27 10:27:13 +00:00
Ivailo Monev
574355df4a remove bogus compile-time error
the signature for truncate() from unistd header takes two arguments,
QByteArray::truncate() takes only one

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-27 10:14:50 +00:00
Ivailo Monev
4495e9df6c protect QIcuCodec::allCodecs() and QIcuCodec::allMibs() cache with mutex
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-27 09:03:17 +00:00
Ivailo Monev
8a08a87708 warn on negative data size from qCompress() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-27 05:24:04 +00:00
Ivailo Monev
81948e43d7 avoid buffer resizing in qCompress() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-27 05:14:00 +00:00
Ivailo Monev
a3174414ad simplify qUncompress() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-27 03:27:27 +00:00
Ivailo Monev
beaf0af0f4 inline qstrcmp() function overloads
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-27 02:03:43 +00:00
Ivailo Monev
46d9359f9f indent and use signle variable assignment in QByteArray::toBase64()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-27 01:21:57 +00:00
Ivailo Monev
48915cd40c replace tabs with spaces in QByteArray::fromBase64()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-27 01:19:21 +00:00
Ivailo Monev
59db1bf9b6 check if path is writable as fallback in QSettings::isWritable()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 22:26:14 +00:00
Ivailo Monev
39598942c6 convert strings to ASCII instead of Latin1 in QSettingsPrivate::variantToString()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 21:52:02 +00:00
Ivailo Monev
e4bd089f5a replace break with return in QSettingsPrivate::variantToString()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 21:51:08 +00:00
Ivailo Monev
c05d3b9b1c convert strings from/to ASCII instead of Latin1 in QSettingsPrivate::variantToString()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 21:50:08 +00:00
Ivailo Monev
b54f92af0e update QSettings documentation [ci skip]
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 21:23:17 +00:00
Ivailo Monev
d319fe8d58 avoid temporary in QVariant::canConvert() and int() constructs
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 17:51:28 +00:00
Ivailo Monev
bafd134777 use foreach() for iteration in ~QFactoryLoaderPrivate(), QFactoryLoader::updateDir() and QFactoryLoader::update()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 05:55:31 +00:00
Ivailo Monev
8fc3b649f7 move variable closer to the scope it is used in in QFactoryLoader::updateDir()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 05:54:04 +00:00
Ivailo Monev
bdae06e149 update QSettings documentation [ci skip]
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 05:08:38 +00:00
Ivailo Monev
898418ff3c remove redundant QProcEnvKey
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 04:17:48 +00:00
Ivailo Monev
e11b34777c drop redundant QSettings UNIX file locking
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 04:05:43 +00:00