Ivailo Monev
e7d17d4d43
adjust QTemporaryFile asserts
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 21:42:58 +00:00
Ivailo Monev
0ddfd03816
mark the invalid environment variable case as unlikely in QProcessEnvironmentPrivate::fromList()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 21:15:08 +00:00
Ivailo Monev
55bc45e1b0
reserve space for elements from QProcessEnvironmentPrivate::fromList()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 21:14:14 +00:00
Ivailo Monev
224f70fe26
remove now redundant qcoreapplication header inclusion from qtemporaryfile source file
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 21:11:32 +00:00
Ivailo Monev
80429a77e1
remove compatibility bits from createFileFromTemplate() function
...
fixes crash/assert too and increase default template length to 10 to deal
with collisions
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 19:42:22 +00:00
Ivailo Monev
7345cfb219
replace typedefs with the actual type in createFileFromTemplate() function
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 17:08:12 +00:00
Ivailo Monev
b66b126357
optimize QInotifyFileSystemWatcherEngine::create() for case when IN_CLOEXEC is defined
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 04:21:13 +00:00
Ivailo Monev
a30a008b15
remove redundant fcntl() call in QInotifyFileSystemWatcherEngine::QInotifyFileSystemWatcherEngine()
...
also called in QInotifyFileSystemWatcherEngine::create()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 04:19:09 +00:00
Ivailo Monev
3548acfe09
reduce branches in QFileSystemIterator::QFileSystemIterator()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 04:05:45 +00:00
Ivailo Monev
c2b94eabbd
remove redundant internal QFSFileEnginePrivate methods
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 00:13:57 +00:00
Ivailo Monev
d96e81105a
mark QDir warning cases as unlikely
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-04 23:47:12 +00:00
Ivailo Monev
be63c5b251
reduce branches in QDir::operator==() operator
...
also fixes test case
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-03 03:15:15 +00:00
Ivailo Monev
9509ddce3d
check if additional sorting flags are empty in QDir::operator<<() operator
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-03 02:50:25 +00:00
Ivailo Monev
2d3f663456
replace hardcoded mask with enum in QDir::operator<<() operator
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-03 02:37:10 +00:00
Ivailo Monev
5d0e87be33
reduce branches in QDataStream::operator>>() operators
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-03 01:31:19 +00:00
Ivailo Monev
05d7040b30
remove redundant Q_DOUBLE_FORMAT definition check
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-03 01:28:52 +00:00
Ivailo Monev
7d011143bc
update URL TLDs table [ci skip]
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-02 18:19:38 +00:00
Ivailo Monev
6a37828fa8
fix regression since 28b8a590c1
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-02 17:32:59 +00:00
Ivailo Monev
0e92ef89b9
Revert "rework QPollingFileSystemWatcherEngine to use QFileInfo for files"
...
QFileInfo equal operator does not compare all attributes
This reverts commit 9812469490
.
2020-01-02 17:31:21 +00:00
Ivailo Monev
9812469490
rework QPollingFileSystemWatcherEngine to use QFileInfo for files
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-02 16:53:28 +00:00
Ivailo Monev
f54e0ee862
print warning on parser error from json_settings_read() function
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-01 18:09:02 +00:00
Ivailo Monev
86ce17c2cf
convert QVariant::String to/from QVariant::StringList type based on delimiter
...
the conversion covers the most common cases, further improvements like
splitting quoted strings can be done in the future
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-01 11:57:34 +00:00
Ivailo Monev
6d633966a2
merge .cmake into CMakeLists.txt files
...
this way it is easier to maintain and should reduce the time spend on
configuring the project when building, much like the all-in-one build
option
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-31 04:28:36 +00:00
Ivailo Monev
43f3a2a47b
remove redundant QStringSplitter() members
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-30 05:23:19 +00:00
Ivailo Monev
5b459cf0ec
update copyright and add script for doing so
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-29 23:21:34 +00:00
Ivailo Monev
b30f1284b6
make stat() error checks consisten in QFileSystemEngine::createDirectory(), QFileSystemEngine::removeDirectory() and QFileSystemEngine::copyFile()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-29 06:04:16 +00:00
Ivailo Monev
6a54eadeba
remove redundant condition in QFileSystemEngine::fillMetaData()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-29 05:44:52 +00:00
Ivailo Monev
77d6a91f74
return object rather than reference from QFileInfoPrivate::getFileTime()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 19:23:39 +00:00
Ivailo Monev
0137e58d6e
correct QFileInfoPrivate::getCachedFlag() return value
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 18:28:45 +00:00
Ivailo Monev
2b7b17b002
mark getSettingsPath() function as static
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 04:19:47 +00:00
Ivailo Monev
5a0fa9fa3a
compiler warning fixes
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 00:04:51 +00:00
Ivailo Monev
9fc98aab48
QDirIterator destructor does not have to be virtual
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-27 15:09:50 +00:00
Ivailo Monev
3e79fdf69f
avoid temporary in QDirIteratorPrivate::pushDirectory()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-27 15:07:56 +00:00
Ivailo Monev
999d86187b
avoid temporary in QUrl streaming operator
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-27 14:58:54 +00:00
Ivailo Monev
59db1bf9b6
check if path is writable as fallback in QSettings::isWritable()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 22:26:14 +00:00
Ivailo Monev
39598942c6
convert strings to ASCII instead of Latin1 in QSettingsPrivate::variantToString()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 21:52:02 +00:00
Ivailo Monev
e4bd089f5a
replace break with return in QSettingsPrivate::variantToString()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 21:51:08 +00:00
Ivailo Monev
c05d3b9b1c
convert strings from/to ASCII instead of Latin1 in QSettingsPrivate::variantToString()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 21:50:08 +00:00
Ivailo Monev
b54f92af0e
update QSettings documentation [ci skip]
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 21:23:17 +00:00
Ivailo Monev
bdae06e149
update QSettings documentation [ci skip]
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 05:08:38 +00:00
Ivailo Monev
898418ff3c
remove redundant QProcEnvKey
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 04:17:48 +00:00
Ivailo Monev
e11b34777c
drop redundant QSettings UNIX file locking
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 04:05:43 +00:00
Ivailo Monev
d236165d11
simplify the QSettings write check
...
the previous implementation was supposed to be write-optimized, for cases
when QSettings::setValue() followed by QSettings::sync() is called often.
it turns out that optimizing for reading from the settings without changing
the object is more beneficial as that is often the case.
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-24 19:19:48 +00:00
Ivailo Monev
c797b18733
optimize key/value and section/key splitting in ini_settings_read() function
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-24 18:18:24 +00:00
Ivailo Monev
d307c6e3b0
lock QSettingsPrivate object that work with the same file only from QSettingsPrivate::write()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-24 09:35:43 +00:00
Ivailo Monev
4cd28d3113
use consistent name for locker in QSettingsPrivate::write()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-24 07:29:08 +00:00
Ivailo Monev
3643bf444e
remove redundant QT_NO_QOBJECT definition checks from qsettings_p header
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-24 05:14:42 +00:00
Ivailo Monev
1fc3be7d81
fix synchronization of QSettings between multiple processes
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-24 05:13:55 +00:00
Ivailo Monev
7769bca600
rework QSettings, use JSON as native format for it
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-24 01:30:39 +00:00
Ivailo Monev
1487a827fd
remove superfluous semicolon in QFile::encodeName()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-21 19:46:45 +00:00