Commit graph

159 commits

Author SHA1 Message Date
Ivailo Monev
180cb6e1a9 remove some redundant qglobal header inclusions
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-12-21 16:07:43 +00:00
Ivailo Monev
c6d001882d implement PCH build option for components
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-12-20 14:38:47 +00:00
Ivailo Monev
b85095d056 properly initialize QDBusArgumentPrivate::direction member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-12-17 22:07:28 +00:00
Ivailo Monev
4fad9db975 mark QDBusReply::error() as const
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-12-10 13:45:56 +00:00
Ivailo Monev
0c18f33892 merge KatieLibraryTargets and KatieBinaryTargets exports
the idea was to install them separately, one along with the libraries
and one along with the tools but they suite the Devel component better
and are installed as part of it so no reason to keep them separate

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-12-10 02:14:17 +00:00
Ivailo Monev
b757e21ceb fix regression since 0353958c59
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-12-09 15:37:04 +00:00
Ivailo Monev
510d0213e5 initialize static variables
uninitialized found via `git grep 'static int' | grep -v -e '=' -e '('`

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-12-09 14:12:33 +00:00
Ivailo Monev
13b48ebdb1 place all private headers in single directory
should reduce the build time and also the length of the commands used
during build

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-12-01 19:20:31 +00:00
Ivailo Monev
0353958c59 make use of dbus_signature_validate() and dbus_signature_validate_single()
both methods are available in atleast D-Bus v0.32 and v1.5.12 is
required so no reason not to do that

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

asd
2020-11-26 02:45:57 +00:00
Ivailo Monev
a380f56792 assume Q_OS_UNIX is defined in most source files
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-07 22:55:39 +02:00
Ivailo Monev
a3602973da remove redundant QDBusUtil methods arguments
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-10-27 04:37:07 +02:00
Ivailo Monev
9b2883e6ab remove redundant QDBusUtil::checkMemberName() argument
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-10-26 16:56:03 +02:00
Ivailo Monev
04ddcd4cea replace QDBusMarshaller::close() with its body
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-08-15 20:03:03 +03:00
Ivailo Monev
15d9977341 use correct latin string construct in QDBusMessagePrivate::makeLocal()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-07-24 00:14:09 +00:00
Ivailo Monev
443241aec1 remove redundant return statement in QDBusAbstractInterfacePrivate::property()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-07-24 00:12:41 +00:00
Ivailo Monev
5812411d37 optimize QDBusConnection methods
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-07-16 12:52:17 +00:00
Ivailo Monev
d3eb858e4d use foreach() for iteration in qDBusFindAdaptorConnector()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-07-14 00:05:48 +00:00
Ivailo Monev
81dcceab05 remove unused qDBusFindAdaptorConnector() overload
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-07-14 00:05:01 +00:00
Ivailo Monev
e2ac229d74 replace hardcoded value with enum in QDBusMetaObjectGenerator::parseProperties()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-04-09 07:27:59 +00:00
Ivailo Monev
dcfd6373a5 use foreach() for iteration in QDBusMetaObjectGenerator::parseProperties()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-04-09 07:27:43 +00:00
Ivailo Monev
a05e01b205 mark some helper functions as static and variables as const
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-04-09 07:26:35 +00:00
Ivailo Monev
6dd7238a82 remove redundant const_cast<T>() in QDBusInterface::qt_metacast()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-04-09 07:15:06 +00:00
Ivailo Monev
07bf092710 always use full paths for installation
now that CPack is no longer supported relative paths are no longer
required. this change also fixes the headers optimizations upon
installation since it requires full paths to work

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-03-09 00:36:36 +00:00
Ivailo Monev
3220d781e2 remove unused registerHelper<T>() argument
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-15 19:15:24 +00:00
Ivailo Monev
a1900b0720 effectively revert c7cc0af760
fixes crashes noted in https://github.com/fluxer/kdelibs/issues/2#issuecomment-579758494
but not the issue with marshalling/demarshalling some complex types

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-30 01:02:37 +00:00
Ivailo Monev
5731abbf80 remove unused QDBusPendingReplyTypes::metaTypeFor<T> argument
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-29 17:48:11 +00:00
Ivailo Monev
c1c41495ae use foreach() for iteration in qDBusParametersForMethod() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-29 01:22:49 +00:00
Ivailo Monev
a54d9d9820 remove redundant if statement in QDBusConnectionPrivate::prepareHook()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-29 00:45:47 +00:00
Ivailo Monev
2e87db970b remove unused QDBusDemarshaller::close() method
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-28 21:06:02 +00:00
Ivailo Monev
7134368a18 fix regression since badb333fc3
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-28 15:55:42 +00:00
Ivailo Monev
780fb9759b replace 0 with Q_NULLPTR in QDBusConnection::asyncCall()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-28 15:50:55 +00:00
Ivailo Monev
7098f521a9 do not append to iterator if arguments passed to QDBusMarshaller::append() are invalid
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-28 14:28:43 +00:00
Ivailo Monev
4dcd5db81b add QDBusMarshall and QDBusXmlParser tests
also, effectively revert 474a940c5c
since the method is required for the marshaller test however guard
it with QT_BUILD_INTERNAL definition check

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-28 13:32:10 +00:00
Ivailo Monev
6b7af366b1 remove unused and internal QDBusConnection::internalPointer
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-27 17:53:41 +00:00
Ivailo Monev
eada44b207 remove unused qdbus_cast<T>() argument
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-26 16:42:02 +00:00
Ivailo Monev
474a940c5c remove unused and internal QDBusArgument::appendVariant()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-26 16:38:35 +00:00
Ivailo Monev
bb86fbb475 replace some tabs with space
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-22 15:57:56 +00:00
Ivailo Monev
2d3e0c5f3b rebrand interface names and drop deprecated D-Bus annotation name support
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-18 00:48:42 +00:00
Ivailo Monev
09ff862f5e effectively revert 653549b4e4
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-14 03:13:28 +00:00
Ivailo Monev
c85fd7f18f indent QDBusDemarshaller::toStringList()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-13 15:26:40 +00:00
Ivailo Monev
212ef9faba remove redundant DBUS_TYPE_UNIX_FD checks
DBUS_TYPE_UNIX_FD and DBUS_TYPE_UNIX_FD_AS_STRING are available since
v1.2.16 and v1.5.12 is required now

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-13 01:46:47 +00:00
Ivailo Monev
e4c6e0f309 require D-Bus v1.5.12+ for demarshaling basic types
fixes a crash

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-12 02:13:44 +00:00
Ivailo Monev
1a8b0f99a7 remove redundant scoping in QDBusMetaType::typeToSignature()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 15:45:17 +00:00
Ivailo Monev
d220596b9a replace 0 with Q_NULLPTR in QDBusMetaType::typeToSignature()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 15:44:44 +00:00
Ivailo Monev
f826058fd8 use foreach() for iteration in QDBusMessagePrivate::makeLocal()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 19:09:33 +00:00
Ivailo Monev
d0ce2f3cda call parent connect() rather than QObject::connect() in QDBusServer constructor
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 22:55:48 +00:00
Ivailo Monev
740908bc95 replace 0 with Q_NULLPTR in QDBusPendingCallPrivate constructor
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 22:54:55 +00:00
Ivailo Monev
653549b4e4 remove unused qDBusRegisterMetaType() argument
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 22:31:23 +00:00
Ivailo Monev
a072d774fe indent QDBusMetaType::signatureToType() and QDBusMetaType::signatureToType()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 15:04:20 +00:00
Ivailo Monev
c7cc0af760 avoid temporary in QDBusMetaType::demarshall()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 15:03:38 +00:00