Commit graph

8309 commits

Author SHA1 Message Date
Ivailo Monev
f75d9b1e07 remove redundant qscopedpointer header inclusion
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-30 09:23:11 +02:00
Ivailo Monev
82afea6b42 copyright QHostAddress to me
there is no meat from the qt toolkit in that one

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-30 09:22:56 +02:00
Ivailo Monev
bd53fa415d fix QHostAddress asserts
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-30 07:23:53 +02:00
Ivailo Monev
342f615f7f note that addresses are not compressed by QHostAddress::toString()
what goes in goes out, the difference is in the scope only which is why
QHostAddress exists

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-30 07:23:35 +02:00
Ivailo Monev
80ae49dc5a drop QHostAddress from QByteArray assignment operator
because it may involve implicit conversion

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-30 06:10:11 +02:00
Ivailo Monev
b362932d07 manually manage the private QHostAddress data pointer
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-30 06:02:52 +02:00
Ivailo Monev
13130edc98 zero-initialize socket structures passed to inet_pton()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-30 04:39:17 +02:00
Ivailo Monev
9c47121084 QNetworkInterface documentation update
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-30 04:25:56 +02:00
Ivailo Monev
3c0dd6b866 do not assume the hardware address is IPv4 address in QNetworkInterfacePrivate::scan()
may or may not hold true in the future

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-30 04:19:09 +02:00
Ivailo Monev
9a5c6fe1e6 QHostAddress documentation update
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-30 04:12:56 +02:00
Ivailo Monev
11fdfa54a3 QNetworkInterface tests adjustment
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-30 04:11:29 +02:00
Ivailo Monev
bec40b8120 QHostAddress review
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-30 04:11:15 +02:00
Ivailo Monev
10ee130424 document the QHostAddress::FormattingOption enums
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-30 03:46:07 +02:00
Ivailo Monev
9871d0107c return boolean from the QHostAddress::setAddress() overload
it is documented that it does return boolean but the return type of it was
void, who knows why

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-30 03:43:01 +02:00
Ivailo Monev
cad6c377aa implement option to not output the scope from QHostAddress::toString()
the people behind the old QHostAddress implementation fucked up, fixing it
is a piece of cake tho

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-30 03:19:33 +02:00
Ivailo Monev
64a1e01cac extract the scope from the socket address (sockaddr pointer)
obviously something which was not done before by QHostAddress itself, it is
now tho

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-30 02:23:31 +02:00
Ivailo Monev
25beb62343 QHostAddress special addresses optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-30 01:51:37 +02:00
Ivailo Monev
84905cd974 QHostAddress compat bits
the scope parsing and output (from QHostAddress::toString()) is totally not
according to the RFC mentioned in the QHostAddress documentation tho

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-30 01:42:14 +02:00
Ivailo Monev
e2ac5c5b3d replace convertFlags() function with its body
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-29 16:16:30 +02:00
Ivailo Monev
35205fd485 warn if QCryptographicHash::hash() is called with empty data
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-29 15:54:45 +02:00
Ivailo Monev
ac0689a666 reimplement QHostAddress via inet_pton() and inet_ntop()
both inet_pton() and inet_ntop() are supposed to be part of POSIX.1-2001
(see https://linux.die.net/man/3/inet_pton and
https://linux.die.net/man/3/inet_ntop), this makes QHostAddress input
requirements much more strict (e.g. whitespace in the input makes the
resulting QHostAddress object not valid) thus some QHostAddress tests fail
but QHostInfo tests pass. amends (such as return value checks) can be done
later

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-29 15:24:30 +02:00
Ivailo Monev
d89749b46e remove unused QWindowSurface::endPaint() argument
less references to QRegion? hell yeah!

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-29 04:17:40 +02:00
Ivailo Monev
42014a3683 delete the old image before creating new one in QWindowSurface::setGeometry()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-29 04:12:06 +02:00
Ivailo Monev
bcdc1fd136 const-ify the return type of QOutlineMapper::elementTypes()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-29 04:02:37 +02:00
Ivailo Monev
4ce6c69719 remove redundant QDataBuffer operator
less code to maintain and less symbols to resolve (both at compile and
runtime), can't go wrong with that

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-29 02:51:04 +02:00
Ivailo Monev
509d507363 take the palette cache key into account in QItemDelegate::selected()
different palette cache key indicates different palette colors

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-29 02:07:49 +02:00
Ivailo Monev
9618afeec8 remove redundant QPixmapCache::replace() method
does the same as QPixmapCache::insert()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-29 01:55:54 +02:00
Ivailo Monev
f99b0e1adc set the initial cache limit of QPixmapCache by passing it to the QCache constructor
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-28 10:57:05 +02:00
Ivailo Monev
cf1b19860d change the QPixmapCache key type to QByteArray from QString
QString is 2x the size of QByteArray (in terms of memory allocated)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-28 10:44:16 +02:00
Ivailo Monev
32d252d3cf different take on hex string generator
with this approach the hex string generation can be optimized via
per-object or per-thread buffer (by passing it to qHexString()), that
is yet to be tested tho

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-28 09:48:16 +02:00
Ivailo Monev
0aa306b3f6 pass QByteArray object to qt_u_strToUpper() and qt_u_strToLower() functions
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-28 08:31:54 +02:00
Ivailo Monev
dee2273432 remove unused and redundant QWidgetResizeHandler members
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-28 07:42:53 +02:00
Ivailo Monev
eb54726226 remove disabled bits
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-28 06:44:14 +02:00
Ivailo Monev
1481bf58e4 simplify D-Bus component debugging
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-28 06:05:23 +02:00
Ivailo Monev
07e67b0b52 remove redundant QDir methods
only UNIX is supported

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-24 02:37:29 +02:00
Ivailo Monev
edbeabbf41 remove unused QFileSystemModelPrivate methods
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-23 15:23:31 +02:00
Ivailo Monev
46f02d9a3c drop unused QDataWidgetMapper class
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-23 15:10:39 +02:00
Ivailo Monev
1b5ac1c06b delete plugin loaders from QFactoryLoader
previously deleting the QPluginLoader instances was causing crashses in
gwenview sometimes (e.g. when gif plugin was in use but that plugin is no
more)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-23 11:14:45 +02:00
Ivailo Monev
748128b688 remove references to Qt::MouseButtonMask
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-23 07:34:39 +02:00
Ivailo Monev
3d778b2210 remove unused global definitions
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-23 05:09:08 +02:00
Ivailo Monev
7331daea30 QFlags to debug messages optimizations
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-23 04:37:15 +02:00
Ivailo Monev
ca6b53bace compiler warning fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-23 03:45:09 +02:00
Ivailo Monev
9b7689985c retry getnameinfo() without NI_NAMEREQD, log lots of messages when QHOSTINFO_DEBUG is defined and adjust QHostInfo to IP addresses changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-23 03:25:53 +02:00
Ivailo Monev
15400e4638 mark QFontEngineFT methods as final
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-22 15:22:58 +02:00
Ivailo Monev
b9014939ce const-ify QFreetypeFace::addGlyphToPath() argument
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-22 14:54:09 +02:00
Ivailo Monev
9a26963695 do not copy the parameters types list in qDBusParametersForMethod() function
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-22 12:01:42 +02:00
Ivailo Monev
61e052461c call qt_initLocale() from QCoreApplication::init()
with QSystemLocale gone (5a8895be60) it was
no longer called at all

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-16 20:45:41 +02:00
Ivailo Monev
7a60a4a6ff fix benchmarks build
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-16 20:37:46 +02:00
Ivailo Monev
3e2706dd71 drop the feature to change the default locale
changing the default locale can have various bad effects (such as failure
to convert localized integers stored in QString) which is why there was a
warning about it. even tho UNIX has the concept of changing the locale
settings (via setlocale()) I am not willing to support such feature
because QWidget, QValidtor, etc. have their own locale feature that can
be changed at any time

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-16 20:32:36 +02:00
Ivailo Monev
5070e961d0 remove redundant group separator checks in private QLocale methods
QLocalePrivate::numberToCLocale() skips whitespace (0xa0 is whitespace
char) at the begining and end

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-16 19:18:44 +02:00