Ivailo Monev
c637654536
mark QIODevice warning cases as unlikely
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-14 01:30:19 +00:00
Ivailo Monev
eb9e7ec4c3
remove unused QFileSystemEngine::setPermissions() argument
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-13 21:24:05 +00:00
Ivailo Monev
d673e99b0e
avoid temporary in QDir::filePath()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-13 21:14:07 +00:00
Ivailo Monev
c871965e9e
fix const-correctness of QDir::refresh()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-13 21:13:31 +00:00
Ivailo Monev
11429da763
replace QDirPrivate::getFilterSepChar() and QDirPrivate::splitFilters() with their body
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-13 21:13:04 +00:00
Ivailo Monev
b9f456d13f
use plain assignment in QTextStreamPrivate::saveConverterState() and QTextStreamPrivate::saveConverterState()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-13 17:28:10 +00:00
Ivailo Monev
e8f6e4422a
rework internal QTextStream converter state save/restore
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-13 16:32:29 +00:00
Ivailo Monev
edf7e64bca
use foreach() for iteration in QPollingFileSystemWatcherEngine::addPaths() and QPollingFileSystemWatcherEngine::removePaths()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-12 22:22:10 +00:00
Ivailo Monev
2adc57693d
move QFileSystemWatcher initialization from QFileSystemWatcher::addPaths() to QFileSystemWatcherPrivate::init()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-12 22:16:37 +00:00
Ivailo Monev
b45532f24d
use QSettings::NativeFormat as default for QSettings constructed with filename
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-12 17:12:03 +00:00
Ivailo Monev
f4b2e2ef65
optimize QFileSystemWatcher
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-12 17:03:33 +00:00
Ivailo Monev
991ece5a50
replace 0 with Q_NULLPTR in QFileSystemWatcherPrivate and QFileSystemWatcher
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-12 16:48:56 +00:00
Ivailo Monev
34ef33315a
set QFSFileEnginePrivate::tried_stat to proper type in QTemporaryFileEngine::open()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-12 03:07:28 +00:00
Ivailo Monev
990b8f570b
remove redundant int() constructs from qt_error_string() function calls
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-12 03:06:01 +00:00
Ivailo Monev
605292785f
remove redundant condition in QFSFileEnginePrivate::readFdFh()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-12 02:39:22 +00:00
Ivailo Monev
f9088610ff
mark warning cases in QFSFileEngine as unlikely
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-12 02:39:01 +00:00
Ivailo Monev
bf349cbb86
introduce QT_BUFFSIZE
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-11 23:38:06 +00:00
Ivailo Monev
7652249aa5
Merge branch 'refileengine'
2020-01-11 20:41:42 +00:00
Ivailo Monev
e02ce5c0e0
cleanup file engine, notably the Qt resource part
...
this is fixes QTBUG-11223, I also would like to take it step further
and make the resources requests prefixed with "qrc:/" so that the
check when to use QResourceFileEngine is even more reliable but
that will require backwards incompatible change so it will be done
in future release.
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-11 20:39:33 +00:00
Ivailo Monev
c2badc8aaf
define QIODEVICE_BUFFERSIZE to value of BUFSIZ from stdio header
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-11 02:55:23 +00:00
Ivailo Monev
a251c3c722
set error to QFile::CopyError in case of failure in QFile::copy()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-11 01:29:22 +00:00
Ivailo Monev
310bfaa051
implement QFileSystemEngine::copyFile() for non-Linux platforms
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-10 21:04:10 +00:00
Ivailo Monev
a25d7504f9
replace hardcodec value with enum in QFile::exists()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-10 01:13:16 +00:00
Ivailo Monev
86bf2c1c10
use correct type for flags in QFile::exists() and restore behaviour of QDir::exists() overload
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-10 01:12:14 +00:00
Ivailo Monev
571ebf899a
remove most std::bad_alloc exceptions handling
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-09 02:15:39 +00:00
Ivailo Monev
e1b4131846
check type in QFile::exists() and QDir::exists()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-09 01:38:03 +00:00
Ivailo Monev
78547c1787
Revert "avoid temporaries in QDir::mkdir(), QDir::rmdir(), QDir::mkpath() and QDir::rmpath()"
...
This reverts commit b0112afc64
.
2020-01-07 22:59:01 +00:00
Ivailo Monev
8807a2ffcb
correct loop expression in createFileFromTemplate()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 15:14:55 +00:00
Ivailo Monev
c7b36ea3ea
check for getpwuid_r() and getgrgid_r() functions
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 14:27:48 +00:00
Ivailo Monev
a72408581c
fix QFileSystemEngine::createDirectory() and QFileSystemEngine::removeDirectory()
...
the life-time of the string created by QFile::encodeName() was probably
optimized out by the compiler causing the variables of char array type to
contain invalid data
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 03:31:24 +00:00
Ivailo Monev
1d0f3d39f0
pass size of string to QString::fromLocal8Bit() where known
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 02:52:55 +00:00
Ivailo Monev
b0112afc64
avoid temporaries in QDir::mkdir(), QDir::rmdir(), QDir::mkpath() and QDir::rmpath()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 02:52:01 +00:00
Ivailo Monev
9576d9afc6
return if writing function failed in QSettingsPrivate::write()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 17:14:41 +00:00
Ivailo Monev
386e6fc3d4
require strerror_r(), realpath() and unsetenv() from the host
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 01:26:40 +00:00
Ivailo Monev
20732569ea
avoid temporary in QDir::setSearchPaths()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 22:22:49 +00:00
Ivailo Monev
a18cf42a18
use foreach() for iteration in QDirIteratorPrivate::matchesFilters()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 22:10:48 +00:00
Ivailo Monev
e7d17d4d43
adjust QTemporaryFile asserts
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 21:42:58 +00:00
Ivailo Monev
0ddfd03816
mark the invalid environment variable case as unlikely in QProcessEnvironmentPrivate::fromList()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 21:15:08 +00:00
Ivailo Monev
55bc45e1b0
reserve space for elements from QProcessEnvironmentPrivate::fromList()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 21:14:14 +00:00
Ivailo Monev
224f70fe26
remove now redundant qcoreapplication header inclusion from qtemporaryfile source file
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 21:11:32 +00:00
Ivailo Monev
80429a77e1
remove compatibility bits from createFileFromTemplate() function
...
fixes crash/assert too and increase default template length to 10 to deal
with collisions
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 19:42:22 +00:00
Ivailo Monev
7345cfb219
replace typedefs with the actual type in createFileFromTemplate() function
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 17:08:12 +00:00
Ivailo Monev
b66b126357
optimize QInotifyFileSystemWatcherEngine::create() for case when IN_CLOEXEC is defined
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 04:21:13 +00:00
Ivailo Monev
a30a008b15
remove redundant fcntl() call in QInotifyFileSystemWatcherEngine::QInotifyFileSystemWatcherEngine()
...
also called in QInotifyFileSystemWatcherEngine::create()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 04:19:09 +00:00
Ivailo Monev
3548acfe09
reduce branches in QFileSystemIterator::QFileSystemIterator()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 04:05:45 +00:00
Ivailo Monev
c2b94eabbd
remove redundant internal QFSFileEnginePrivate methods
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 00:13:57 +00:00
Ivailo Monev
d96e81105a
mark QDir warning cases as unlikely
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-04 23:47:12 +00:00
Ivailo Monev
be63c5b251
reduce branches in QDir::operator==() operator
...
also fixes test case
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-03 03:15:15 +00:00
Ivailo Monev
9509ddce3d
check if additional sorting flags are empty in QDir::operator<<() operator
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-03 02:50:25 +00:00
Ivailo Monev
2d3f663456
replace hardcoded mask with enum in QDir::operator<<() operator
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-03 02:37:10 +00:00