Commit graph

208 commits

Author SHA1 Message Date
Ivailo Monev
d236165d11 simplify the QSettings write check
the previous implementation was supposed to be write-optimized, for cases
when QSettings::setValue() followed by QSettings::sync() is called often.
it turns out that optimizing for reading from the settings without changing
the object is more beneficial as that is often the case.

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-24 19:19:48 +00:00
Ivailo Monev
c797b18733 optimize key/value and section/key splitting in ini_settings_read() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-24 18:18:24 +00:00
Ivailo Monev
d307c6e3b0 lock QSettingsPrivate object that work with the same file only from QSettingsPrivate::write()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-24 09:35:43 +00:00
Ivailo Monev
4cd28d3113 use consistent name for locker in QSettingsPrivate::write()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-24 07:29:08 +00:00
Ivailo Monev
3643bf444e remove redundant QT_NO_QOBJECT definition checks from qsettings_p header
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-24 05:14:42 +00:00
Ivailo Monev
1fc3be7d81 fix synchronization of QSettings between multiple processes
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-24 05:13:55 +00:00
Ivailo Monev
7769bca600 rework QSettings, use JSON as native format for it
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-24 01:30:39 +00:00
Ivailo Monev
1487a827fd remove superfluous semicolon in QFile::encodeName()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-21 19:46:45 +00:00
Ivailo Monev
a8320dcf65 compiler warning fixes
upstream commit:
ef36fd0217

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-20 03:24:36 +00:00
Ivailo Monev
6a4f6ed0b4 quote value of GETCWDFUNCNAME so that it is considered as literal string by the compiler
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-19 00:42:41 +00:00
Ivailo Monev
0ff1805a8e avoid stat() in QFileSystemEngine::currentPath()
both get_current_dir_name() and getcwd() do it internally, atleast in glibc

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-19 00:13:38 +00:00
Ivailo Monev
9d66370a40 PATH_MAX is not required to call get_current_dir_name()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-18 23:46:51 +00:00
Ivailo Monev
e3e8cbcb2f optimize QFileSystemEngine::homePath() and QFileSystemEngine::tempPath()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-18 22:57:35 +00:00
Ivailo Monev
ac7b0f4508 avoid temporary in QFileSystemEngine::setCurrentPath()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-18 22:50:13 +00:00
Ivailo Monev
2f86abdf84 set argv to full path to program in QProcessPrivate::startDetached()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-18 15:25:10 +00:00
Ivailo Monev
9585bd773c mark certain core component options unsupported
this is mostly automated change set, a lot to be done later on
especially about the definitions in core component. the goal is
to make most of the options of the core component available so
that they can be utilized in other components and tools without
restrictions as shown by some of the changes done to the GUI
component in this commit

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-18 00:00:13 +00:00
Ivailo Monev
7c0ae45047 QStandardPaths, QJsonArray, QJsonObject::iterator, QJsonParseError and QJsonValue are available since 4.9
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-17 03:35:13 +00:00
Ivailo Monev
e3a47bbe28 remove QStandrdPaths mac and windows specific documentation
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-17 03:34:10 +00:00
Ivailo Monev
b71a71bf41 avoid shadowing argument variable
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-17 03:27:58 +00:00
Ivailo Monev
d8b8dfb697 avoid temporaries in QStandardPaths::findExecutable()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-16 22:32:32 +00:00
Ivailo Monev
06526cb868 set error from errno before calling close() in QFileSystemEngine::copyFile()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-14 22:49:47 +00:00
Ivailo Monev
05982d0b07 make use of Q_DECLARE_FLAGS() macro in QStandardPaths
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-14 22:35:26 +00:00
Ivailo Monev
dfab8f5fb3 QStandardPaths cleanup
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-14 22:33:55 +00:00
Ivailo Monev
f2806e5133 make use of Q_DISABLE_COPY() macro in QStandardPaths
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-14 22:18:27 +00:00
Ivailo Monev
8b48335910 use const iterator in QProcessManager::catchDeadChildren()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-14 22:10:18 +00:00
Ivailo Monev
f673d2625b remove redundant header inclusions from qprocess_unix source file
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-14 22:05:45 +00:00
Ivailo Monev
b7ae2e2ceb remove redundant header inclusions from qfilesystemiterator_p header
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-14 22:00:22 +00:00
Ivailo Monev
1952a1d0d8 update QDataStream::Version enum documentation [ci skip]
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-14 12:38:38 +00:00
Ivailo Monev
f0c42af362 implement file copying for Linux
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-13 12:58:56 +00:00
Ivailo Monev
11e344b851 remove redundant QFileSystemEntry constructor
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-13 01:20:10 +00:00
Ivailo Monev
e908e40c08 remove redundant sysconf() query in QFileSystemEngine::resolveGroupName()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-12 22:48:39 +00:00
Ivailo Monev
b6254cd91b avoid temporaries in QFileSystemEngine::fillMetaData()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-11 03:47:07 +00:00
Ivailo Monev
c61af5faf0 fix build with QTEXTSTREAM_DEBUG defined
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-05 17:13:51 +00:00
Ivailo Monev
5eae3717c6 remove redundant includes from qtextstream source file
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-05 17:13:07 +00:00
Ivailo Monev
975e1d7b88 reserve space when streaming QSet and QHash in QDataStream
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-04 21:43:02 +00:00
Ivailo Monev
b6bf8c0298 use foreach() for iteration in QSettingsPrivate::variantListToStringList()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-03 13:09:57 +00:00
Ivailo Monev
774b7ed6cf inline and avoid temporary in containsTLDEntry() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-11-28 20:41:24 +00:00
Ivailo Monev
bf4937524d remove duplicate header inclusions
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-11-27 23:22:53 +00:00
Ivailo Monev
f57018a7ce suppress warnings caused by ignoring chdir retval
upstream commit:
c7da50ef8c

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-11-27 22:32:51 +00:00
Ivailo Monev
f40fc06760 use script instead of utility to generate URL TLDs table
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-11-26 19:08:55 +00:00
Ivailo Monev
b64bedf92f update URL TLDs
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-11-26 18:22:08 +00:00
Ivailo Monev
dc094d4be5 avoid two character lookups in qIsEffectiveTLD() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-11-26 18:20:58 +00:00
Ivailo Monev
b24596c151 assume const methods are thread-safe and avoid locking where possible
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-11-25 12:21:46 +00:00
Ivailo Monev
3682f3332e remove now redundant IDN whitelist support from QUrl
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-11-25 05:15:34 +00:00
Ivailo Monev
2ecefbccc3 convert input domain to UTF-8 in QUrl::fromAce()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-11-25 05:14:45 +00:00
Ivailo Monev
79ed7e3154 resize result string accordingly in QUrl::fromAce() and QUrl::toAce()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-11-25 03:59:22 +00:00
Ivailo Monev
c6ff4febc1 reimplement QUrl::toAce() and QUrl::fromAce() via ICU
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-11-25 03:10:45 +00:00
Ivailo Monev
82f1d03b02 backport ICU text codec
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-11-23 00:38:10 +00:00
Ivailo Monev
8fe1ac1887 use static QChar::isHighSurrogate() and QChar::isLowSurrogate() where applicable
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-11-20 22:10:40 +00:00
Ivailo Monev
c307801f69 replace QT_BUILD_CORE_LIB with QT_BOOTSTRAPPED definition checks
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-11-17 00:24:00 +00:00