Ivailo Monev
e565f8d57a
remove supposedly fast scrolling case from QComboBoxPrivateScroller
...
the timer has 100ms interval so emiting three signals in a row and checking
for conditions on mouse events is sub-optimal
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 21:53:38 +00:00
Ivailo Monev
f826058fd8
use foreach() for iteration in QDBusMessagePrivate::makeLocal()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 19:09:33 +00:00
Ivailo Monev
9576d9afc6
return if writing function failed in QSettingsPrivate::write()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 17:14:41 +00:00
Ivailo Monev
4735a83eb9
use foreach() for iteration in QFormBuilderExtra::applyBuddy()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 16:43:23 +00:00
Ivailo Monev
b3789548a9
replze 0 with Q_NULLPTR in QFormBuilderExtra::applyBuddy()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 16:38:57 +00:00
Ivailo Monev
258fd75d6e
use foreach() for iteration in QAbstractFormBuilder::setupColorGroup()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 16:33:20 +00:00
Ivailo Monev
537bf382f8
avoid temporary in QAbstractFormBuilder::computeProperties()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 16:32:55 +00:00
Ivailo Monev
e3dcc6595f
remove redundant QDir class forward declaration from textbuilder_p header
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 16:21:13 +00:00
Ivailo Monev
3049209062
replace Q_ASSERT(0) with Q_ASSERT(false)
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 16:09:02 +00:00
Ivailo Monev
877273cf80
use foreach() for iteration in QAbstractFormBuilder::applyProperties()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 15:49:22 +00:00
Ivailo Monev
b6e8806ebd
mark QAbstractFormBuilder::toVariant() property argument as const
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 15:48:59 +00:00
Ivailo Monev
721007a0bb
add operator<(const QElapsedTimer &v1, const QElapsedTimer &v2) for tests
...
removed before the initial import for some reason
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 14:06:11 +00:00
Ivailo Monev
e32c3cc797
use fromstrerror_helper() to obtain error in qdlerror()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 01:44:19 +00:00
Ivailo Monev
fdfcab44c5
check return value of strerror_r() in fromstrerror_helper()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 01:42:57 +00:00
Ivailo Monev
386e6fc3d4
require strerror_r(), realpath() and unsetenv() from the host
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 01:26:40 +00:00
Ivailo Monev
b08a1960b6
remove unused QLCDNumberPrivate::drawString() argument
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 23:49:53 +00:00
Ivailo Monev
700ea6772b
remove redundant uint() constructs in QBitArray::testBit(), QBitArray::setBit(), QBitArray::clearBit() and QBitArray::toggleBit()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 23:39:13 +00:00
Ivailo Monev
45f9f5520a
remove redundant header inclusions from qglobal source file
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 23:33:19 +00:00
Ivailo Monev
f65b3e08c0
remove redundant QT_ARMFPA definition check in qnumeric source file
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 23:30:01 +00:00
Ivailo Monev
7ae205c0db
remove redundant const_cast<> in QDomTextPrivate::save()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 23:18:16 +00:00
Ivailo Monev
a5745b57ef
mark QDomTextPrivate::splitText() warning case as unlikely
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 23:17:55 +00:00
Ivailo Monev
d0ce2f3cda
call parent connect() rather than QObject::connect() in QDBusServer constructor
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 22:55:48 +00:00
Ivailo Monev
740908bc95
replace 0 with Q_NULLPTR in QDBusPendingCallPrivate constructor
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 22:54:55 +00:00
Ivailo Monev
f25e2aace8
use static QString::number() in QDomElement::setAttribute()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 22:54:30 +00:00
Ivailo Monev
653549b4e4
remove unused qDBusRegisterMetaType() argument
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 22:31:23 +00:00
Ivailo Monev
20732569ea
avoid temporary in QDir::setSearchPaths()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 22:22:49 +00:00
Ivailo Monev
a18cf42a18
use foreach() for iteration in QDirIteratorPrivate::matchesFilters()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 22:10:48 +00:00
Ivailo Monev
e7d17d4d43
adjust QTemporaryFile asserts
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 21:42:58 +00:00
Ivailo Monev
0ddfd03816
mark the invalid environment variable case as unlikely in QProcessEnvironmentPrivate::fromList()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 21:15:08 +00:00
Ivailo Monev
55bc45e1b0
reserve space for elements from QProcessEnvironmentPrivate::fromList()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 21:14:14 +00:00
Ivailo Monev
224f70fe26
remove now redundant qcoreapplication header inclusion from qtemporaryfile source file
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 21:11:32 +00:00
Ivailo Monev
80429a77e1
remove compatibility bits from createFileFromTemplate() function
...
fixes crash/assert too and increase default template length to 10 to deal
with collisions
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 19:42:22 +00:00
Ivailo Monev
7345cfb219
replace typedefs with the actual type in createFileFromTemplate() function
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 17:08:12 +00:00
Ivailo Monev
a072d774fe
indent QDBusMetaType::signatureToType() and QDBusMetaType::signatureToType()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 15:04:20 +00:00
Ivailo Monev
c7cc0af760
avoid temporary in QDBusMetaType::demarshall()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 15:03:38 +00:00
Ivailo Monev
b66b126357
optimize QInotifyFileSystemWatcherEngine::create() for case when IN_CLOEXEC is defined
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 04:21:13 +00:00
Ivailo Monev
a30a008b15
remove redundant fcntl() call in QInotifyFileSystemWatcherEngine::QInotifyFileSystemWatcherEngine()
...
also called in QInotifyFileSystemWatcherEngine::create()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 04:19:09 +00:00
Ivailo Monev
3548acfe09
reduce branches in QFileSystemIterator::QFileSystemIterator()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 04:05:45 +00:00
Ivailo Monev
c2b94eabbd
remove redundant internal QFSFileEnginePrivate methods
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 00:13:57 +00:00
Ivailo Monev
d96e81105a
mark QDir warning cases as unlikely
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-04 23:47:12 +00:00
Ivailo Monev
f97b62be7d
replace break and falltrough with return in QMimeDataPrivate::getData()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-04 22:55:48 +00:00
Ivailo Monev
bcf42d4131
replace 0 with Q_NULLPTR in QPaintEngineExPrivate::QPaintEngineExPrivate()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-04 22:20:33 +00:00
Ivailo Monev
3723028ce0
use single variable assignment in QDBusConnectionManager::removeConnection()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-04 21:20:24 +00:00
Ivailo Monev
433fd4e3af
replace 0 with Q_NULLPTR in QDBusConnectionManager::connection()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-04 21:19:20 +00:00
Ivailo Monev
b3a488ca6b
require suffix to be passed to QFactoryLoader constructor
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-04 18:48:56 +00:00
Ivailo Monev
829cc408ff
use static keys list in QGraphicsSystemFactory::keys() when build with QT_NO_LIBRARY defined
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-04 18:45:50 +00:00
Ivailo Monev
6029990b42
add braces around multi-line loop in QMetaObject::indexOfProperty()
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-04 18:08:28 +00:00
Ivailo Monev
46d70d6fd0
mark some warning cases as unlikely
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-04 18:07:51 +00:00
Ivailo Monev
6b02b5dae4
update internal QEvent::Type enums documentation [ci skip]
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-04 17:17:57 +00:00
Ivailo Monev
00dee66096
update hand-edited moc-generated code
...
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-04 15:58:23 +00:00