Commit graph

273 commits

Author SHA1 Message Date
Ivailo Monev
990b8f570b remove redundant int() constructs from qt_error_string() function calls
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-12 03:06:01 +00:00
Ivailo Monev
605292785f remove redundant condition in QFSFileEnginePrivate::readFdFh()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-12 02:39:22 +00:00
Ivailo Monev
f9088610ff mark warning cases in QFSFileEngine as unlikely
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-12 02:39:01 +00:00
Ivailo Monev
bf349cbb86 introduce QT_BUFFSIZE
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-11 23:38:06 +00:00
Ivailo Monev
7652249aa5 Merge branch 'refileengine' 2020-01-11 20:41:42 +00:00
Ivailo Monev
e02ce5c0e0 cleanup file engine, notably the Qt resource part
this is fixes QTBUG-11223, I also would like to take it step further
and make the resources requests prefixed with "qrc:/" so that the
check when to use QResourceFileEngine is even more reliable but
that will require backwards incompatible change so it will be done
in future release.

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-11 20:39:33 +00:00
Ivailo Monev
c2badc8aaf define QIODEVICE_BUFFERSIZE to value of BUFSIZ from stdio header
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-11 02:55:23 +00:00
Ivailo Monev
a251c3c722 set error to QFile::CopyError in case of failure in QFile::copy()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-11 01:29:22 +00:00
Ivailo Monev
310bfaa051 implement QFileSystemEngine::copyFile() for non-Linux platforms
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-10 21:04:10 +00:00
Ivailo Monev
a25d7504f9 replace hardcodec value with enum in QFile::exists()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-10 01:13:16 +00:00
Ivailo Monev
86bf2c1c10 use correct type for flags in QFile::exists() and restore behaviour of QDir::exists() overload
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-10 01:12:14 +00:00
Ivailo Monev
571ebf899a remove most std::bad_alloc exceptions handling
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-09 02:15:39 +00:00
Ivailo Monev
e1b4131846 check type in QFile::exists() and QDir::exists()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-09 01:38:03 +00:00
Ivailo Monev
78547c1787 Revert "avoid temporaries in QDir::mkdir(), QDir::rmdir(), QDir::mkpath() and QDir::rmpath()"
This reverts commit b0112afc64.
2020-01-07 22:59:01 +00:00
Ivailo Monev
8807a2ffcb correct loop expression in createFileFromTemplate()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 15:14:55 +00:00
Ivailo Monev
c7b36ea3ea check for getpwuid_r() and getgrgid_r() functions
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 14:27:48 +00:00
Ivailo Monev
a72408581c fix QFileSystemEngine::createDirectory() and QFileSystemEngine::removeDirectory()
the life-time of the string created by QFile::encodeName() was probably
optimized out by the compiler causing the variables of char array type to
contain invalid data

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 03:31:24 +00:00
Ivailo Monev
1d0f3d39f0 pass size of string to QString::fromLocal8Bit() where known
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 02:52:55 +00:00
Ivailo Monev
b0112afc64 avoid temporaries in QDir::mkdir(), QDir::rmdir(), QDir::mkpath() and QDir::rmpath()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 02:52:01 +00:00
Ivailo Monev
9576d9afc6 return if writing function failed in QSettingsPrivate::write()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 17:14:41 +00:00
Ivailo Monev
386e6fc3d4 require strerror_r(), realpath() and unsetenv() from the host
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 01:26:40 +00:00
Ivailo Monev
20732569ea avoid temporary in QDir::setSearchPaths()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 22:22:49 +00:00
Ivailo Monev
a18cf42a18 use foreach() for iteration in QDirIteratorPrivate::matchesFilters()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 22:10:48 +00:00
Ivailo Monev
e7d17d4d43 adjust QTemporaryFile asserts
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 21:42:58 +00:00
Ivailo Monev
0ddfd03816 mark the invalid environment variable case as unlikely in QProcessEnvironmentPrivate::fromList()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 21:15:08 +00:00
Ivailo Monev
55bc45e1b0 reserve space for elements from QProcessEnvironmentPrivate::fromList()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 21:14:14 +00:00
Ivailo Monev
224f70fe26 remove now redundant qcoreapplication header inclusion from qtemporaryfile source file
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 21:11:32 +00:00
Ivailo Monev
80429a77e1 remove compatibility bits from createFileFromTemplate() function
fixes crash/assert too and increase default template length to 10 to deal
with collisions

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 19:42:22 +00:00
Ivailo Monev
7345cfb219 replace typedefs with the actual type in createFileFromTemplate() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 17:08:12 +00:00
Ivailo Monev
b66b126357 optimize QInotifyFileSystemWatcherEngine::create() for case when IN_CLOEXEC is defined
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 04:21:13 +00:00
Ivailo Monev
a30a008b15 remove redundant fcntl() call in QInotifyFileSystemWatcherEngine::QInotifyFileSystemWatcherEngine()
also called in QInotifyFileSystemWatcherEngine::create()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 04:19:09 +00:00
Ivailo Monev
3548acfe09 reduce branches in QFileSystemIterator::QFileSystemIterator()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 04:05:45 +00:00
Ivailo Monev
c2b94eabbd remove redundant internal QFSFileEnginePrivate methods
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 00:13:57 +00:00
Ivailo Monev
d96e81105a mark QDir warning cases as unlikely
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-04 23:47:12 +00:00
Ivailo Monev
be63c5b251 reduce branches in QDir::operator==() operator
also fixes test case

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-03 03:15:15 +00:00
Ivailo Monev
9509ddce3d check if additional sorting flags are empty in QDir::operator<<() operator
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-03 02:50:25 +00:00
Ivailo Monev
2d3f663456 replace hardcoded mask with enum in QDir::operator<<() operator
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-03 02:37:10 +00:00
Ivailo Monev
5d0e87be33 reduce branches in QDataStream::operator>>() operators
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-03 01:31:19 +00:00
Ivailo Monev
05d7040b30 remove redundant Q_DOUBLE_FORMAT definition check
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-03 01:28:52 +00:00
Ivailo Monev
7d011143bc update URL TLDs table [ci skip]
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-02 18:19:38 +00:00
Ivailo Monev
6a37828fa8 fix regression since 28b8a590c1
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-02 17:32:59 +00:00
Ivailo Monev
0e92ef89b9 Revert "rework QPollingFileSystemWatcherEngine to use QFileInfo for files"
QFileInfo equal operator does not compare all attributes

This reverts commit 9812469490.
2020-01-02 17:31:21 +00:00
Ivailo Monev
9812469490 rework QPollingFileSystemWatcherEngine to use QFileInfo for files
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-02 16:53:28 +00:00
Ivailo Monev
f54e0ee862 print warning on parser error from json_settings_read() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-01 18:09:02 +00:00
Ivailo Monev
86ce17c2cf convert QVariant::String to/from QVariant::StringList type based on delimiter
the conversion covers the most common cases, further improvements like
splitting quoted strings can be done in the future

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-01 11:57:34 +00:00
Ivailo Monev
6d633966a2 merge .cmake into CMakeLists.txt files
this way it is easier to maintain and should reduce the time spend on
configuring the project when building, much like the all-in-one build
option

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-31 04:28:36 +00:00
Ivailo Monev
43f3a2a47b remove redundant QStringSplitter() members
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-30 05:23:19 +00:00
Ivailo Monev
5b459cf0ec update copyright and add script for doing so
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-29 23:21:34 +00:00
Ivailo Monev
b30f1284b6 make stat() error checks consisten in QFileSystemEngine::createDirectory(), QFileSystemEngine::removeDirectory() and QFileSystemEngine::copyFile()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-29 06:04:16 +00:00
Ivailo Monev
6a54eadeba remove redundant condition in QFileSystemEngine::fillMetaData()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-29 05:44:52 +00:00