Ivailo Monev
909aad3c9f
close the file descriptor even if lseek() fails in QFSFileEngine::open()
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-12-12 14:17:53 +00:00
Ivailo Monev
bc636ef716
reduce branches in QFSFileEngine::close()
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-12-12 13:05:24 +00:00
Ivailo Monev
7b7bd36858
remove redundant QFSFileEnginePrivate::triet_stat member
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-12-12 13:00:57 +00:00
Ivailo Monev
cf96bdabd1
initialize all QFileSystemMetaData members
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-12-11 12:38:16 +00:00
Ivailo Monev
aad8136ddc
avoid pid_t conversion in QProcessPrivate
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-12-10 13:25:46 +00:00
Ivailo Monev
251e6f4cc0
update copyright in files imported from CopperSpice
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-12-09 05:01:57 +00:00
Ivailo Monev
a772dd3ff5
merge inotify and kevent watchers into QFileSystemWatcherEngineUnix
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-12-09 05:01:56 +00:00
Ivailo Monev
ef72c454ba
DragonFly BSD build fixes
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-12-08 12:56:38 +00:00
Ivailo Monev
76ba983d86
update URL TLDs
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-12-05 01:11:01 +00:00
Ivailo Monev
3f806eccb1
do not fallback to modification time in QFileSystemMetaData::fillFromStatBuf()
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-12-04 20:49:16 +00:00
Ivailo Monev
4b1bac1bc0
remove redundant branch in QIODevice::seek()
...
missed a hunk, should've been applied with a0ef87cd2b
upstream commit:
05d980664f
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-12-04 11:48:17 +00:00
Ivailo Monev
14ec74239b
fix some static analyzer warnings
...
upstream commit:
8936918a65
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-12-01 21:44:39 +00:00
Ivailo Monev
13b48ebdb1
place all private headers in single directory
...
should reduce the build time and also the length of the commands used
during build
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-12-01 19:20:31 +00:00
Ivailo Monev
47c9fb9534
use foreach() for iteration in QDirIteratorPrivate constructor
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-30 22:31:44 +00:00
Ivailo Monev
e88c8d972d
fix possible sm_performSaveYourself() thread-safety issue
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-27 02:50:47 +00:00
Ivailo Monev
5717bc5056
remove redundant QT_PLUGIN definition
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-26 16:10:11 +00:00
Ivailo Monev
6e1da5a137
effectively revert 26bf3aacd3
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-26 15:56:09 +00:00
Ivailo Monev
e566f1ed4f
do not export QSettingsPrivate for test builds
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-25 22:29:37 +00:00
Ivailo Monev
4580c21ce9
QKqueueFileSystemWatcherEngine review
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-23 19:19:02 +00:00
Ivailo Monev
7a47d0a394
remove redundant QFileSystemEngine::isCaseSensitive()
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-22 19:02:17 +00:00
Ivailo Monev
1ce277bb9d
Solaris build fixes
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-22 15:42:37 +00:00
Ivailo Monev
12eff871eb
replace QT_NO_GEOM_VARIANT with QT_BOOTSTRAPPED
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-19 14:46:30 +02:00
Ivailo Monev
1bc1c04955
use exclusive branches in QFSFileEngine::extension()
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-11 14:05:31 +02:00
Ivailo Monev
b74d450eb7
make QBuffer::bytesAvailable() work
...
upstream commit:
b4ce49287f
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-11 02:21:13 +02:00
Ivailo Monev
a956344dbf
NetBSD and OpenBSD build fixes
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-11 01:23:56 +02:00
Ivailo Monev
2cbc42ca74
compiler warning fix
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-09 08:02:01 +02:00
Ivailo Monev
26bf3aacd3
check modification time from QSettings read methods
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-09 04:41:36 +02:00
Ivailo Monev
74e2ee84a3
remove redundant QT_BOOTSTRAPPED guard
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-09 01:19:45 +02:00
Ivailo Monev
031db8ed0b
do not use O_SYNC for QIODevice::Unbuffered mode in QFSFileEngine
...
it causes way too much disk I/O for a single fd flush
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-08 07:46:08 +02:00
Ivailo Monev
0650b09230
check if location is writable in getSettingsPath()
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-08 06:22:49 +02:00
Ivailo Monev
4cd90671a7
drop QLibraryInfo::SettingsPath support
...
it has no reliable meaning since QSettings has a system/user scope feature
and it is not guaranteed that settings are actually stored there
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-08 04:24:25 +02:00
Ivailo Monev
913ed486bf
remove redundant check in QFSFileEngine::open()
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-08 04:04:52 +02:00
Ivailo Monev
0c2258d8e5
remove TODO about QProcess::pid()
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-08 03:05:52 +02:00
Ivailo Monev
a380f56792
assume Q_OS_UNIX is defined in most source files
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-07 22:55:39 +02:00
Ivailo Monev
c1fc863742
mark arguments of some QProcessPrivate methods as required
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-07 10:13:36 +02:00
Ivailo Monev
43b958f258
remove now incorrect comment in QFSFileEngine::seek()
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-07 10:12:58 +02:00
Ivailo Monev
96151d9d14
minor QFileSystemEngine::fillMetaData() optimization
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-07 10:12:36 +02:00
Ivailo Monev
96ab42d78a
QFSFileEngine cleanup
...
further I/O optimizations may be made via posix_fadvise() and maybe
by getting rid of the write buffer management in QFile and letting
the OS deal with buffering. more research, tests, etc. will have
to be made ofcourse.
on a side note, https://www.gnu.org/software/libc/manual/html_node/Operating-Modes.html
mentions that O_SYNC is another name for O_FSYNC which is a BSD feature
but is currently supported by Linux too. another book reference I found
was in POSIX.4 Programming for Real World by Bill O. Gallmeister, page
281. there it is written that additions are unconditional, if
_POSIX_VERSION is greater or equal than 199309 which is safe to assume
at this point of time I guess.
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-07 08:05:30 +02:00
Ivailo Monev
04d1139533
avoid temporary in QFile::readLineData()
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-11-06 16:47:39 +02:00
Ivailo Monev
6251e7309c
fix build on FreeBSD
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-10-26 05:00:21 +02:00
Ivailo Monev
ec33f79e3a
cache result of getpagesize() per-thread in QFSFileEnginePrivate::map()
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-10-26 03:17:04 +02:00
Ivailo Monev
1898145e36
remove redundant branch in QFileInfoPrivate::getFileOwner()
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-10-26 03:10:11 +02:00
Ivailo Monev
c8b8501f00
optimize QFSFileEngine::fileFlags()
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-10-25 19:27:50 +02:00
Ivailo Monev
f216a5920d
cache result of fileno() in QFSFileEnginePrivate::nativeRead()
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-10-24 22:27:14 +03:00
Ivailo Monev
fa53fe67dd
get rid of QProcessInfo::pid member
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-10-21 21:18:44 +03:00
Ivailo Monev
209a907a72
remove unused QProcessInfo::exitResult member
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-10-21 21:12:40 +03:00
Ivailo Monev
0f3ff25f0b
reuse PID as serial in QProcessManager
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-10-21 21:11:05 +03:00
Ivailo Monev
24c508edc5
use proper type for QProcessPrivate::type member
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-10-21 16:32:49 +03:00
Ivailo Monev
84ba541b9c
remove unused QProcessPrivate::sequenceNumber member
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-10-21 16:32:09 +03:00
Ivailo Monev
3ab11e5ed5
remove unused and internal QProcessPrivate::waitForWrite()
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-10-21 04:47:05 +03:00