Commit graph

2833 commits

Author SHA1 Message Date
Ivailo Monev
b6d85e6e48 remove unused USE_LEXEM_STORE definition and conditionals from moc source files
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-08 02:00:06 +00:00
Ivailo Monev
f5489f2380 remove redundant qdatetime header inclusion from moc source file
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-08 01:50:36 +00:00
Ivailo Monev
563cca94a8 mark warning, null and incompatible signal/slot QObject cases as unlikely
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-08 01:31:23 +00:00
Ivailo Monev
1435a6a292 use loop-local variables in qt_qFindChildren_helper() functions
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-08 01:13:09 +00:00
Ivailo Monev
28afb68973 replace 0 with Q_NULLPTR in qt_qFindChild_helper()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-08 01:12:41 +00:00
Ivailo Monev
fec7780f92 replace QHash with QSet where applicable
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-08 00:23:39 +00:00
Ivailo Monev
a08c5e51fc add assert to qChecksum32()
the function is stub for bootstrapped build only and should not be used in
that case

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-08 00:04:51 +00:00
Ivailo Monev
78547c1787 Revert "avoid temporaries in QDir::mkdir(), QDir::rmdir(), QDir::mkpath() and QDir::rmpath()"
This reverts commit b0112afc64.
2020-01-07 22:59:01 +00:00
Ivailo Monev
2233f7db2f mark gethostname() success as likely in QHostInfo::localHostName()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 22:42:25 +00:00
Ivailo Monev
b5e367cb91 correct localtime_r() check in QDateTime::currentDateTime()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 18:53:21 +00:00
Ivailo Monev
17e9b1732c obtain getpwnam_r() buffer size via sysconf() in qt_tildeExpansion() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 18:05:09 +00:00
Ivailo Monev
522e6c0f32 check for getpwnam_r() function during configuration
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 17:59:32 +00:00
Ivailo Monev
8a014987a6 check for localtime_r() and gmtime_r() functions during configuration
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 17:40:17 +00:00
Ivailo Monev
196cc93bed inline qstricmp()/qstrnicmp() to strcasecmp()/strncasecmp() functions
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 16:54:49 +00:00
Ivailo Monev
4c637d231f introduce qChecksum32()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 16:06:02 +00:00
Ivailo Monev
d18fbf40cc remove unused report_error() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 15:48:31 +00:00
Ivailo Monev
1a8b0f99a7 remove redundant scoping in QDBusMetaType::typeToSignature()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 15:45:17 +00:00
Ivailo Monev
d220596b9a replace 0 with Q_NULLPTR in QDBusMetaType::typeToSignature()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 15:44:44 +00:00
Ivailo Monev
8807a2ffcb correct loop expression in createFileFromTemplate()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 15:14:55 +00:00
Ivailo Monev
c7b36ea3ea check for getpwuid_r() and getgrgid_r() functions
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 14:27:48 +00:00
Ivailo Monev
6943b3bb4a use QTime instead of QDateTime as random seed
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 04:59:52 +00:00
Ivailo Monev
a72408581c fix QFileSystemEngine::createDirectory() and QFileSystemEngine::removeDirectory()
the life-time of the string created by QFile::encodeName() was probably
optimized out by the compiler causing the variables of char array type to
contain invalid data

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 03:31:24 +00:00
Ivailo Monev
1d0f3d39f0 pass size of string to QString::fromLocal8Bit() where known
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 02:52:55 +00:00
Ivailo Monev
b0112afc64 avoid temporaries in QDir::mkdir(), QDir::rmdir(), QDir::mkpath() and QDir::rmpath()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-07 02:52:01 +00:00
Ivailo Monev
3465d69d5d avoid temporaries in QComboBoxPrivate::emitActivated() and QComboBoxPrivate::_q_emitHighlighted()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 22:08:55 +00:00
Ivailo Monev
48a7c4a118 use signle variable assignment in QComboBox::findData()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 21:58:15 +00:00
Ivailo Monev
e565f8d57a remove supposedly fast scrolling case from QComboBoxPrivateScroller
the timer has 100ms interval so emiting three signals in a row and checking
for conditions on mouse events is sub-optimal

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 21:53:38 +00:00
Ivailo Monev
f826058fd8 use foreach() for iteration in QDBusMessagePrivate::makeLocal()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 19:09:33 +00:00
Ivailo Monev
9576d9afc6 return if writing function failed in QSettingsPrivate::write()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 17:14:41 +00:00
Ivailo Monev
4735a83eb9 use foreach() for iteration in QFormBuilderExtra::applyBuddy()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 16:43:23 +00:00
Ivailo Monev
b3789548a9 replze 0 with Q_NULLPTR in QFormBuilderExtra::applyBuddy()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 16:38:57 +00:00
Ivailo Monev
258fd75d6e use foreach() for iteration in QAbstractFormBuilder::setupColorGroup()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 16:33:20 +00:00
Ivailo Monev
537bf382f8 avoid temporary in QAbstractFormBuilder::computeProperties()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 16:32:55 +00:00
Ivailo Monev
e3dcc6595f remove redundant QDir class forward declaration from textbuilder_p header
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 16:21:13 +00:00
Ivailo Monev
3049209062 replace Q_ASSERT(0) with Q_ASSERT(false)
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 16:09:02 +00:00
Ivailo Monev
877273cf80 use foreach() for iteration in QAbstractFormBuilder::applyProperties()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 15:49:22 +00:00
Ivailo Monev
b6e8806ebd mark QAbstractFormBuilder::toVariant() property argument as const
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 15:48:59 +00:00
Ivailo Monev
721007a0bb add operator<(const QElapsedTimer &v1, const QElapsedTimer &v2) for tests
removed before the initial import for some reason

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 14:06:11 +00:00
Ivailo Monev
e32c3cc797 use fromstrerror_helper() to obtain error in qdlerror()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 01:44:19 +00:00
Ivailo Monev
fdfcab44c5 check return value of strerror_r() in fromstrerror_helper()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 01:42:57 +00:00
Ivailo Monev
386e6fc3d4 require strerror_r(), realpath() and unsetenv() from the host
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 01:26:40 +00:00
Ivailo Monev
b08a1960b6 remove unused QLCDNumberPrivate::drawString() argument
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 23:49:53 +00:00
Ivailo Monev
700ea6772b remove redundant uint() constructs in QBitArray::testBit(), QBitArray::setBit(), QBitArray::clearBit() and QBitArray::toggleBit()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 23:39:13 +00:00
Ivailo Monev
45f9f5520a remove redundant header inclusions from qglobal source file
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 23:33:19 +00:00
Ivailo Monev
f65b3e08c0 remove redundant QT_ARMFPA definition check in qnumeric source file
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 23:30:01 +00:00
Ivailo Monev
7ae205c0db remove redundant const_cast<> in QDomTextPrivate::save()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 23:18:16 +00:00
Ivailo Monev
a5745b57ef mark QDomTextPrivate::splitText() warning case as unlikely
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 23:17:55 +00:00
Ivailo Monev
d0ce2f3cda call parent connect() rather than QObject::connect() in QDBusServer constructor
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 22:55:48 +00:00
Ivailo Monev
740908bc95 replace 0 with Q_NULLPTR in QDBusPendingCallPrivate constructor
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 22:54:55 +00:00
Ivailo Monev
f25e2aace8 use static QString::number() in QDomElement::setAttribute()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-05 22:54:30 +00:00