Commit graph

221 commits

Author SHA1 Message Date
Ivailo Monev
2b7b17b002 mark getSettingsPath() function as static
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 04:19:47 +00:00
Ivailo Monev
5a0fa9fa3a compiler warning fixes
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-28 00:04:51 +00:00
Ivailo Monev
9fc98aab48 QDirIterator destructor does not have to be virtual
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-27 15:09:50 +00:00
Ivailo Monev
3e79fdf69f avoid temporary in QDirIteratorPrivate::pushDirectory()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-27 15:07:56 +00:00
Ivailo Monev
999d86187b avoid temporary in QUrl streaming operator
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-27 14:58:54 +00:00
Ivailo Monev
59db1bf9b6 check if path is writable as fallback in QSettings::isWritable()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 22:26:14 +00:00
Ivailo Monev
39598942c6 convert strings to ASCII instead of Latin1 in QSettingsPrivate::variantToString()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 21:52:02 +00:00
Ivailo Monev
e4bd089f5a replace break with return in QSettingsPrivate::variantToString()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 21:51:08 +00:00
Ivailo Monev
c05d3b9b1c convert strings from/to ASCII instead of Latin1 in QSettingsPrivate::variantToString()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 21:50:08 +00:00
Ivailo Monev
b54f92af0e update QSettings documentation [ci skip]
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 21:23:17 +00:00
Ivailo Monev
bdae06e149 update QSettings documentation [ci skip]
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 05:08:38 +00:00
Ivailo Monev
898418ff3c remove redundant QProcEnvKey
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 04:17:48 +00:00
Ivailo Monev
e11b34777c drop redundant QSettings UNIX file locking
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 04:05:43 +00:00
Ivailo Monev
d236165d11 simplify the QSettings write check
the previous implementation was supposed to be write-optimized, for cases
when QSettings::setValue() followed by QSettings::sync() is called often.
it turns out that optimizing for reading from the settings without changing
the object is more beneficial as that is often the case.

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-24 19:19:48 +00:00
Ivailo Monev
c797b18733 optimize key/value and section/key splitting in ini_settings_read() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-24 18:18:24 +00:00
Ivailo Monev
d307c6e3b0 lock QSettingsPrivate object that work with the same file only from QSettingsPrivate::write()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-24 09:35:43 +00:00
Ivailo Monev
4cd28d3113 use consistent name for locker in QSettingsPrivate::write()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-24 07:29:08 +00:00
Ivailo Monev
3643bf444e remove redundant QT_NO_QOBJECT definition checks from qsettings_p header
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-24 05:14:42 +00:00
Ivailo Monev
1fc3be7d81 fix synchronization of QSettings between multiple processes
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-24 05:13:55 +00:00
Ivailo Monev
7769bca600 rework QSettings, use JSON as native format for it
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-24 01:30:39 +00:00
Ivailo Monev
1487a827fd remove superfluous semicolon in QFile::encodeName()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-21 19:46:45 +00:00
Ivailo Monev
a8320dcf65 compiler warning fixes
upstream commit:
ef36fd0217

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-20 03:24:36 +00:00
Ivailo Monev
6a4f6ed0b4 quote value of GETCWDFUNCNAME so that it is considered as literal string by the compiler
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-19 00:42:41 +00:00
Ivailo Monev
0ff1805a8e avoid stat() in QFileSystemEngine::currentPath()
both get_current_dir_name() and getcwd() do it internally, atleast in glibc

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-19 00:13:38 +00:00
Ivailo Monev
9d66370a40 PATH_MAX is not required to call get_current_dir_name()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-18 23:46:51 +00:00
Ivailo Monev
e3e8cbcb2f optimize QFileSystemEngine::homePath() and QFileSystemEngine::tempPath()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-18 22:57:35 +00:00
Ivailo Monev
ac7b0f4508 avoid temporary in QFileSystemEngine::setCurrentPath()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-18 22:50:13 +00:00
Ivailo Monev
2f86abdf84 set argv to full path to program in QProcessPrivate::startDetached()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-18 15:25:10 +00:00
Ivailo Monev
9585bd773c mark certain core component options unsupported
this is mostly automated change set, a lot to be done later on
especially about the definitions in core component. the goal is
to make most of the options of the core component available so
that they can be utilized in other components and tools without
restrictions as shown by some of the changes done to the GUI
component in this commit

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-18 00:00:13 +00:00
Ivailo Monev
7c0ae45047 QStandardPaths, QJsonArray, QJsonObject::iterator, QJsonParseError and QJsonValue are available since 4.9
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-17 03:35:13 +00:00
Ivailo Monev
e3a47bbe28 remove QStandrdPaths mac and windows specific documentation
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-17 03:34:10 +00:00
Ivailo Monev
b71a71bf41 avoid shadowing argument variable
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-17 03:27:58 +00:00
Ivailo Monev
d8b8dfb697 avoid temporaries in QStandardPaths::findExecutable()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-16 22:32:32 +00:00
Ivailo Monev
06526cb868 set error from errno before calling close() in QFileSystemEngine::copyFile()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-14 22:49:47 +00:00
Ivailo Monev
05982d0b07 make use of Q_DECLARE_FLAGS() macro in QStandardPaths
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-14 22:35:26 +00:00
Ivailo Monev
dfab8f5fb3 QStandardPaths cleanup
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-14 22:33:55 +00:00
Ivailo Monev
f2806e5133 make use of Q_DISABLE_COPY() macro in QStandardPaths
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-14 22:18:27 +00:00
Ivailo Monev
8b48335910 use const iterator in QProcessManager::catchDeadChildren()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-14 22:10:18 +00:00
Ivailo Monev
f673d2625b remove redundant header inclusions from qprocess_unix source file
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-14 22:05:45 +00:00
Ivailo Monev
b7ae2e2ceb remove redundant header inclusions from qfilesystemiterator_p header
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-14 22:00:22 +00:00
Ivailo Monev
1952a1d0d8 update QDataStream::Version enum documentation [ci skip]
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-14 12:38:38 +00:00
Ivailo Monev
f0c42af362 implement file copying for Linux
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-13 12:58:56 +00:00
Ivailo Monev
11e344b851 remove redundant QFileSystemEntry constructor
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-13 01:20:10 +00:00
Ivailo Monev
e908e40c08 remove redundant sysconf() query in QFileSystemEngine::resolveGroupName()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-12 22:48:39 +00:00
Ivailo Monev
b6254cd91b avoid temporaries in QFileSystemEngine::fillMetaData()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-11 03:47:07 +00:00
Ivailo Monev
c61af5faf0 fix build with QTEXTSTREAM_DEBUG defined
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-05 17:13:51 +00:00
Ivailo Monev
5eae3717c6 remove redundant includes from qtextstream source file
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-05 17:13:07 +00:00
Ivailo Monev
975e1d7b88 reserve space when streaming QSet and QHash in QDataStream
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-04 21:43:02 +00:00
Ivailo Monev
b6bf8c0298 use foreach() for iteration in QSettingsPrivate::variantListToStringList()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-03 13:09:57 +00:00
Ivailo Monev
774b7ed6cf inline and avoid temporary in containsTLDEntry() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-11-28 20:41:24 +00:00