Katana_mirror/katie
1
0
Fork 0
mirror of https://bitbucket.org/smil3y/katie.git synced 2025-02-25 11:22:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

replace array access with loop-based lookup in QCss::Value::toString()

Browse source 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
This commit is contained in:
Ivailo Monev 2021-09-21 01:55:37 +03:00
parent 36abe581dd
commit fc27061a7b
1 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/gui/text/qcssparser.cpp
View file

@ -222,19 +222,18 @@ static const QCssKnownValue valuesTbl[NumKnownValues - 1] = {
{ QLatin1String("xx-large"), Value_XXLarge } { QLatin1String("xx-large"), Value_XXLarge }
}; };
//Map id to strings as they appears in the 'values' array above
static const short indexOfId[NumKnownValues] = { 0, 41, 48, 42, 49, 54, 35, 26, 70, 71, 25, 43, 5, 63, 47,
29, 58, 59, 27, 51, 61, 6, 10, 39, 56, 19, 13, 17, 18, 20, 21, 50, 24, 46, 67, 37, 3, 2, 40, 62, 16,
11, 57, 14, 32, 64, 33, 65, 55, 66, 34, 69, 8, 28, 38, 12, 36, 60, 7, 9, 4, 68, 53, 22, 23, 30, 31,
1, 15, 0, 52, 45, 44 };
QString Value::toString() const QString Value::toString() const
{ {
if (type == KnownIdentifier) { if (type == KnownIdentifier) {
return valuesTbl[indexOfId[variant.toInt()]].name; const int id = variant.toInt();
} else { for (int i = 0; i < NumKnownValues - 1; i++) {
return variant.toString(); if (id == valuesTbl[i].id) {
return valuesTbl[i].name;
} }
}
Q_ASSERT_X(false, "QCss::Value::toString", "Name of identifier is not known");
}
return variant.toString();
} }
static const QCssKnownValue pseudosTbl[NumPseudos - 1] = { static const QCssKnownValue pseudosTbl[NumPseudos - 1] = {