From c05308e0b0060de0919d125ff8416d967d2987d7 Mon Sep 17 00:00:00 2001 From: Ivailo Monev Date: Tue, 18 Aug 2020 22:20:44 +0300 Subject: [PATCH] remove redundant quality limit check in QPNGImageWriter::writeImage() already mapped from 0-100 to 0-9 in QPngHandler::write() Signed-off-by: Ivailo Monev --- src/gui/image/qpnghandler.cpp | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/gui/image/qpnghandler.cpp b/src/gui/image/qpnghandler.cpp index 584eb4617..c7ad71d5b 100644 --- a/src/gui/image/qpnghandler.cpp +++ b/src/gui/image/qpnghandler.cpp @@ -533,18 +533,11 @@ bool QPNGImageWriter::writeImage(const QImage& image, int quality_in) return false; } - if (quality_in >= 0) { - if (Q_UNLIKELY(quality_in > 9)) { - qWarning("PNG: Quality %d out of range", quality_in); - png_set_compression_level(png_ptr, 9); - } else { - png_set_compression_level(png_ptr, quality_in); - } - } + Q_ASSERT(quality_in >= 0 && quality_in <= 9); + png_set_compression_level(png_ptr, quality_in); png_set_write_fn(png_ptr, (void*)this, qpiw_write_fn, qpiw_flush_fn); - int color_type = 0; if (image.colorCount()) color_type = PNG_COLOR_TYPE_PALETTE;