Katana_mirror/katie
1
0
Fork 0
mirror of https://bitbucket.org/smil3y/katie.git synced 2025-02-24 10:52:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

mark warning case in QFile as unlikely

Browse source 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
This commit is contained in:
Ivailo Monev 2021-08-13 23:07:38 +03:00
parent 310f7d18e3
commit b5bfe3a821
1 changed files with 13 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
src/core/io/qfile.cpp
View file

@ -383,7 +383,7 @@ void
QFile::setFileName(const QString &name) QFile::setFileName(const QString &name)
{ {
Q_D(QFile); Q_D(QFile);
if (isOpen()) { if (Q_UNLIKELY(isOpen())) {
qWarning("QFile::setFileName: File (%s) is already opened", qWarning("QFile::setFileName: File (%s) is already opened",
qPrintable(fileName())); qPrintable(fileName()));
close(); close();
@ -514,7 +514,7 @@ bool
QFile::remove() QFile::remove()
{ {
Q_D(QFile); Q_D(QFile);
if (d->fileName.isEmpty()) { if (Q_UNLIKELY(d->fileName.isEmpty())) {
qWarning("QFile::remove: Empty or null file name"); qWarning("QFile::remove: Empty or null file name");
return false; return false;
} }
@ -562,7 +562,7 @@ bool
QFile::rename(const QString &newName) QFile::rename(const QString &newName)
{ {
Q_D(QFile); Q_D(QFile);
if (d->fileName.isEmpty()) { if (Q_UNLIKELY(d->fileName.isEmpty())) {
qWarning("QFile::rename: Empty or null file name"); qWarning("QFile::rename: Empty or null file name");
return false; return false;
} }
@ -670,7 +670,7 @@ bool
QFile::link(const QString &linkName) QFile::link(const QString &linkName)
{ {
Q_D(QFile); Q_D(QFile);
if (d->fileName.isEmpty()) { if (Q_UNLIKELY(d->fileName.isEmpty())) {
qWarning("QFile::link: Empty or null file name"); qWarning("QFile::link: Empty or null file name");
return false; return false;
} }
@ -716,7 +716,7 @@ bool
QFile::copy(const QString &newName) QFile::copy(const QString &newName)
{ {
Q_D(QFile); Q_D(QFile);
if (d->fileName.isEmpty()) { if (Q_UNLIKELY(d->fileName.isEmpty())) {
qWarning("QFile::copy: Empty or null file name"); qWarning("QFile::copy: Empty or null file name");
return false; return false;
} }
@ -782,7 +782,7 @@ bool QFile::isSequential() const
bool QFile::open(OpenMode mode) bool QFile::open(OpenMode mode)
{ {
Q_D(QFile); Q_D(QFile);
if (isOpen()) { if (Q_UNLIKELY(isOpen())) {
qWarning("QFile::open: File (%s) already open", qPrintable(fileName())); qWarning("QFile::open: File (%s) already open", qPrintable(fileName()));
return false; return false;
} }
@ -790,7 +790,7 @@ bool QFile::open(OpenMode mode)
mode |= WriteOnly; mode |= WriteOnly;
unsetError(); unsetError();
if ((mode & (ReadOnly | WriteOnly)) == 0) { if (Q_UNLIKELY((mode & (ReadOnly | WriteOnly)) == 0)) {
qWarning("QIODevice::open: File access not specified"); qWarning("QIODevice::open: File access not specified");
return false; return false;
} }
@ -846,14 +846,14 @@ bool QFile::open(OpenMode mode)
*/ */
bool QFile::open(FILE *fh, OpenMode mode, FileHandleFlags handleFlags) bool QFile::open(FILE *fh, OpenMode mode, FileHandleFlags handleFlags)
{ {
if (isOpen()) { if (Q_UNLIKELY(isOpen())) {
qWarning("QFile::open: File (%s) already open", qPrintable(fileName())); qWarning("QFile::open: File (%s) already open", qPrintable(fileName()));
return false; return false;
} }
if (mode & Append) if (mode & Append)
mode |= WriteOnly; mode |= WriteOnly;
unsetError(); unsetError();
if ((mode & (ReadOnly | WriteOnly)) == 0) { if (Q_UNLIKELY((mode & (ReadOnly | WriteOnly)) == 0)) {
qWarning("QFile::open: File access not specified"); qWarning("QFile::open: File access not specified");
return false; return false;
} }
@ -906,14 +906,14 @@ bool QFile::open(FILE *fh, OpenMode mode, FileHandleFlags handleFlags)
*/ */
bool QFile::open(int fd, OpenMode mode, FileHandleFlags handleFlags) bool QFile::open(int fd, OpenMode mode, FileHandleFlags handleFlags)
{ {
if (isOpen()) { if (Q_UNLIKELY(isOpen())) {
qWarning("QFile::open: File (%s) already open", qPrintable(fileName())); qWarning("QFile::open: File (%s) already open", qPrintable(fileName()));
return false; return false;
} }
if (mode & Append) if (mode & Append)
mode |= WriteOnly; mode |= WriteOnly;
unsetError(); unsetError();
if ((mode & (ReadOnly | WriteOnly)) == 0) { if (Q_UNLIKELY((mode & (ReadOnly | WriteOnly)) == 0)) {
qWarning("QFile::open: File access not specified"); qWarning("QFile::open: File access not specified");
return false; return false;
} }
@ -1118,7 +1118,7 @@ bool QFile::setPermissions(const QString &fileName, Permissions permissions)
bool QFile::flush() bool QFile::flush()
{ {
Q_D(QFile); Q_D(QFile);
if (!d->fileEngine) { if (Q_UNLIKELY(!d->fileEngine)) {
qWarning("QFile::flush: No file engine. Is IODevice open?"); qWarning("QFile::flush: No file engine. Is IODevice open?");
return false; return false;
} }
@ -1208,7 +1208,7 @@ bool QFile::atEnd() const
bool QFile::seek(qint64 off) bool QFile::seek(qint64 off)
{ {
Q_D(QFile); Q_D(QFile);
if (!isOpen()) { if (Q_UNLIKELY(!isOpen())) {
qWarning("QFile::seek: IODevice is not open"); qWarning("QFile::seek: IODevice is not open");
return false; return false;
} }