From 7286ec19be5c8b96058d0ca315aa47bdc924a0ba Mon Sep 17 00:00:00 2001 From: Ivailo Monev Date: Sat, 1 Aug 2020 20:02:41 +0300 Subject: [PATCH] remove redundant condition check in blendUntransformed() Signed-off-by: Ivailo Monev --- src/gui/painting/qdrawhelper.cpp | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/gui/painting/qdrawhelper.cpp b/src/gui/painting/qdrawhelper.cpp index 73da8bcc3..62bff9c9c 100644 --- a/src/gui/painting/qdrawhelper.cpp +++ b/src/gui/painting/qdrawhelper.cpp @@ -3024,15 +3024,13 @@ static void blend_untransformed_argb(int count, const QSpan *spans, void *userDa static void QT_FASTCALL blendUntransformed(qrgb565 *dest, const qrgb565 *src, quint8 coverage, int length) { - Q_ASSERT(coverage > 0); + Q_ASSERT(coverage > 0 && coverage < 255); - if (coverage < 255) { - const quint8 alpha = qrgb565::alpha(coverage); - const quint8 ialpha = qrgb565::ialpha(coverage); - if (alpha) { - for (int i = 0; i < length; ++i) - interpolate_pixel(dest[i], ialpha, src[i], alpha); - } + const quint8 alpha = qrgb565::alpha(coverage); + const quint8 ialpha = qrgb565::ialpha(coverage); + if (alpha) { + for (int i = 0; i < length; ++i) + interpolate_pixel(dest[i], ialpha, src[i], alpha); } }