Katana_mirror/katie
1
0
Fork 0
mirror of https://bitbucket.org/smil3y/katie.git synced 2025-02-24 02:42:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

remove unused and internal socket engine options

Browse source 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
This commit is contained in:
Ivailo Monev 2022-02-22 00:57:04 +02:00
parent a4b0b6aa69
commit 6d443ca94d
4 changed files with 0 additions and 91 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/network/socket/qabstractsocketengine_p.h
View file

@ -71,8 +71,6 @@ public:
enum SocketOption {
NonBlockingSocketOption,
BroadcastSocketOption,
ReceiveBufferSocketOption,
SendBufferSocketOption,
AddressReusable,
ReceiveOutOfBandData,
LowDelayOption,

71
src/network/socket/qnativesocketengine.cpp
View file

@ -365,17 +365,6 @@ bool QNativeSocketEngine::initialize(QAbstractSocket::SocketType socketType, QAb
qWarning("QNativeSocketEngine::initialize unable to inline out-of-band data");
}
// Before Qt 4.6, we always set the send and receive buffer size to 49152 as
// this was found to be an optimal value. However, modern OS
// all have some kind of auto tuning for this and we therefore don't set
// this explictly anymore.
// If it introduces any performance regressions for Qt 4.6.x (x > 0) then
// it will be put back in.
//
// pre-4.6:
// setReceiveBufferSize(49152);
// setSendBufferSize(49152);
d->socketType = socketType;
d->socketProtocol = protocol;
return true;
@ -949,66 +938,6 @@ bool QNativeSocketEngine::waitForReadOrWrite(bool *readyToRead, bool *readyToWri
return ret > 0;
}
/*!
Returns the size of the operating system's socket receive
buffer. Depending on the operating system, this size may be
different from what has been set earlier with
setReceiveBufferSize().
*/
qint64 QNativeSocketEngine::receiveBufferSize() const
{
Q_CHECK_VALID_SOCKETLAYER(QNativeSocketEngine::receiveBufferSize(), -1);
return option(ReceiveBufferSocketOption);
}
/*!
Sets the size of the operating system receive buffer to \a size.
For clients, this should be set before connectToHost() is called;
otherwise it will have no effect. For servers, it should be called
before listen().
The operating system receive buffer size effectively limits two
things: how much data can be in transit at any one moment, and how
much data can be received in one iteration of the main event loop.
Setting the size of the receive buffer may have an impact on the
socket's performance.
The default value is operating system-dependent.
*/
void QNativeSocketEngine::setReceiveBufferSize(qint64 size)
{
Q_CHECK_VALID_SOCKETLAYER(QNativeSocketEngine::setReceiveBufferSize(), Q_VOID);
setOption(ReceiveBufferSocketOption, size);
}
/*!
Returns the size of the operating system send buffer. Depending on
the operating system, this size may be different from what has
been set earlier with setSendBufferSize().
*/
qint64 QNativeSocketEngine::sendBufferSize() const
{
Q_CHECK_VALID_SOCKETLAYER(QNativeSocketEngine::setSendBufferSize(), -1);
return option(SendBufferSocketOption);
}
/*!
Sets the size of the operating system send buffer to \a size.
The operating system send buffer size effectively limits how much
data can be in transit at any one moment. Setting the size of the
send buffer may have an impact on the socket's performance.
The default value is operating system-dependent.
*/
void QNativeSocketEngine::setSendBufferSize(qint64 size)
{
Q_CHECK_VALID_SOCKETLAYER(QNativeSocketEngine::setSendBufferSize(), Q_VOID);
setOption(SendBufferSocketOption, size);
}
/*!
Sets the option \a option to the value \a value.
*/

6
src/network/socket/qnativesocketengine_p.h
View file

@ -89,12 +89,6 @@ public:
qint64 bytesToWrite() const;
qint64 receiveBufferSize() const;
void setReceiveBufferSize(qint64 bufferSize);
qint64 sendBufferSize() const;
void setSendBufferSize(qint64 bufferSize);
int option(SocketOption option) const;
bool setOption(SocketOption option, int value);

12
src/network/socket/qnativesocketengine_unix.cpp
View file

@ -138,12 +138,6 @@ int QNativeSocketEnginePrivate::option(QNativeSocketEngine::SocketOption opt) co
int level = SOL_SOCKET; // default
switch (opt) {
case QNativeSocketEngine::ReceiveBufferSocketOption:
n = SO_RCVBUF;
break;
case QNativeSocketEngine::SendBufferSocketOption:
n = SO_SNDBUF;
break;
case QNativeSocketEngine::NonBlockingSocketOption:
break;
case QNativeSocketEngine::BroadcastSocketOption:
@ -208,12 +202,6 @@ bool QNativeSocketEnginePrivate::setOption(QNativeSocketEngine::SocketOption opt
int level = SOL_SOCKET; // default
switch (opt) {
case QNativeSocketEngine::ReceiveBufferSocketOption:
n = SO_RCVBUF;
break;
case QNativeSocketEngine::SendBufferSocketOption:
n = SO_SNDBUF;
break;
case QNativeSocketEngine::BroadcastSocketOption:
n = SO_BROADCAST;
break;