Katana_mirror/katie
1
0
Fork 0
mirror of https://bitbucket.org/smil3y/katie.git synced 2025-02-24 19:02:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

avoid relocations in QString::arg() QChar/char overloads

Browse source 
QString's += operator reallocates data and the temporary shared null will
not be used

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
This commit is contained in:
Ivailo Monev 2020-02-24 17:14:26 +00:00
parent 6391c52b86
commit 68c84e8f70
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/core/tools/qstring.cpp
View file

@ -6256,9 +6256,7 @@ QString QString::arg(qulonglong a, int fieldWidth, int base, const QChar &fillCh
*/ */
QString QString::arg(QChar a, int fieldWidth, const QChar &fillChar) const QString QString::arg(QChar a, int fieldWidth, const QChar &fillChar) const
{ {
QString c; return arg(QString(a), fieldWidth, fillChar);
c += a;
return arg(c, fieldWidth, fillChar);
} }
/*! /*!
@ -6268,9 +6266,7 @@ QString QString::arg(QChar a, int fieldWidth, const QChar &fillChar) const
*/ */
QString QString::arg(char a, int fieldWidth, const QChar &fillChar) const QString QString::arg(char a, int fieldWidth, const QChar &fillChar) const
{ {
QString c; return arg(QString(QChar::fromLatin1(a)), fieldWidth, fillChar);
c += QLatin1Char(a);
return arg(c, fieldWidth, fillChar);
} }
/*! /*!