From 4c06eda33c9d54e0ad4120b7bbee882b1900393a Mon Sep 17 00:00:00 2001 From: Ivailo Monev Date: Mon, 6 Apr 2020 01:55:05 +0000 Subject: [PATCH] avoid temporary in QBitmap::operator=() Signed-off-by: Ivailo Monev --- src/gui/image/qbitmap.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gui/image/qbitmap.cpp b/src/gui/image/qbitmap.cpp index 60f924db8..feae23739 100644 --- a/src/gui/image/qbitmap.cpp +++ b/src/gui/image/qbitmap.cpp @@ -190,8 +190,7 @@ QBitmap &QBitmap::operator=(const QPixmap &pixmap) } else if (pixmap.depth() == 1) { // 1-bit pixmap QPixmap::operator=(pixmap); // shallow assignment } else { // n-bit depth pixmap - QImage image = pixmap.toImage(); // convert pixmap to image - *this = fromImage(image); // will dither image + *this = fromImage(pixmap.toImage()); // convert pixmap to image and dither } return *this; }