Replace all QBasicAtomicInt ref variables by QSharedData inheritance

upstream commit 9a85b921ac457c68cee0c89b8ad11433b1e92d07

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
This commit is contained in:
Ivailo Monev 2015-12-13 14:30:52 +02:00
parent 0880447553
commit 49c09b6593
10 changed files with 21 additions and 38 deletions

View file

@ -30,6 +30,7 @@
#include "../bridge/qscriptqobject_p.h" #include "../bridge/qscriptqobject_p.h"
#include <QtCore/qdatastream.h> #include <QtCore/qdatastream.h>
#include <QtCore/qmetaobject.h> #include <QtCore/qmetaobject.h>
#include <QtCore/qshareddata.h>
#include "CodeBlock.h" #include "CodeBlock.h"
#include "JSFunction.h" #include "JSFunction.h"
#if ENABLE(JIT) #if ENABLE(JIT)
@ -81,7 +82,7 @@ QT_BEGIN_NAMESPACE
\value NativeFunction The function is a built-in Qt Script function, or it was defined through a call to QScriptEngine::newFunction(). \value NativeFunction The function is a built-in Qt Script function, or it was defined through a call to QScriptEngine::newFunction().
*/ */
class QScriptContextInfoPrivate class QScriptContextInfoPrivate : public QSharedData
{ {
Q_DECLARE_PUBLIC(QScriptContextInfo) Q_DECLARE_PUBLIC(QScriptContextInfo)
public: public:
@ -103,8 +104,6 @@ public:
QStringList parameterNames; QStringList parameterNames;
QBasicAtomicInt ref;
QScriptContextInfo *q_ptr; QScriptContextInfo *q_ptr;
}; };

View file

@ -38,6 +38,7 @@
#include "qdebug.h" #include "qdebug.h"
#include <QtCore/qstringlist.h> #include <QtCore/qstringlist.h>
#include <QtCore/qshareddata.h>
#include <QtCore/qmetaobject.h> #include <QtCore/qmetaobject.h>
#include <math.h> #include <math.h>
@ -326,17 +327,16 @@ QT_BEGIN_NAMESPACE
\value SkipMethodsInEnumeration Don't include methods (signals and slots) when enumerating the object's properties. \value SkipMethodsInEnumeration Don't include methods (signals and slots) when enumerating the object's properties.
*/ */
class QScriptSyntaxCheckResultPrivate class QScriptSyntaxCheckResultPrivate : public QSharedData
{ {
public: public:
QScriptSyntaxCheckResultPrivate() { ref = 0; } QScriptSyntaxCheckResultPrivate() { }
~QScriptSyntaxCheckResultPrivate() {} ~QScriptSyntaxCheckResultPrivate() {}
QScriptSyntaxCheckResult::State state; QScriptSyntaxCheckResult::State state;
int errorColumnNumber; int errorColumnNumber;
int errorLineNumber; int errorLineNumber;
QString errorMessage; QString errorMessage;
QBasicAtomicInt ref;
}; };
class QScriptTypeInfo class QScriptTypeInfo

View file

@ -36,6 +36,7 @@
// //
#include <QtCore/qobjectdefs.h> #include <QtCore/qobjectdefs.h>
#include <QtCore/qshareddata.h>
#include "RefPtr.h" #include "RefPtr.h"
@ -49,7 +50,7 @@ QT_BEGIN_NAMESPACE
class QScriptEnginePrivate; class QScriptEnginePrivate;
class QScriptProgramPrivate class QScriptProgramPrivate : public QSharedData
{ {
public: public:
QScriptProgramPrivate(const QString &sourceCode, QScriptProgramPrivate(const QString &sourceCode,
@ -63,8 +64,6 @@ public:
QScriptEnginePrivate *engine); QScriptEnginePrivate *engine);
void detachFromEngine(); void detachFromEngine();
QBasicAtomicInt ref;
QString sourceCode; QString sourceCode;
QString fileName; QString fileName;
int firstLineNumber; int firstLineNumber;

View file

@ -36,13 +36,14 @@
// //
#include <QtCore/qobjectdefs.h> #include <QtCore/qobjectdefs.h>
#include <QtCore/qshareddata.h>
#include "Identifier.h" #include "Identifier.h"
QT_BEGIN_NAMESPACE QT_BEGIN_NAMESPACE
class QScriptEnginePrivate; class QScriptEnginePrivate;
class QScriptStringPrivate class QScriptStringPrivate : public QSharedData
{ {
public: public:
enum AllocationType { enum AllocationType {
@ -61,7 +62,6 @@ public:
static inline bool isValid(const QScriptString &q); static inline bool isValid(const QScriptString &q);
QBasicAtomicInt ref;
QScriptEnginePrivate *engine; QScriptEnginePrivate *engine;
JSC::Identifier identifier; JSC::Identifier identifier;
AllocationType type; AllocationType type;
@ -75,7 +75,6 @@ inline QScriptStringPrivate::QScriptStringPrivate(QScriptEnginePrivate *e, const
AllocationType tp) AllocationType tp)
: engine(e), identifier(id), type(tp), prev(0), next(0) : engine(e), identifier(id), type(tp), prev(0), next(0)
{ {
ref = 0;
} }
inline QScriptStringPrivate::~QScriptStringPrivate() inline QScriptStringPrivate::~QScriptStringPrivate()

View file

@ -36,6 +36,7 @@
// //
#include <QtCore/qobjectdefs.h> #include <QtCore/qobjectdefs.h>
#include <QtCore/qshareddata.h>
#include "wtf/Platform.h" #include "wtf/Platform.h"
#include "JSValue.h" #include "JSValue.h"
@ -46,7 +47,7 @@ class QString;
class QScriptEnginePrivate; class QScriptEnginePrivate;
class QScriptValue; class QScriptValue;
class QScriptValuePrivate class QScriptValuePrivate : public QSharedData
{ {
Q_DISABLE_COPY(QScriptValuePrivate) Q_DISABLE_COPY(QScriptValuePrivate)
public: public:
@ -118,14 +119,11 @@ public:
// linked list of engine's script values // linked list of engine's script values
QScriptValuePrivate *prev; QScriptValuePrivate *prev;
QScriptValuePrivate *next; QScriptValuePrivate *next;
QBasicAtomicInt ref;
}; };
inline QScriptValuePrivate::QScriptValuePrivate(QScriptEnginePrivate *e) inline QScriptValuePrivate::QScriptValuePrivate(QScriptEnginePrivate *e)
: engine(e), prev(0), next(0) : engine(e), prev(0), next(0)
{ {
ref = 0;
} }
inline bool QScriptValuePrivate::isJSC() const inline bool QScriptValuePrivate::isJSC() const

View file

@ -42,6 +42,7 @@
#include "qscriptdebuggerconsolecommandgroupdata_p.h" #include "qscriptdebuggerconsolecommandgroupdata_p.h"
#include <QtCore/qstring.h> #include <QtCore/qstring.h>
#include <QtCore/qshareddata.h>
QT_BEGIN_NAMESPACE QT_BEGIN_NAMESPACE
@ -53,7 +54,7 @@ QT_BEGIN_NAMESPACE
\brief The QScriptDebuggerConsoleCommandGroupData class holds data associated with a console command group. \brief The QScriptDebuggerConsoleCommandGroupData class holds data associated with a console command group.
*/ */
class QScriptDebuggerConsoleCommandGroupDataPrivate class QScriptDebuggerConsoleCommandGroupDataPrivate : public QSharedData
{ {
public: public:
QScriptDebuggerConsoleCommandGroupDataPrivate(); QScriptDebuggerConsoleCommandGroupDataPrivate();
@ -61,13 +62,10 @@ public:
QString shortDescription; QString shortDescription;
QString longDescription; QString longDescription;
QBasicAtomicInt ref;
}; };
QScriptDebuggerConsoleCommandGroupDataPrivate::QScriptDebuggerConsoleCommandGroupDataPrivate() QScriptDebuggerConsoleCommandGroupDataPrivate::QScriptDebuggerConsoleCommandGroupDataPrivate()
{ {
ref = 0;
} }
QScriptDebuggerConsoleCommandGroupDataPrivate::~QScriptDebuggerConsoleCommandGroupDataPrivate() QScriptDebuggerConsoleCommandGroupDataPrivate::~QScriptDebuggerConsoleCommandGroupDataPrivate()

View file

@ -45,6 +45,7 @@
#include <QtScript/qscriptengine.h> #include <QtScript/qscriptengine.h>
#include <QtCore/qdatastream.h> #include <QtCore/qdatastream.h>
#include <QtCore/qdebug.h> #include <QtCore/qdebug.h>
#include <QtCore/qshareddata.h>
QT_BEGIN_NAMESPACE QT_BEGIN_NAMESPACE
@ -56,7 +57,7 @@ QT_BEGIN_NAMESPACE
\brief The QScriptDebuggerValue class represents a script value. \brief The QScriptDebuggerValue class represents a script value.
*/ */
class QScriptDebuggerValuePrivate class QScriptDebuggerValuePrivate : public QSharedData
{ {
public: public:
QScriptDebuggerValuePrivate(); QScriptDebuggerValuePrivate();
@ -69,14 +70,11 @@ public:
double numberValue; double numberValue;
qint64 objectId; qint64 objectId;
}; };
QBasicAtomicInt ref;
}; };
QScriptDebuggerValuePrivate::QScriptDebuggerValuePrivate() QScriptDebuggerValuePrivate::QScriptDebuggerValuePrivate()
: type(QScriptDebuggerValue::NoValue) : type(QScriptDebuggerValue::NoValue)
{ {
ref = 0;
} }
QScriptDebuggerValuePrivate::~QScriptDebuggerValuePrivate() QScriptDebuggerValuePrivate::~QScriptDebuggerValuePrivate()

View file

@ -43,7 +43,7 @@
#include "qscriptdebuggervalue_p.h" #include "qscriptdebuggervalue_p.h"
#include "qscriptdebuggerobjectsnapshotdelta_p.h" #include "qscriptdebuggerobjectsnapshotdelta_p.h"
#include <QtCore/qatomic.h> #include <QtCore/qshareddata.h>
#include <QtCore/qdatastream.h> #include <QtCore/qdatastream.h>
#include <QtCore/qstring.h> #include <QtCore/qstring.h>
@ -54,7 +54,7 @@ QT_BEGIN_NAMESPACE
\class QScriptDebuggerValueProperty \class QScriptDebuggerValueProperty
*/ */
class QScriptDebuggerValuePropertyPrivate class QScriptDebuggerValuePropertyPrivate : public QSharedData
{ {
public: public:
QScriptDebuggerValuePropertyPrivate(); QScriptDebuggerValuePropertyPrivate();
@ -64,13 +64,10 @@ public:
QScriptDebuggerValue value; QScriptDebuggerValue value;
QString valueAsString; QString valueAsString;
QScriptValue::PropertyFlags flags; QScriptValue::PropertyFlags flags;
QBasicAtomicInt ref;
}; };
QScriptDebuggerValuePropertyPrivate::QScriptDebuggerValuePropertyPrivate() QScriptDebuggerValuePropertyPrivate::QScriptDebuggerValuePropertyPrivate()
{ {
ref = 0;
} }
QScriptDebuggerValuePropertyPrivate::~QScriptDebuggerValuePropertyPrivate() QScriptDebuggerValuePropertyPrivate::~QScriptDebuggerValuePropertyPrivate()

View file

@ -44,6 +44,7 @@
#include <QtCore/qdatastream.h> #include <QtCore/qdatastream.h>
#include <QtCore/qstring.h> #include <QtCore/qstring.h>
#include <QtCore/qstringlist.h> #include <QtCore/qstringlist.h>
#include <QtCore/qshareddata.h>
QT_BEGIN_NAMESPACE QT_BEGIN_NAMESPACE
@ -55,7 +56,7 @@ QT_BEGIN_NAMESPACE
\brief The QScriptScriptData class holds data associated with a script. \brief The QScriptScriptData class holds data associated with a script.
*/ */
class QScriptScriptDataPrivate class QScriptScriptDataPrivate : public QSharedData
{ {
public: public:
QScriptScriptDataPrivate(); QScriptScriptDataPrivate();
@ -65,13 +66,10 @@ public:
QString fileName; QString fileName;
int baseLineNumber; int baseLineNumber;
QDateTime timeStamp; QDateTime timeStamp;
QBasicAtomicInt ref;
}; };
QScriptScriptDataPrivate::QScriptScriptDataPrivate() QScriptScriptDataPrivate::QScriptScriptDataPrivate()
{ {
ref = 0;
} }
QScriptScriptDataPrivate::~QScriptScriptDataPrivate() QScriptScriptDataPrivate::~QScriptScriptDataPrivate()

View file

@ -41,12 +41,12 @@
#include "qscriptvalueproperty_p.h" #include "qscriptvalueproperty_p.h"
#include <QtCore/qatomic.h> #include <QtCore/qshareddata.h>
#include <QtCore/qstring.h> #include <QtCore/qstring.h>
QT_BEGIN_NAMESPACE QT_BEGIN_NAMESPACE
class QScriptValuePropertyPrivate class QScriptValuePropertyPrivate : public QSharedData
{ {
public: public:
QScriptValuePropertyPrivate(); QScriptValuePropertyPrivate();
@ -55,13 +55,10 @@ public:
QString name; QString name;
QScriptValue value; QScriptValue value;
QScriptValue::PropertyFlags flags; QScriptValue::PropertyFlags flags;
QBasicAtomicInt ref;
}; };
QScriptValuePropertyPrivate::QScriptValuePropertyPrivate() QScriptValuePropertyPrivate::QScriptValuePropertyPrivate()
{ {
ref = 0;
} }
QScriptValuePropertyPrivate::~QScriptValuePropertyPrivate() QScriptValuePropertyPrivate::~QScriptValuePropertyPrivate()