mirror of
https://github.com/u-boot/u-boot.git
synced 2025-04-22 04:44:46 +00:00

During address translation #address/size-cells props are expected to apply to child nodes. However, devfdt_get_addr_index() incorrectly use the parent offset of the udevice parent instead of getting the offset of the node parent. This will work in most cases when there is only one udevice tied to a node. On e.g. an Orange Pi R1 Plus TLS board the dwc3-generic (parent) and dwc3-generic-host (child) udevice is tied to the same node. In that case both the offset and parent values end up being the same. As a result, the #address/size-cells props intended for child nodes incorrectly gets applied to the node itself resulting in wrong addr being returned, 0x0 instead of 0xff600000. The following can be seen on console: dwc3-generic-host usb@ff600000: this is not a DesignWare USB3 DRD Core dwc3-generic-host usb@ff600000: failed to initialize core Fix this by using the offset of the parent node and not the offset to the node the parent udevice is tied to. Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
266 lines
6 KiB
C
266 lines
6 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Device addresses
|
|
*
|
|
* Copyright (c) 2017 Google, Inc
|
|
*
|
|
* (C) Copyright 2012
|
|
* Pavel Herrmann <morpheus.ibis@gmail.com>
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <dm.h>
|
|
#include <fdt_support.h>
|
|
#include <log.h>
|
|
#include <mapmem.h>
|
|
#include <asm/global_data.h>
|
|
#include <asm/io.h>
|
|
#include <dm/device-internal.h>
|
|
|
|
DECLARE_GLOBAL_DATA_PTR;
|
|
|
|
fdt_addr_t devfdt_get_addr_index(const struct udevice *dev, int index)
|
|
{
|
|
#if CONFIG_IS_ENABLED(OF_REAL)
|
|
int offset = dev_of_offset(dev);
|
|
int parent = fdt_parent_offset(gd->fdt_blob, offset);
|
|
fdt_addr_t addr;
|
|
|
|
if (CONFIG_IS_ENABLED(OF_TRANSLATE)) {
|
|
const fdt32_t *reg;
|
|
int len = 0;
|
|
int na, ns;
|
|
|
|
na = fdt_address_cells(gd->fdt_blob, parent);
|
|
if (na < 1) {
|
|
debug("bad #address-cells\n");
|
|
return FDT_ADDR_T_NONE;
|
|
}
|
|
|
|
ns = fdt_size_cells(gd->fdt_blob, parent);
|
|
if (ns < 0) {
|
|
debug("bad #size-cells\n");
|
|
return FDT_ADDR_T_NONE;
|
|
}
|
|
|
|
reg = fdt_getprop(gd->fdt_blob, offset, "reg", &len);
|
|
if (!reg || (len <= (index * sizeof(fdt32_t) * (na + ns)))) {
|
|
debug("Req index out of range\n");
|
|
return FDT_ADDR_T_NONE;
|
|
}
|
|
|
|
reg += index * (na + ns);
|
|
|
|
if (ns) {
|
|
/*
|
|
* Use the full-fledged translate function for complex
|
|
* bus setups.
|
|
*/
|
|
addr = fdt_translate_address((void *)gd->fdt_blob,
|
|
offset, reg);
|
|
} else {
|
|
/* Non translatable if #size-cells == 0 */
|
|
addr = fdt_read_number(reg, na);
|
|
}
|
|
} else {
|
|
/*
|
|
* Use the "simple" translate function for less complex
|
|
* bus setups.
|
|
*/
|
|
addr = fdtdec_get_addr_size_auto_parent(gd->fdt_blob, parent,
|
|
offset, "reg", index,
|
|
NULL, false);
|
|
if (CONFIG_IS_ENABLED(SIMPLE_BUS) && addr != FDT_ADDR_T_NONE) {
|
|
if (device_get_uclass_id(dev->parent) ==
|
|
UCLASS_SIMPLE_BUS)
|
|
addr = simple_bus_translate(dev->parent, addr);
|
|
}
|
|
}
|
|
|
|
#if defined(CONFIG_TRANSLATION_OFFSET)
|
|
/*
|
|
* Some platforms need a special address translation. Those
|
|
* platforms (e.g. mvebu in SPL) can configure a translation
|
|
* offset by setting this value in the GD and enaling this
|
|
* feature via CONFIG_TRANSLATION_OFFSET. This value will
|
|
* get added to all addresses returned by devfdt_get_addr().
|
|
*/
|
|
addr += gd->translation_offset;
|
|
#endif
|
|
|
|
return addr;
|
|
#else
|
|
return FDT_ADDR_T_NONE;
|
|
#endif
|
|
}
|
|
|
|
void *devfdt_get_addr_index_ptr(const struct udevice *dev, int index)
|
|
{
|
|
fdt_addr_t addr = devfdt_get_addr_index(dev, index);
|
|
|
|
if (addr == FDT_ADDR_T_NONE)
|
|
return NULL;
|
|
|
|
return map_sysmem(addr, 0);
|
|
}
|
|
|
|
fdt_addr_t devfdt_get_addr_size_index(const struct udevice *dev, int index,
|
|
fdt_size_t *size)
|
|
{
|
|
#if CONFIG_IS_ENABLED(OF_CONTROL)
|
|
/*
|
|
* Only get the size in this first call. We'll get the addr in the
|
|
* next call to the exisiting dev_get_xxx function which handles
|
|
* all config options.
|
|
*/
|
|
fdtdec_get_addr_size_auto_noparent(gd->fdt_blob, dev_of_offset(dev),
|
|
"reg", index, size, false);
|
|
|
|
/*
|
|
* Get the base address via the existing function which handles
|
|
* all Kconfig cases
|
|
*/
|
|
return devfdt_get_addr_index(dev, index);
|
|
#else
|
|
return FDT_ADDR_T_NONE;
|
|
#endif
|
|
}
|
|
|
|
void *devfdt_get_addr_size_index_ptr(const struct udevice *dev, int index,
|
|
fdt_size_t *size)
|
|
{
|
|
fdt_addr_t addr = devfdt_get_addr_size_index(dev, index, size);
|
|
|
|
if (addr == FDT_ADDR_T_NONE)
|
|
return NULL;
|
|
|
|
return map_sysmem(addr, 0);
|
|
}
|
|
|
|
fdt_addr_t devfdt_get_addr_name(const struct udevice *dev, const char *name)
|
|
{
|
|
#if CONFIG_IS_ENABLED(OF_CONTROL)
|
|
int index;
|
|
|
|
index = fdt_stringlist_search(gd->fdt_blob, dev_of_offset(dev),
|
|
"reg-names", name);
|
|
if (index < 0)
|
|
return FDT_ADDR_T_NONE;
|
|
|
|
return devfdt_get_addr_index(dev, index);
|
|
#else
|
|
return FDT_ADDR_T_NONE;
|
|
#endif
|
|
}
|
|
|
|
void *devfdt_get_addr_name_ptr(const struct udevice *dev, const char *name)
|
|
{
|
|
fdt_addr_t addr = devfdt_get_addr_name(dev, name);
|
|
|
|
if (addr == FDT_ADDR_T_NONE)
|
|
return NULL;
|
|
|
|
return map_sysmem(addr, 0);
|
|
}
|
|
|
|
fdt_addr_t devfdt_get_addr_size_name(const struct udevice *dev,
|
|
const char *name, fdt_size_t *size)
|
|
{
|
|
#if CONFIG_IS_ENABLED(OF_CONTROL)
|
|
int index;
|
|
|
|
index = fdt_stringlist_search(gd->fdt_blob, dev_of_offset(dev),
|
|
"reg-names", name);
|
|
if (index < 0)
|
|
return FDT_ADDR_T_NONE;
|
|
|
|
return devfdt_get_addr_size_index(dev, index, size);
|
|
#else
|
|
return FDT_ADDR_T_NONE;
|
|
#endif
|
|
}
|
|
|
|
void *devfdt_get_addr_size_name_ptr(const struct udevice *dev,
|
|
const char *name, fdt_size_t *size)
|
|
{
|
|
fdt_addr_t addr = devfdt_get_addr_size_name(dev, name, size);
|
|
|
|
if (addr == FDT_ADDR_T_NONE)
|
|
return NULL;
|
|
|
|
return map_sysmem(addr, 0);
|
|
}
|
|
|
|
fdt_addr_t devfdt_get_addr(const struct udevice *dev)
|
|
{
|
|
return devfdt_get_addr_index(dev, 0);
|
|
}
|
|
|
|
void *devfdt_get_addr_ptr(const struct udevice *dev)
|
|
{
|
|
return devfdt_get_addr_index_ptr(dev, 0);
|
|
}
|
|
|
|
void *devfdt_remap_addr_index(const struct udevice *dev, int index)
|
|
{
|
|
fdt_addr_t addr = devfdt_get_addr_index(dev, index);
|
|
|
|
if (addr == FDT_ADDR_T_NONE)
|
|
return NULL;
|
|
|
|
return map_physmem(addr, 0, MAP_NOCACHE);
|
|
}
|
|
|
|
void *devfdt_remap_addr_name(const struct udevice *dev, const char *name)
|
|
{
|
|
fdt_addr_t addr = devfdt_get_addr_name(dev, name);
|
|
|
|
if (addr == FDT_ADDR_T_NONE)
|
|
return NULL;
|
|
|
|
return map_physmem(addr, 0, MAP_NOCACHE);
|
|
}
|
|
|
|
void *devfdt_remap_addr(const struct udevice *dev)
|
|
{
|
|
return devfdt_remap_addr_index(dev, 0);
|
|
}
|
|
|
|
void *devfdt_map_physmem(const struct udevice *dev, unsigned long size)
|
|
{
|
|
fdt_addr_t addr = devfdt_get_addr(dev);
|
|
|
|
if (addr == FDT_ADDR_T_NONE)
|
|
return NULL;
|
|
|
|
return map_physmem(addr, size, MAP_NOCACHE);
|
|
}
|
|
|
|
fdt_addr_t devfdt_get_addr_pci(const struct udevice *dev, fdt_size_t *sizep)
|
|
{
|
|
ulong addr;
|
|
|
|
addr = devfdt_get_addr(dev);
|
|
if (CONFIG_IS_ENABLED(PCI) && addr == FDT_ADDR_T_NONE) {
|
|
struct fdt_pci_addr pci_addr;
|
|
u32 bar;
|
|
int ret;
|
|
|
|
ret = ofnode_read_pci_addr(dev_ofnode(dev), FDT_PCI_SPACE_MEM32,
|
|
"reg", &pci_addr, sizep);
|
|
if (ret) {
|
|
/* try if there is any i/o-mapped register */
|
|
ret = ofnode_read_pci_addr(dev_ofnode(dev),
|
|
FDT_PCI_SPACE_IO, "reg",
|
|
&pci_addr, sizep);
|
|
if (ret)
|
|
return FDT_ADDR_T_NONE;
|
|
}
|
|
ret = fdtdec_get_pci_bar32(dev, &pci_addr, &bar);
|
|
if (ret)
|
|
return FDT_ADDR_T_NONE;
|
|
addr = bar;
|
|
}
|
|
|
|
return addr;
|
|
}
|