mirror of
https://github.com/u-boot/u-boot.git
synced 2025-04-16 09:54:35 +00:00
d54f87f09a
While meson_sm_read_efuse() doesn't overflow, the string is not zero terminated and env_set*() will buffer overflow and add random characters to environment. Acked-by: Viacheslav Bocharov <adeep@lexina.in> Link: https://lore.kernel.org/r/20240320-u-boot-fix-p200-serial-v2-1-972be646a301@linaro.org Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
48 lines
1 KiB
C
48 lines
1 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Copyright (C) 2016 BayLibre, SAS
|
|
* Author: Neil Armstrong <narmstrong@baylibre.com>
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <dm.h>
|
|
#include <env.h>
|
|
#include <init.h>
|
|
#include <net.h>
|
|
#include <asm/io.h>
|
|
#include <asm/arch/gx.h>
|
|
#include <asm/arch/mem.h>
|
|
#include <asm/arch/sm.h>
|
|
#include <asm/arch/eth.h>
|
|
|
|
#define EFUSE_SN_OFFSET 20
|
|
#define EFUSE_SN_SIZE 16
|
|
#define EFUSE_MAC_OFFSET 52
|
|
#define EFUSE_MAC_SIZE 6
|
|
|
|
int misc_init_r(void)
|
|
{
|
|
u8 mac_addr[EFUSE_MAC_SIZE + 1];
|
|
char serial[EFUSE_SN_SIZE + 1];
|
|
ssize_t len;
|
|
|
|
if (!eth_env_get_enetaddr("ethaddr", mac_addr)) {
|
|
len = meson_sm_read_efuse(EFUSE_MAC_OFFSET,
|
|
mac_addr, EFUSE_MAC_SIZE);
|
|
mac_addr[len] = '\0';
|
|
if (len == EFUSE_MAC_SIZE && is_valid_ethaddr(mac_addr))
|
|
eth_env_set_enetaddr("ethaddr", mac_addr);
|
|
else
|
|
meson_generate_serial_ethaddr();
|
|
}
|
|
|
|
if (!env_get("serial#")) {
|
|
len = meson_sm_read_efuse(EFUSE_SN_OFFSET, serial,
|
|
EFUSE_SN_SIZE);
|
|
serial[len] = '\0';
|
|
if (len == EFUSE_SN_SIZE)
|
|
env_set("serial#", serial);
|
|
}
|
|
|
|
return 0;
|
|
}
|