mirror of
https://github.com/u-boot/u-boot.git
synced 2025-04-16 01:44:34 +00:00
7e0370f37d
When enabling net console and console multiplexing, a boot crash was observed using mtk_eth driver with stdin/stdout set to "serial,nc" in persistent environment: > CPU: MediaTek MT7981 > Model: OpenWrt One > DRAM: 1 GiB > Core: 35 devices, 15 uclasses, devicetree: separate > spi-nand: spi_nand spi_nand@0: Winbond SPI NAND was found. > spi-nand: spi_nand spi_nand@0: 128 MiB, block size: 128 KiB, page size: 2048, OOB size: 64 > Loading Environment from UBI... SF: Detected w25q128 with page size 256 Bytes, erase size 4 KiB, total 16 MiB > mtd: partition "ubi" extends beyond the end of device "spi-nand0" -- size truncated to 0x7f00000 > Read 126976 bytes from volume ubootenv to 000000007f7bf0c0 > Read 126976 bytes from volume ubootenv2 to 000000007f7de100 > OK > "Synchronous Abort" handler, esr 0x96000004, far 0xeafffffeea000018 > elr: 0000000041e63cd4 lr : 0000000041e1b844 (reloc) > elr: 000000007ff9ecd4 lr : 000000007ff56844 > x0 : eafffffeea000018 x1 : 000000007fb552e0 > x2 : 00000000000000fe x3 : 0000000000000000 The cause is that "serial,nc" forced the console subsystem to initialize the ethernet driver before ethernet subsystem initialization (console_init_r() is called before initr_net()). During the mtk_eth driver initialization, mdio_register() will be called, and miiphy_get_dev_by_name() will then be called. The miiphy_get_dev_by_name() will check the list "mii_devs" to see if the passed device name exists. However the mii_devs is defined without initialization: > static struct list_head mii_devs; and the actual initialization is done in the following chain: initr_net -> eth_initialize -> eth_common_init -> miiphy_init Since initr_net() hasn't be called, iterating over the mii_devs will access to physical address 0 (mii_devs.next == NULL) and will cause the crash. The fix is to define mii_devs using: > static LIST_HEAD(mii_devs); As the "current_mii" is defined as a static variable, it will always be NULL in board_r stage and initializing it will NULL is unnecessary. So the entire miiphy_init() can be remove. Signed-off-by: Weijie Gao <hackpascal@gmail.com> |
||
|---|---|---|
| .. | ||
| lwip | ||
| arp.c | ||
| arp.h | ||
| bootp.c | ||
| bootp.h | ||
| cdp.c | ||
| cdp.h | ||
| dhcpv6.c | ||
| dhcpv6.h | ||
| dns.c | ||
| dns.h | ||
| dsa-uclass.c | ||
| eth-uclass.c | ||
| eth_bootdev.c | ||
| eth_common.c | ||
| eth_internal.h | ||
| fastboot_tcp.c | ||
| fastboot_udp.c | ||
| Kconfig | ||
| link_local.c | ||
| link_local.h | ||
| Makefile | ||
| mdio-mux-uclass.c | ||
| mdio-uclass.c | ||
| ndisc.c | ||
| net-common.c | ||
| net.c | ||
| net6.c | ||
| net_rand.h | ||
| nfs.c | ||
| nfs.h | ||
| pcap.c | ||
| ping.c | ||
| ping.h | ||
| ping6.c | ||
| rarp.c | ||
| rarp.h | ||
| sntp.c | ||
| tcp.c | ||
| tftp.c | ||
| udp.c | ||
| wget.c | ||
| wol.c | ||
| wol.h | ||