mirror of
https://github.com/u-boot/u-boot.git
synced 2025-04-20 20:04:46 +00:00
35b65dd8ef
Historically, the reset_cpu() function had an `addr` parameter which was
meant to pass in an address of the reset vector location, where the CPU
should reset to. This feature is no longer used anywhere in U-Boot as
all reset_cpu() implementations now ignore the passed value. Generic
code has been added which always calls reset_cpu() with `0` which means
this feature can no longer be used easily anyway.
Over time, many implementations seem to have "misunderstood" the
existence of this parameter as a way to customize/parameterize the reset
(e.g. COLD vs WARM resets). As this is not properly supported, the
code will almost always not do what it is intended to (because all
call-sites just call reset_cpu() with 0).
To avoid confusion and to clean up the codebase from unused left-overs
of the past, remove the `addr` parameter entirely. Code which intends
to support different kinds of resets should be rewritten as a sysreset
driver instead.
This transformation was done with the following coccinelle patch:
@@
expression argvalue;
@@
- reset_cpu(argvalue)
+ reset_cpu()
@@
identifier argname;
type argtype;
@@
- reset_cpu(argtype argname)
+ reset_cpu(void)
{ ... }
Signed-off-by: Harald Seiler <hws@denx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
169 lines
3 KiB
C
169 lines
3 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Copyright (C) 2015 Google, Inc
|
|
* Written by Simon Glass <sjg@chromium.org>
|
|
*/
|
|
|
|
#define LOG_CATEGORY UCLASS_SYSRESET
|
|
|
|
#include <common.h>
|
|
#include <command.h>
|
|
#include <cpu_func.h>
|
|
#include <dm.h>
|
|
#include <errno.h>
|
|
#include <hang.h>
|
|
#include <log.h>
|
|
#include <regmap.h>
|
|
#include <spl.h>
|
|
#include <sysreset.h>
|
|
#include <dm/device-internal.h>
|
|
#include <dm/lists.h>
|
|
#include <dm/root.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/err.h>
|
|
#include <asm/global_data.h>
|
|
|
|
int sysreset_request(struct udevice *dev, enum sysreset_t type)
|
|
{
|
|
struct sysreset_ops *ops = sysreset_get_ops(dev);
|
|
|
|
if (!ops->request)
|
|
return -ENOSYS;
|
|
|
|
return ops->request(dev, type);
|
|
}
|
|
|
|
int sysreset_get_status(struct udevice *dev, char *buf, int size)
|
|
{
|
|
struct sysreset_ops *ops = sysreset_get_ops(dev);
|
|
|
|
if (!ops->get_status)
|
|
return -ENOSYS;
|
|
|
|
return ops->get_status(dev, buf, size);
|
|
}
|
|
|
|
int sysreset_get_last(struct udevice *dev)
|
|
{
|
|
struct sysreset_ops *ops = sysreset_get_ops(dev);
|
|
|
|
if (!ops->get_last)
|
|
return -ENOSYS;
|
|
|
|
return ops->get_last(dev);
|
|
}
|
|
|
|
int sysreset_walk(enum sysreset_t type)
|
|
{
|
|
struct udevice *dev;
|
|
int ret = -ENOSYS;
|
|
|
|
while (ret != -EINPROGRESS && type < SYSRESET_COUNT) {
|
|
for (uclass_first_device(UCLASS_SYSRESET, &dev);
|
|
dev;
|
|
uclass_next_device(&dev)) {
|
|
ret = sysreset_request(dev, type);
|
|
if (ret == -EINPROGRESS)
|
|
break;
|
|
}
|
|
type++;
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
int sysreset_get_last_walk(void)
|
|
{
|
|
struct udevice *dev;
|
|
int value = -ENOENT;
|
|
|
|
for (uclass_first_device(UCLASS_SYSRESET, &dev);
|
|
dev;
|
|
uclass_next_device(&dev)) {
|
|
int ret;
|
|
|
|
ret = sysreset_get_last(dev);
|
|
if (ret >= 0) {
|
|
value = ret;
|
|
break;
|
|
}
|
|
}
|
|
|
|
return value;
|
|
}
|
|
|
|
void sysreset_walk_halt(enum sysreset_t type)
|
|
{
|
|
int ret;
|
|
|
|
ret = sysreset_walk(type);
|
|
|
|
/* Wait for the reset to take effect */
|
|
if (ret == -EINPROGRESS)
|
|
mdelay(100);
|
|
|
|
/* Still no reset? Give up */
|
|
if (spl_phase() <= PHASE_SPL)
|
|
log_err("no sysreset\n");
|
|
else
|
|
log_err("System reset not supported on this platform\n");
|
|
hang();
|
|
}
|
|
|
|
/**
|
|
* reset_cpu() - calls sysreset_walk(SYSRESET_WARM)
|
|
*/
|
|
void reset_cpu(void)
|
|
{
|
|
sysreset_walk_halt(SYSRESET_WARM);
|
|
}
|
|
|
|
|
|
int do_reset(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
|
|
{
|
|
printf("resetting ...\n");
|
|
mdelay(100);
|
|
|
|
sysreset_walk_halt(SYSRESET_COLD);
|
|
|
|
return 0;
|
|
}
|
|
|
|
#if IS_ENABLED(CONFIG_SYSRESET_CMD_POWEROFF)
|
|
int do_poweroff(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
|
|
{
|
|
int ret;
|
|
|
|
puts("poweroff ...\n");
|
|
mdelay(100);
|
|
|
|
ret = sysreset_walk(SYSRESET_POWER_OFF);
|
|
|
|
if (ret == -EINPROGRESS)
|
|
mdelay(1000);
|
|
|
|
/*NOTREACHED when power off*/
|
|
return CMD_RET_FAILURE;
|
|
}
|
|
#endif
|
|
|
|
static int sysreset_post_bind(struct udevice *dev)
|
|
{
|
|
#if defined(CONFIG_NEEDS_MANUAL_RELOC)
|
|
struct sysreset_ops *ops = sysreset_get_ops(dev);
|
|
static int reloc_done;
|
|
|
|
if (!reloc_done) {
|
|
if (ops->request)
|
|
ops->request += gd->reloc_off;
|
|
reloc_done++;
|
|
}
|
|
#endif
|
|
return 0;
|
|
}
|
|
|
|
UCLASS_DRIVER(sysreset) = {
|
|
.id = UCLASS_SYSRESET,
|
|
.name = "sysreset",
|
|
.post_bind = sysreset_post_bind,
|
|
};
|