mirror of
https://github.com/u-boot/u-boot.git
synced 2025-04-11 07:24:46 +00:00
7e0370f37d
When enabling net console and console multiplexing, a boot crash was observed using mtk_eth driver with stdin/stdout set to "serial,nc" in persistent environment: > CPU: MediaTek MT7981 > Model: OpenWrt One > DRAM: 1 GiB > Core: 35 devices, 15 uclasses, devicetree: separate > spi-nand: spi_nand spi_nand@0: Winbond SPI NAND was found. > spi-nand: spi_nand spi_nand@0: 128 MiB, block size: 128 KiB, page size: 2048, OOB size: 64 > Loading Environment from UBI... SF: Detected w25q128 with page size 256 Bytes, erase size 4 KiB, total 16 MiB > mtd: partition "ubi" extends beyond the end of device "spi-nand0" -- size truncated to 0x7f00000 > Read 126976 bytes from volume ubootenv to 000000007f7bf0c0 > Read 126976 bytes from volume ubootenv2 to 000000007f7de100 > OK > "Synchronous Abort" handler, esr 0x96000004, far 0xeafffffeea000018 > elr: 0000000041e63cd4 lr : 0000000041e1b844 (reloc) > elr: 000000007ff9ecd4 lr : 000000007ff56844 > x0 : eafffffeea000018 x1 : 000000007fb552e0 > x2 : 00000000000000fe x3 : 0000000000000000 The cause is that "serial,nc" forced the console subsystem to initialize the ethernet driver before ethernet subsystem initialization (console_init_r() is called before initr_net()). During the mtk_eth driver initialization, mdio_register() will be called, and miiphy_get_dev_by_name() will then be called. The miiphy_get_dev_by_name() will check the list "mii_devs" to see if the passed device name exists. However the mii_devs is defined without initialization: > static struct list_head mii_devs; and the actual initialization is done in the following chain: initr_net -> eth_initialize -> eth_common_init -> miiphy_init Since initr_net() hasn't be called, iterating over the mii_devs will access to physical address 0 (mii_devs.next == NULL) and will cause the crash. The fix is to define mii_devs using: > static LIST_HEAD(mii_devs); As the "current_mii" is defined as a static variable, it will always be NULL in board_r stage and initializing it will NULL is unnecessary. So the entire miiphy_init() can be remove. Signed-off-by: Weijie Gao <hackpascal@gmail.com>
132 lines
2.7 KiB
C
132 lines
2.7 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* (C) Copyright 2001-2015
|
|
* Wolfgang Denk, DENX Software Engineering, wd@denx.de.
|
|
* Joe Hershberger, National Instruments
|
|
*/
|
|
|
|
#include <bootstage.h>
|
|
#include <dm.h>
|
|
#include <env.h>
|
|
#include <miiphy.h>
|
|
#include <net.h>
|
|
#include "eth_internal.h"
|
|
|
|
int eth_env_get_enetaddr_by_index(const char *base_name, int index,
|
|
uchar *enetaddr)
|
|
{
|
|
char enetvar[32];
|
|
sprintf(enetvar, index ? "%s%daddr" : "%saddr", base_name, index);
|
|
return eth_env_get_enetaddr(enetvar, enetaddr);
|
|
}
|
|
|
|
int eth_env_set_enetaddr_by_index(const char *base_name, int index,
|
|
uchar *enetaddr)
|
|
{
|
|
char enetvar[32];
|
|
sprintf(enetvar, index ? "%s%daddr" : "%saddr", base_name, index);
|
|
return eth_env_set_enetaddr(enetvar, enetaddr);
|
|
}
|
|
|
|
void eth_common_init(void)
|
|
{
|
|
bootstage_mark(BOOTSTAGE_ID_NET_ETH_START);
|
|
}
|
|
|
|
int eth_mac_skip(int index)
|
|
{
|
|
char enetvar[15];
|
|
char *skip_state;
|
|
|
|
sprintf(enetvar, index ? "eth%dmacskip" : "ethmacskip", index);
|
|
skip_state = env_get(enetvar);
|
|
return skip_state != NULL;
|
|
}
|
|
|
|
void eth_current_changed(void)
|
|
{
|
|
char *act = env_get("ethact");
|
|
char *ethrotate;
|
|
|
|
/*
|
|
* The call to eth_get_dev() below has a side effect of rotating
|
|
* ethernet device if uc_priv->current == NULL. This is not what
|
|
* we want when 'ethrotate' variable is 'no'.
|
|
*/
|
|
ethrotate = env_get("ethrotate");
|
|
if ((ethrotate != NULL) && (strcmp(ethrotate, "no") == 0))
|
|
return;
|
|
|
|
/* update current ethernet name */
|
|
if (eth_get_dev()) {
|
|
if (act == NULL || strcmp(act, eth_get_name()) != 0)
|
|
env_set("ethact", eth_get_name());
|
|
}
|
|
/*
|
|
* remove the variable completely if there is no active
|
|
* interface
|
|
*/
|
|
else if (act != NULL)
|
|
env_set("ethact", NULL);
|
|
}
|
|
|
|
void eth_try_another(int first_restart)
|
|
{
|
|
static void *first_failed;
|
|
char *ethrotate;
|
|
|
|
/*
|
|
* Do not rotate between network interfaces when
|
|
* 'ethrotate' variable is set to 'no'.
|
|
*/
|
|
ethrotate = env_get("ethrotate");
|
|
if ((ethrotate != NULL) && (strcmp(ethrotate, "no") == 0))
|
|
return;
|
|
|
|
if (!eth_get_dev())
|
|
return;
|
|
|
|
if (first_restart)
|
|
first_failed = eth_get_dev();
|
|
|
|
eth_set_current_to_next();
|
|
|
|
eth_current_changed();
|
|
|
|
if (first_failed == eth_get_dev())
|
|
net_restart_wrap = 1;
|
|
}
|
|
|
|
void eth_set_current(void)
|
|
{
|
|
static char *act;
|
|
static int env_changed_id;
|
|
int env_id;
|
|
|
|
env_id = env_get_id();
|
|
if ((act == NULL) || (env_changed_id != env_id)) {
|
|
act = env_get("ethact");
|
|
env_changed_id = env_id;
|
|
}
|
|
|
|
if (act == NULL) {
|
|
char *ethprime = env_get("ethprime");
|
|
void *dev = NULL;
|
|
|
|
if (ethprime)
|
|
dev = eth_get_dev_by_name(ethprime);
|
|
if (dev)
|
|
eth_set_dev(dev);
|
|
else
|
|
eth_set_dev(NULL);
|
|
} else {
|
|
eth_set_dev(eth_get_dev_by_name(act));
|
|
}
|
|
|
|
eth_current_changed();
|
|
}
|
|
|
|
const char *eth_get_name(void)
|
|
{
|
|
return eth_get_dev() ? eth_get_dev()->name : "unknown";
|
|
}
|