Djam/u-boot
1
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-04-18 02:44:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge patch series "Clarify DM_FLAG_PROBE_AFTER_BIND behaviour"

Browse source 
Caleb Connolly <caleb.connolly@linaro.org> says:

In Simon's series reworking autoprobe, a discussion came up about
DM_FLAG_PROBE_AFTER_BIND, specifically that it wasn't very clear where
this flag should be used.

This series implements my suggestions made there to clarify the use of
this flag, and fixup the two driver which erroneously apply it to their
driver struct (this does nothing).

Link: https://lore.kernel.org/u-boot/20241120153642.861633-1-sjg@chromium.org/
Link: https://lore.kernel.org/r/20250117-clarify-probe-after-bind-v1-0-273f046ce5dd@linaro.org
This commit is contained in:
Tom Rini 2025-03-30 09:10:57 -06:00
commit f1895bc1e7
4 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
doc/develop/driver-model/design.rst
View file

@ -843,8 +843,10 @@ steps (see device_probe()):
activated and 'known' by the uclass.
For some platforms, certain devices must be probed to get the platform into
a working state. To help with this, drivers marked with DM_FLAG_PROBE_AFTER_BIND
will be probed immediately after all devices are bound. For now, this happens in
a working state. To help with this, devices marked with DM_FLAG_PROBE_AFTER_BIND
will be probed immediately after all devices are bound. This flag must be set
on the device in its ``bind()`` function with
``dev_or_flags(dev, DM_FLAG_PROBE_AFTER_BIND)``. For now, this happens in
SPL, before relocation and after relocation. See the call to ``dm_autoprobe()``
for where this is done.

1
drivers/mailbox/zynqmp-ipi.c
View file

@ -270,5 +270,4 @@ U_BOOT_DRIVER(zynqmp_ipi) = {
.id = UCLASS_NOP,
.of_match = zynqmp_ipi_ids,
.probe = zynqmp_ipi_probe,
.flags = DM_FLAG_PROBE_AFTER_BIND,
};

1
drivers/watchdog/da9063-wdt.c
View file

@ -145,5 +145,4 @@ U_BOOT_DRIVER(da9063_wdt) = {
.id = UCLASS_WDT,
.of_match = da9063_wdt_ids,
.ops = &da9063_wdt_ops,
.flags = DM_FLAG_PROBE_AFTER_BIND,
};

5
include/dm/device.h
View file

@ -81,7 +81,10 @@ struct driver_info;
*/
#define DM_FLAG_VITAL (1 << 14)
/* Device must be probed after it was bound */
/* Device must be probed after it was bound. This flag is per-device and does
* nothing if set on a U_BOOT_DRIVER() definition. Apply it with
* dev_or_flags(dev, DM_FLAG_PROBE_AFTER_BIND) in the devices bind function.
*/
#define DM_FLAG_PROBE_AFTER_BIND (1 << 15)
/*