Djam/u-boot
1
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-04-19 03:15:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

log: don't build the trace buffer when log is not ready

Browse source 
Update _log function to drop any traces when log is yet initialized:
vsnprintf is no more executed in this case.

This patch allows to reduce the cost for the dropped early debug trace.

Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
This commit is contained in:
Patrick Delaunay 2020-11-27 11:20:52 +01:00 • committed by Tom Rini
parent 6278ec1919
commit f0e90e0ead
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
common/log.c
View file

@ -228,6 +228,9 @@ int _log(enum log_category_t cat, enum log_level_t level, const char *file,
struct log_rec rec; struct log_rec rec;
va_list args; va_list args;
if (!gd)
return -ENOSYS;
/* Check for message continuation */ /* Check for message continuation */
if (cat == LOGC_CONT) if (cat == LOGC_CONT)
cat = gd->logc_prev; cat = gd->logc_prev;
@ -240,15 +243,15 @@ int _log(enum log_category_t cat, enum log_level_t level, const char *file,
rec.file = file; rec.file = file;
rec.line = line; rec.line = line;
rec.func = func; rec.func = func;
if (!(gd->flags & GD_FLG_LOG_READY)) {
gd->log_drop_count++;
return -ENOSYS;
}
va_start(args, fmt); va_start(args, fmt);
vsnprintf(buf, sizeof(buf), fmt, args); vsnprintf(buf, sizeof(buf), fmt, args);
va_end(args); va_end(args);
rec.msg = buf; rec.msg = buf;
if (!gd || !(gd->flags & GD_FLG_LOG_READY)) {
if (gd)
gd->log_drop_count++;
return -ENOSYS;
}
if (!log_dispatch(&rec)) { if (!log_dispatch(&rec)) {
gd->logc_prev = cat; gd->logc_prev = cat;
gd->logl_prev = level; gd->logl_prev = level;