Djam/u-boot
1
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-05-08 19:11:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

efi_loader: memory leak efi_add_memory_map_pg

Browse source 
Don't leak newlist if we error out.

Fixes: 74c16acce3 ("efi_loader: Don't allocate from memory holes")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
This commit is contained in:
Heinrich Schuchardt 2023-07-30 12:59:32 +02:00
parent 257a498fbb
commit ecae4bbf35
1 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/efi_loader/efi_memory.c
View file

@ -324,6 +324,7 @@ static efi_status_t efi_add_memory_map_pg(u64 start, u64 pages,
* The user requested to only have RAM overlaps, * The user requested to only have RAM overlaps,
* but we hit a non-RAM region. Error out. * but we hit a non-RAM region. Error out.
*/ */
free(newlist);
return EFI_NO_MAPPING; return EFI_NO_MAPPING;
case EFI_CARVE_NO_OVERLAP: case EFI_CARVE_NO_OVERLAP:
/* Just ignore this list entry */ /* Just ignore this list entry */
@ -354,6 +355,7 @@ static efi_status_t efi_add_memory_map_pg(u64 start, u64 pages,
* The payload wanted to have RAM overlaps, but we overlapped * The payload wanted to have RAM overlaps, but we overlapped
* with an unallocated region. Error out. * with an unallocated region. Error out.
*/ */
free(newlist);
return EFI_NO_MAPPING; return EFI_NO_MAPPING;
} }