Djam/u-boot
1
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-04-19 11:24:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

cmd: efidebug: fix a failure of "boot rm" sub-command

Browse source 
There is a wrong usage of utf8_utf16_strncpy() in "boot rm" command, and
then it will end up with a failure of this command due to a wrong
value of an interim variable ("var_name16").

Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
This commit is contained in:
AKASHI Takahiro 2020-02-28 09:05:04 +09:00 • committed by Heinrich Schuchardt
parent b484296f6f
commit e8bced62b6
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
cmd/efidebug.c
View file

@ -649,7 +649,7 @@ static int do_efi_boot_rm(cmd_tbl_t *cmdtp, int flag,
int id, i; int id, i;
char *endp; char *endp;
char var_name[9]; char var_name[9];
u16 var_name16[9]; u16 var_name16[9], *p;
efi_status_t ret; efi_status_t ret;
if (argc == 1) if (argc == 1)
@ -662,7 +662,8 @@ static int do_efi_boot_rm(cmd_tbl_t *cmdtp, int flag,
return CMD_RET_FAILURE; return CMD_RET_FAILURE;
sprintf(var_name, "Boot%04X", id); sprintf(var_name, "Boot%04X", id);
utf8_utf16_strncpy((u16 **)&var_name16, var_name, 9); p = var_name16;
utf8_utf16_strncpy(&p, var_name, 9);
ret = EFI_CALL(RT->set_variable(var_name16, &guid, 0, 0, NULL)); ret = EFI_CALL(RT->set_variable(var_name16, &guid, 0, 0, NULL));
if (ret) { if (ret) {