Djam/u-boot
1
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-04-23 05:08:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

unit-test: cover run_commandf() by test-cases

Browse source 
As run_commandf() is variadic version of run_command() and just a wrapper,
hence apply similar run_command's test-cases.

Let's avoid warning about empty string passing:
warning: zero-length gnu_printf format string [-Wformat-zero-length]
   assert(run_commandf("") == 0);

Signed-off-by: Evgeny Bachinin <EABachinin@sberdevices.ru>
Reviewed-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Evgeny Bachinin 2023-03-20 11:23:12 +03:00 • committed by Tom Rini
parent 26f923c7cf
commit dd1f34a9b9
1 changed files with 34 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
test/command_ut.c
View file

@ -9,6 +9,8 @@
#include <command.h> #include <command.h>
#include <env.h> #include <env.h>
#include <log.h> #include <log.h>
#include <string.h>
#include <linux/errno.h>
static const char test_cmd[] = "setenv list 1\n setenv list ${list}2; " static const char test_cmd[] = "setenv list 1\n setenv list ${list}2; "
"setenv list ${list}3\0" "setenv list ${list}3\0"
@ -17,6 +19,8 @@ static const char test_cmd[] = "setenv list 1\n setenv list ${list}2; "
static int do_ut_cmd(struct cmd_tbl *cmdtp, int flag, int argc, static int do_ut_cmd(struct cmd_tbl *cmdtp, int flag, int argc,
char *const argv[]) char *const argv[])
{ {
char long_str[CONFIG_SYS_CBSIZE + 42];
printf("%s: Testing commands\n", __func__); printf("%s: Testing commands\n", __func__);
run_command("env default -f -a", 0); run_command("env default -f -a", 0);
@ -60,6 +64,36 @@ static int do_ut_cmd(struct cmd_tbl *cmdtp, int flag, int argc,
assert(run_command("'", 0) == 1); assert(run_command("'", 0) == 1);
/* Variadic function test-cases */
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wformat-zero-length"
assert(run_commandf("") == 0);
#pragma GCC diagnostic pop
assert(run_commandf(" ") == 0);
assert(run_commandf("'") == 1);
assert(run_commandf("env %s %s", "delete -f", "list") == 0);
/* Expected: "Error: "list" not defined" */
assert(run_commandf("printenv list") == 1);
memset(long_str, 'x', sizeof(long_str));
assert(run_commandf("Truncation case: %s", long_str) == -ENOSPC);
if (IS_ENABLED(CONFIG_HUSH_PARSER)) {
assert(run_commandf("env %s %s %s %s", "delete -f", "adder",
"black", "foo") == 0);
assert(run_commandf("setenv foo 'setenv %s 1\nsetenv %s 2'",
"black", "adder") == 0);
run_command("run foo", 0);
assert(env_get("black"));
assert(!strcmp("1", env_get("black")));
assert(env_get("adder"));
assert(!strcmp("2", env_get("adder")));
}
/* Clean up before exit */
run_command("env default -f -a", 0);
printf("%s: Everything went swimmingly\n", __func__); printf("%s: Everything went swimmingly\n", __func__);
return 0; return 0;
} }