Djam/u-boot
1
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-04-18 19:04:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

sysreset: Fix unsupported request return values

Browse source 
The description of the sysreset request method in <sysreset.h> says that
the return value should be -EPROTONOSUPPORT if the requested reset type
is not supported by this device.

Signed-off-by: Paul Barker <paul.barker.ct@bp.renesas.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Paul Barker 2023-11-08 08:51:10 +00:00 • committed by Tom Rini
parent 15e871fc5d
commit da35ab68de
6 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/sysreset/poweroff_gpio.c
View file

@ -33,7 +33,7 @@ static int poweroff_gpio_request(struct udevice *dev, enum sysreset_t type)
int r; int r;
if (type != SYSRESET_POWER_OFF) if (type != SYSRESET_POWER_OFF)
return -ENOSYS; return -EPROTONOSUPPORT;
debug("GPIO poweroff\n"); debug("GPIO poweroff\n");

2
drivers/sysreset/sysreset_psci.c
View file

@ -25,7 +25,7 @@ static int psci_sysreset_request(struct udevice *dev, enum sysreset_t type)
psci_sys_poweroff(); psci_sys_poweroff();
break; break;
default: default:
return -ENOSYS; return -EPROTONOSUPPORT;
} }
return -EINPROGRESS; return -EINPROGRESS;

4
drivers/sysreset/sysreset_sandbox.c
View file

@ -21,7 +21,7 @@ static int sandbox_warm_sysreset_request(struct udevice *dev,
state->last_sysreset = type; state->last_sysreset = type;
break; break;
default: default:
return -ENOSYS; return -EPROTONOSUPPORT;
} }
if (!state->sysreset_allowed[type]) if (!state->sysreset_allowed[type])
return -EACCES; return -EACCES;
@ -70,7 +70,7 @@ static int sandbox_sysreset_request(struct udevice *dev, enum sysreset_t type)
return -EACCES; return -EACCES;
sandbox_exit(); sandbox_exit();
default: default:
return -ENOSYS; return -EPROTONOSUPPORT;
} }
if (!state->sysreset_allowed[type]) if (!state->sysreset_allowed[type])
return -EACCES; return -EACCES;

2
drivers/sysreset/sysreset_watchdog.c
View file

@ -29,7 +29,7 @@ static int wdt_reboot_request(struct udevice *dev, enum sysreset_t type)
return ret; return ret;
break; break;
default: default:
return -ENOSYS; return -EPROTONOSUPPORT;
} }
return -EINPROGRESS; return -EINPROGRESS;

2
drivers/sysreset/sysreset_x86.c
View file

@ -87,7 +87,7 @@ static int x86_sysreset_request(struct udevice *dev, enum sysreset_t type)
return ret; return ret;
return -EINPROGRESS; return -EINPROGRESS;
default: default:
return -ENOSYS; return -EPROTONOSUPPORT;
} }
outb(value, IO_PORT_RESET); outb(value, IO_PORT_RESET);

6
test/dm/sysreset.c
View file

@ -27,8 +27,8 @@ static int dm_test_sysreset_base(struct unit_test_state *uts)
/* Device 1 is the warm sysreset device */ /* Device 1 is the warm sysreset device */
ut_assertok(uclass_get_device(UCLASS_SYSRESET, 1, &dev)); ut_assertok(uclass_get_device(UCLASS_SYSRESET, 1, &dev));
ut_asserteq(-EACCES, sysreset_request(dev, SYSRESET_WARM)); ut_asserteq(-EACCES, sysreset_request(dev, SYSRESET_WARM));
ut_asserteq(-ENOSYS, sysreset_request(dev, SYSRESET_COLD)); ut_asserteq(-EPROTONOSUPPORT, sysreset_request(dev, SYSRESET_COLD));
ut_asserteq(-ENOSYS, sysreset_request(dev, SYSRESET_POWER)); ut_asserteq(-EPROTONOSUPPORT, sysreset_request(dev, SYSRESET_POWER));
state->sysreset_allowed[SYSRESET_WARM] = true; state->sysreset_allowed[SYSRESET_WARM] = true;
ut_asserteq(-EINPROGRESS, sysreset_request(dev, SYSRESET_WARM)); ut_asserteq(-EINPROGRESS, sysreset_request(dev, SYSRESET_WARM));
@ -36,7 +36,7 @@ static int dm_test_sysreset_base(struct unit_test_state *uts)
/* Device 2 is the cold sysreset device */ /* Device 2 is the cold sysreset device */
ut_assertok(uclass_get_device(UCLASS_SYSRESET, 2, &dev)); ut_assertok(uclass_get_device(UCLASS_SYSRESET, 2, &dev));
ut_asserteq(-ENOSYS, sysreset_request(dev, SYSRESET_WARM)); ut_asserteq(-EPROTONOSUPPORT, sysreset_request(dev, SYSRESET_WARM));
state->sysreset_allowed[SYSRESET_COLD] = false; state->sysreset_allowed[SYSRESET_COLD] = false;
ut_asserteq(-EACCES, sysreset_request(dev, SYSRESET_COLD)); ut_asserteq(-EACCES, sysreset_request(dev, SYSRESET_COLD));
state->sysreset_allowed[SYSRESET_COLD] = true; state->sysreset_allowed[SYSRESET_COLD] = true;