mirror of
https://github.com/u-boot/u-boot.git
synced 2025-04-25 06:46:00 +00:00
spl: spl_load: fix comparison between negative error code and unsigned size
read could be a negative error value but size in spl_image is unsigned so when they are compared read is used as if it's a unsigned value and if it's negative it'll most likely be bigger than size and the result will be true and _spl_load() will return 0 to the caller. This results in the caller to _spl_load() not seeing that an error happened as it should and continuing as if the load was completed when it might not have been. Check if read is negative and return it's value if it is before comparing against size in spl_image. Signed-off-by: Daniel Palmer <daniel@0x0f.com> Reviewed-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
parent
2349cc00d9
commit
c6eba28c46
1 changed files with 4 additions and 0 deletions
|
@ -83,6 +83,10 @@ static inline int _spl_load(struct spl_image_info *spl_image,
|
|||
|
||||
read = info->read(info, offset + image_offset, size,
|
||||
map_sysmem(spl_image->load_addr - overhead, size));
|
||||
|
||||
if (read < 0)
|
||||
return read;
|
||||
|
||||
return read < spl_image->size ? -EIO : 0;
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Reference in a new issue