Djam/u-boot
1
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-04-16 09:54:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

arm: move _end to linker symbols

Browse source 
commit 6e2228fb05 ("Merge patch series "Clean up arm linker scripts")
was cleaning up linker scripts for armv7 and v8 but was leaving
_end and __secure_stack_start/end.

commit d0b5d9da5d ("arm: make _end compiler-generated")
was moving _end to be compiler generated. _end is defined as c variable
in its own section to force the compiler emit relative a reference.
However, defining those in the linker script will do the same thing
since [0].

So let's remove the special sections from the linker scripts, the
variable definitions from sections.c and define them as a symbols.
It's worth noting that _image_binary_end symbol is now redundant and
can be removed in the future.

- SPL

The .end section has been removed from the new binary
[ 5] .end
     PROGBITS         00000000fffdf488  000000000002f488  0
     0000000000000000 0000000000000000  0                 1
     [0000000000000003]: WRITE, ALLOC

$~ bloat-o-meter kria_old/spl/u-boot-spl krina_new/spl/u-boot-spl
add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0 (0)
Function                                     old     new   delta
Total: Before=115980, After=115980, chg +0.00%

$~ readelf -sW kria_old/u-boot kria_new/u-boot | grep -w _end
 12047: 000000000813a0f0     0 OBJECT  GLOBAL DEFAULT   11 _end
 12047: 000000000813a118     0 NOTYPE  GLOBAL DEFAULT   11 _end

$~ readelf -sW kria_old/spl/u-boot-spl kria_new/spl/u-boot-spl | grep -w _end
  1605: 00000000fffdf488     0 OBJECT  GLOBAL DEFAULT    5 _end
  1603: 00000000fffdf498     0 NOTYPE  GLOBAL DEFAULT    4 _end

$~ readelf -sW old/u-boot new/u-boot | grep -w _end
  8847: 0000000000103710     0 OBJECT  GLOBAL DEFAULT   11 _end
  8847: 0000000000103738     0 NOTYPE  GLOBAL DEFAULT   11 _end

$~ readelf -sW old_v7/u-boot new_v7/u-boot | grep -w _end
 10638: 000da824     0 OBJECT  GLOBAL DEFAULT   10 _end
 10637: 000da84c     0 NOTYPE  GLOBAL DEFAULT   10 _end

- For both QEMU instances
$~ bloat-o-meter old/u-boot new/u-boot
add/remove: 0/0 grow/shrink: 1/0 up/down: 20/0 (20)
Function                                     old     new   delta
version_string                                50      70     +20
Total: Before=656915, After=656935, chg +0.00%

[0] binutils commit 6b3b0ab89663 ("Make linker assigned symbol dynamic only for shared object")

Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
This commit is contained in:
Ilias Apalodimas 2024-05-28 09:18:27 +03:00 • committed by Tom Rini
parent 3078766134
commit c1eb7a993d
14 changed files with 13 additions and 72 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
arch/arm/cpu/arm1136/u-boot-spl.lds
View file

@ -33,11 +33,7 @@ SECTIONS
.data : { *(SORT_BY_ALIGNMENT(.data*)) } >.sram
. = ALIGN(4);
__image_copy_end = .;
.end :
{
*(.__end)
}
_end = .;
.bss :
{

6
arch/arm/cpu/arm926ejs/mxs/u-boot-spl.lds
View file

@ -49,11 +49,7 @@ SECTIONS
__bss_end = .;
}
.end :
{
*(.__end)
}
_end = .;
_image_binary_end = .;
.dynsym _image_binary_end : { *(.dynsym) }

7
arch/arm/cpu/armv8/u-boot-spl.lds
View file

@ -53,12 +53,7 @@ SECTIONS
. = ALIGN(8);
__image_copy_end = .;
.end : {
. = ALIGN(8);
*(.__end)
} >.sram
_end = .;
_image_binary_end = .;
.bss : {

6
arch/arm/cpu/u-boot-spl.lds
View file

@ -53,12 +53,8 @@ SECTIONS
__rel_dyn_end = .;
}
.end :
{
*(.__end)
}
_image_binary_end = .;
_end = .;
.bss __rel_dyn_start (OVERLAY) : {
__bss_start = .;

6
arch/arm/cpu/u-boot.lds
View file

@ -166,11 +166,7 @@ SECTIONS
__rel_dyn_end = .;
}
.end :
{
*(.__end)
}
_end = .;
_image_binary_end = .;
/*

1
arch/arm/lib/sections.c
View file

@ -23,4 +23,3 @@ char __secure_start[0] __section(".__secure_start");
char __secure_end[0] __section(".__secure_end");
char __secure_stack_start[0] __section(".__secure_stack_start");
char __secure_stack_end[0] __section(".__secure_stack_end");
char _end[0] __section(".__end");

6
arch/arm/mach-aspeed/ast2600/u-boot-spl.lds
View file

@ -61,11 +61,7 @@ SECTIONS
__rel_dyn_end = .;
} > .nor
.end :
{
*(.__end)
} > .nor
_end = .;
_image_binary_end = .;
.bss : {

7
arch/arm/mach-at91/arm926ejs/u-boot-spl.lds
View file

@ -33,12 +33,7 @@ SECTIONS
. = ALIGN(4);
__image_copy_end = .;
.end :
{
*(.__end)
} >.sram
_end = .;
_image_binary_end = .;
.bss :

7
arch/arm/mach-at91/armv7/u-boot-spl.lds
View file

@ -40,12 +40,7 @@ SECTIONS
. = ALIGN(4);
__image_copy_end = .;
.end :
{
*(.__end)
} >.sram
_end = .;
_image_binary_end = .;
.bss :

7
arch/arm/mach-omap2/u-boot-spl.lds
View file

@ -39,12 +39,7 @@ SECTIONS
. = ALIGN(4);
__image_copy_end = .;
.end :
{
*(.__end)
}
_end = .;
_image_binary_end = .;
.bss :

7
arch/arm/mach-rockchip/u-boot-tpl-v8.lds
View file

@ -46,12 +46,7 @@ SECTIONS
. = ALIGN(8);
__image_copy_end = .;
.end : {
. = ALIGN(8);
*(.__end)
}
_end = .;
_image_binary_end = .;
.bss ALIGN(8) : {

6
arch/arm/mach-zynq/u-boot.lds
View file

@ -68,11 +68,7 @@ SECTIONS
__rel_dyn_end = .;
}
.end :
{
*(.__end)
}
_end = .;
_image_binary_end = .;
/*

7
board/davinci/da8xxevm/u-boot-spl-da850evm.lds
View file

@ -46,12 +46,7 @@ SECTIONS
} >.sram
__image_copy_end = .;
.end :
{
*(.__end)
}
_end = .;
_image_binary_end = .;
.bss :

6
board/samsung/common/exynos-uboot-spl.lds
View file

@ -41,11 +41,7 @@ SECTIONS
. = ALIGN(4);
__image_copy_end = .;
.end :
{
*(.__end)
} >.sram
_end = .;
.bss :
{