Djam/u-boot
1
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-05-04 02:32:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

coccinelle: adjust NULL check before free()

Browse source 
The free() function checks if its argument is NULL. We should avoid
checking for NULL before calling free like in

    if (result->tds)
        free(result->tds);

The list of relevant functions differs between Linux and U-Boot, e.g. we
use free().

Adjust the list of relevant functions.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
This commit is contained in:
Heinrich Schuchardt 2020-04-19 11:56:02 +02:00 • committed by Tom Rini
parent cb2a2ebd4f
commit c11f0d88ba
1 changed files with 11 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
scripts/coccinelle/free/ifnullfree.cocci
View file

@ -1,10 +1,11 @@
// SPDX-License-Identifier: GPL-2.0-only
/// NULL check before some freeing functions is not needed. /// NULL check before some freeing functions is not needed.
/// ///
/// Based on checkpatch warning /// Based on checkpatch warning
/// "kfree(NULL) is safe this check is probably not required" /// "kfree(NULL) is safe this check is probably not required"
/// and kfreeaddr.cocci by Julia Lawall. /// and kfreeaddr.cocci by Julia Lawall.
/// ///
// Copyright: (C) 2014 Fabian Frederick. GPLv2. // Copyright: (C) 2014 Fabian Frederick.
// Comments: - // Comments: -
// Options: --no-includes --include-headers // Options: --no-includes --include-headers
@ -18,21 +19,19 @@ expression E;
@@ @@
- if (E != NULL) - if (E != NULL)
( (
free(E);
|
kfree(E); kfree(E);
| |
kzfree(E); vfree(E);
| |
debugfs_remove(E); vfree_recursive(E);
| |
debugfs_remove_recursive(E); kmem_cache_free(E);
|
usb_free_urb(E);
| |
kmem_cache_destroy(E); kmem_cache_destroy(E);
| |
mempool_destroy(E); gzfree(E);
|
dma_pool_destroy(E);
) )
@r depends on context || report || org @ @r depends on context || report || org @
@ -41,9 +40,8 @@ position p;
@@ @@
* if (E != NULL) * if (E != NULL)
* \(kfree@p\|kzfree@p\|debugfs_remove@p\|debugfs_remove_recursive@p\| * \(free@p\|kfree@p\|vfree@p\|debugfs_remove_recursive@p\|
* usb_free_urb@p\|kmem_cache_destroy@p\|mempool_destroy@p\| * kmem_cache_free@p\|kmem_cache_destroy@p\|gzfree@p\)(E);
* dma_pool_destroy@p\)(E);
@script:python depends on org@ @script:python depends on org@
p << r.p; p << r.p;
@ -55,5 +53,5 @@ cocci.print_main("NULL check before that freeing function is not needed", p)
p << r.p; p << r.p;
@@ @@
msg = "WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values." msg = "WARNING: NULL check before some freeing functions is not needed."
coccilib.report.print_report(p[0], msg) coccilib.report.print_report(p[0], msg)