Djam/u-boot
1
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-04-26 15:28:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

lib: rsa: add NULL check for 'algo' in

Browse source 
- Check return value of fdt_getprop for NULL.
- Return -EFAULT if 'algo' property is missing.
- Prevent NULL pointer dereference in strcmp."

Triggers found by static analyzer Svace.

Signed-off-by: Anton Moryakov <ant.v.moryakov@gmail.com>
This commit is contained in:
Anton Moryakov 2025-02-25 16:53:27 +03:00 • committed by Tom Rini
parent 628908f849
commit babc6eef2f
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
lib/rsa/rsa-verify.c
View file

@ -449,6 +449,11 @@ static int rsa_verify_with_keynode(struct image_sign_info *info,
} }
algo = fdt_getprop(blob, node, "algo", NULL); algo = fdt_getprop(blob, node, "algo", NULL);
if (!algo) {
debug("%s: Missing 'algo' property\n", __func__);
return -EFAULT;
}
if (strcmp(info->name, algo)) { if (strcmp(info->name, algo)) {
debug("%s: Wrong algo: have %s, expected %s\n", __func__, debug("%s: Wrong algo: have %s, expected %s\n", __func__,
info->name, algo); info->name, algo);