Djam/u-boot
1
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-04-17 18:34:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

efi_selftest: remove un-needed NULL checks

Browse source 
Because we've already returned early in the event 'handle' is NULL we
don't need these extra not NULL checks. Remove them

Signed-off-by: Bryan Brattlof <bb@ti.com>
Reviewed-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
This commit is contained in:
Bryan Brattlof 2025-04-08 01:06:58 -05:00 • committed by Heinrich Schuchardt
parent d8dcfeb778
commit a73b854700
1 changed files with 36 additions and 48 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

84
lib/efi_selftest/efi_selftest_hii.c
View file

@ -609,14 +609,12 @@ static int test_hii_database_get_package_list_handle(void)
result = EFI_ST_SUCCESS; result = EFI_ST_SUCCESS;
out: out:
if (handle) { ret = hii_database_protocol->remove_package_list(
ret = hii_database_protocol->remove_package_list( hii_database_protocol, handle);
hii_database_protocol, handle); if (ret != EFI_SUCCESS) {
if (ret != EFI_SUCCESS) { efi_st_error("remove_package_list returned %u\n",
efi_st_error("remove_package_list returned %u\n", (unsigned int)ret);
(unsigned int)ret); return EFI_ST_FAILURE;
return EFI_ST_FAILURE;
}
} }
return result; return result;
@ -711,14 +709,12 @@ static int test_hii_string_new_string(void)
result = EFI_ST_SUCCESS; result = EFI_ST_SUCCESS;
out: out:
if (handle) { ret = hii_database_protocol->remove_package_list(
ret = hii_database_protocol->remove_package_list( hii_database_protocol, handle);
hii_database_protocol, handle); if (ret != EFI_SUCCESS) {
if (ret != EFI_SUCCESS) { efi_st_error("remove_package_list returned %u\n",
efi_st_error("remove_package_list returned %u\n", (unsigned int)ret);
(unsigned int)ret); return EFI_ST_FAILURE;
return EFI_ST_FAILURE;
}
} }
return result; return result;
@ -792,14 +788,12 @@ static int test_hii_string_get_string(void)
result = EFI_ST_SUCCESS; result = EFI_ST_SUCCESS;
out: out:
if (handle) { ret = hii_database_protocol->remove_package_list(
ret = hii_database_protocol->remove_package_list( hii_database_protocol, handle);
hii_database_protocol, handle); if (ret != EFI_SUCCESS) {
if (ret != EFI_SUCCESS) { efi_st_error("remove_package_list returned %u\n",
efi_st_error("remove_package_list returned %u\n", (unsigned int)ret);
(unsigned int)ret); return EFI_ST_FAILURE;
return EFI_ST_FAILURE;
}
} }
return result; return result;
@ -851,14 +845,12 @@ static int test_hii_string_set_string(void)
result = EFI_ST_SUCCESS; result = EFI_ST_SUCCESS;
out: out:
if (handle) { ret = hii_database_protocol->remove_package_list(
ret = hii_database_protocol->remove_package_list( hii_database_protocol, handle);
hii_database_protocol, handle); if (ret != EFI_SUCCESS) {
if (ret != EFI_SUCCESS) { efi_st_error("remove_package_list returned %u\n",
efi_st_error("remove_package_list returned %u\n", (unsigned int)ret);
(unsigned int)ret); return EFI_ST_FAILURE;
return EFI_ST_FAILURE;
}
} }
return result; return result;
@ -918,14 +910,12 @@ static int test_hii_string_get_languages(void)
result = EFI_ST_SUCCESS; result = EFI_ST_SUCCESS;
out: out:
if (handle) { ret = hii_database_protocol->remove_package_list(
ret = hii_database_protocol->remove_package_list( hii_database_protocol, handle);
hii_database_protocol, handle); if (ret != EFI_SUCCESS) {
if (ret != EFI_SUCCESS) { efi_st_error("remove_package_list returned %u\n",
efi_st_error("remove_package_list returned %u\n", (unsigned int)ret);
(unsigned int)ret); return EFI_ST_FAILURE;
return EFI_ST_FAILURE;
}
} }
return result; return result;
@ -991,14 +981,12 @@ static int test_hii_string_get_secondary_languages(void)
result = EFI_ST_SUCCESS; result = EFI_ST_SUCCESS;
out: out:
if (handle) { ret = hii_database_protocol->remove_package_list(
ret = hii_database_protocol->remove_package_list( hii_database_protocol, handle);
hii_database_protocol, handle); if (ret != EFI_SUCCESS) {
if (ret != EFI_SUCCESS) { efi_st_error("remove_package_list returned %u\n",
efi_st_error("remove_package_list returned %u\n", (unsigned int)ret);
(unsigned int)ret); return EFI_ST_FAILURE;
return EFI_ST_FAILURE;
}
} }
return result; return result;