Djam/u-boot
1
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-04-24 14:25:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

spi: stm32_qspi: Always check SR_TCF flags in stm32_qspi_wait_cmd()

Browse source 
Currently, SR_TCF flag is checked in case there is data, this criteria
is not correct.

SR_TCF flags is set when programmed number of bytes have been transferred
to the memory device ("bytes" comprised command and data send to the
SPI device).
So even if there is no data, we must check SR_TCF flag.

Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
This commit is contained in:
Patrice Chotard 2022-05-12 09:17:37 +02:00 • committed by Patrick Delaunay
parent 0adf10a87b
commit a6d7eeb66d
1 changed files with 11 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
drivers/spi/stm32_qspi.c
View file

@ -150,20 +150,19 @@ static int _stm32_qspi_wait_cmd(struct stm32_qspi_priv *priv,
u32 sr; u32 sr;
int ret = 0; int ret = 0;
if (op->data.nbytes) { ret = readl_poll_timeout(&priv->regs->sr, sr,
ret = readl_poll_timeout(&priv->regs->sr, sr, sr & STM32_QSPI_SR_TCF,
sr & STM32_QSPI_SR_TCF, STM32_QSPI_CMD_TIMEOUT_US);
STM32_QSPI_CMD_TIMEOUT_US); if (ret) {
if (ret) { log_err("cmd timeout (stat:%#x)\n", sr);
log_err("cmd timeout (stat:%#x)\n", sr); } else if (readl(&priv->regs->sr) & STM32_QSPI_SR_TEF) {
} else if (readl(&priv->regs->sr) & STM32_QSPI_SR_TEF) { log_err("transfer error (stat:%#x)\n", sr);
log_err("transfer error (stat:%#x)\n", sr); ret = -EIO;
ret = -EIO;
}
/* clear flags */
writel(STM32_QSPI_FCR_CTCF | STM32_QSPI_FCR_CTEF, &priv->regs->fcr);
} }
/* clear flags */
writel(STM32_QSPI_FCR_CTCF | STM32_QSPI_FCR_CTEF, &priv->regs->fcr);
if (!ret) if (!ret)
ret = _stm32_qspi_wait_for_not_busy(priv); ret = _stm32_qspi_wait_for_not_busy(priv);