From a345f44a60f57a2741cda9315312d3df28bc22f0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vincent=20Stehl=C3=A9?= Date: Mon, 24 Mar 2025 09:34:06 +0100 Subject: [PATCH] ata: ahci: remove bad free MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In the case of a memory allocation error, the ahci_port_start() function tries to free the `pp' pointer. This pointer was not dynamically allocated but does in fact point to an element of the port[] array member of the struct ahci_uc_priv. Remove the erroneous call to free() to fix this. Fixes: 4782ac80b02f ("Add AHCI support to u-boot") Signed-off-by: Vincent Stehlé Cc: Tom Rini Cc: Jason Jin Reviewed-by: Andre Przywara --- drivers/ata/ahci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 8058d5ff1c3..e593e228685 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -463,7 +463,6 @@ static int ahci_port_start(struct ahci_uc_priv *uc_priv, u8 port) mem = memalign(2048, AHCI_PORT_PRIV_DMA_SZ); if (!mem) { - free(pp); printf("%s: No mem for table!\n", __func__); return -ENOMEM; }