Djam/u-boot
1
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-05-08 19:11:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

mips: mt76x8: ddr_cal: Rename dqs_test_valid() to dqs_test_error()

Browse source 
This function returns "-1" (true) upon error. So the function name does
not match its implementation which is confusing. This patch renames the
function to dqs_test_error() which makes the code easier to read.

Also change the return type to bool and return "true" or "false".

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Weijie Gao <weijie.gao@mediatek.com>
Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
Reviewed-by: Weijie Gao <weijie.gao@mediatek.com>
This commit is contained in:
Stefan Roese 2020-03-06 15:14:03 +01:00 • committed by Daniel Schwierzeck
parent e9dbd1ac82
commit 896449fa29
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
arch/mips/mach-mtmips/ddr_cal.c
View file

@ -32,8 +32,8 @@ static inline void pref_op(int op, const volatile void *addr)
__asm__ __volatile__("pref %0, 0(%1)" : : "i" (op), "r" (addr)); __asm__ __volatile__("pref %0, 0(%1)" : : "i" (op), "r" (addr));
} }
static inline int dqs_test_valid(void __iomem *memc, u32 memsize, u32 dqsval, static inline bool dqs_test_error(void __iomem *memc, u32 memsize, u32 dqsval,
u32 bias) u32 bias)
{ {
u32 *nca, *ca; u32 *nca, *ca;
u32 off; u32 off;
@ -64,11 +64,11 @@ static inline int dqs_test_valid(void __iomem *memc, u32 memsize, u32 dqsval,
for (i = 0; i < TEST_PAT_SIZE / sizeof(u32); i++) { for (i = 0; i < TEST_PAT_SIZE / sizeof(u32); i++) {
if (ca[i] != (u32)nca + i + bias) if (ca[i] != (u32)nca + i + bias)
return -1; return true;
} }
} }
return 0; return false;
} }
static inline u32 dqs_find_max(void __iomem *memc, u32 memsize, u32 initval, static inline u32 dqs_find_max(void __iomem *memc, u32 memsize, u32 initval,
@ -79,7 +79,7 @@ static inline u32 dqs_find_max(void __iomem *memc, u32 memsize, u32 initval,
do { do {
dqsval = regval | (fieldval << shift); dqsval = regval | (fieldval << shift);
if (dqs_test_valid(memc, memsize, dqsval, 3)) if (dqs_test_error(memc, memsize, dqsval, 3))
break; break;
fieldval++; fieldval++;
@ -96,7 +96,7 @@ static inline u32 dqs_find_min(void __iomem *memc, u32 memsize, u32 initval,
while (fieldval > minval) { while (fieldval > minval) {
dqsval = regval | (fieldval << shift); dqsval = regval | (fieldval << shift);
if (dqs_test_valid(memc, memsize, dqsval, 1)) { if (dqs_test_error(memc, memsize, dqsval, 1)) {
fieldval++; fieldval++;
break; break;
} }