Djam/u-boot
1
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-04-16 09:54:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

common: console: move break; statement

Browse source 
In console_setfile(), there is some #ifdef'ed code, updating monitor
functions for a U-Boot proper build. This is called inside a switch/case
statement, but the closing "break;" is inside the #ifdef section.
This doesn't look right: we should not fall through to the error case
for an SPL/TPL build.

Move the "break" to be always effective, solving a compiler warning about
an untagged implicit fallthrough.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
This commit is contained in:
Andre Przywara 2025-03-25 17:47:44 +00:00 • committed by Tom Rini
parent cb7555e930
commit 82f5ce11e6
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
common/console.c
View file

@ -208,8 +208,8 @@ static int console_setfile(int file, struct stdio_dev * dev)
gd->jt->printf = printf;
break;
}
break;
#endif
break;
default: /* Invalid file ID */
error = -1;
}