Djam/u-boot
1
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-04-18 19:04:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

mbedtls: fix defects in coverity scan

Browse source 
Fixes of unreleased buffer, deadcode and wrong variable type detected
by coverity scan.

Addresses-Coverity-ID: 510809:  Resource leaks  (RESOURCE_LEAK)
Addresses-Coverity-ID: 510806:  Control flow issues  (DEADCODE)
Addresses-Coverity-ID: 510794 Control flow issues  (NO_EFFECT)

Signed-off-by: Raymond Mao <raymond.mao@linaro.org>
This commit is contained in:
Raymond Mao 2024-10-16 16:48:26 -07:00 • committed by Tom Rini
parent b92a18e2b6
commit 7f45377152
2 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
lib/mbedtls/pkcs7_parser.c
View file

@ -206,9 +206,6 @@ static int authattrs_parse(struct pkcs7_message *msg, void *aa, size_t aa_len,
p += seq_len; p += seq_len;
} }
if (ret && ret != MBEDTLS_ERR_ASN1_OUT_OF_DATA)
return ret;
msg->have_authattrs = true; msg->have_authattrs = true;
/* /*
@ -361,8 +358,10 @@ static int x509_populate_sinfo(struct pkcs7_message *msg,
signed_info->sig = s; signed_info->sig = s;
/* Save the Authenticate Attributes data if exists */ /* Save the Authenticate Attributes data if exists */
if (!mb_sinfo->authattrs.data || !mb_sinfo->authattrs.data_len) if (!mb_sinfo->authattrs.data || !mb_sinfo->authattrs.data_len) {
kfree(mctx);
goto no_authattrs; goto no_authattrs;
}
mctx->authattrs_data = kmemdup(mb_sinfo->authattrs.data, mctx->authattrs_data = kmemdup(mb_sinfo->authattrs.data,
mb_sinfo->authattrs.data_len, mb_sinfo->authattrs.data_len,

2
lib/mbedtls/x509_cert_parser.c
View file

@ -66,7 +66,7 @@ time64_t x509_get_timestamp(const mbedtls_x509_time *x509_time)
static char *x509_populate_dn_name_string(const mbedtls_x509_name *name) static char *x509_populate_dn_name_string(const mbedtls_x509_name *name)
{ {
size_t len = 256; size_t len = 256;
size_t wb; int wb;
char *name_str; char *name_str;
do { do {