Djam/u-boot
1
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-04-11 15:34:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

tools: copyfile: use 64k instead of 512 buffer

Browse source 
This is a trivial but significant optimization:
mkimage took >200ms (and 49489 writes (of which 49456 512)),
now it takes  110ms (and   419 writes (of which   386 64k)).

sendfile is much more appropriate for this and is done in one syscall,
but doesn't bring any significant speedups over 64k r/w
at the 13M size ranges, so there's no need to introduce
	#if __linux__
	while((size = sendfile(fd_dst, fd_src, NULL, 128 * 1024 * 1024)) > 0)
		;
	if(size != -1) {
		ret = 0;
		goto out;
	}
	#endif

Also extract the buffer size to a macro.

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
This commit is contained in:
Ahelenia Ziemiańska 2024-04-09 14:14:34 +02:00 • committed by Tom Rini
parent 28a766ebf1
commit 7c665e1512
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
tools/fit_common.c
View file

@ -23,6 +23,8 @@
#include <image.h>
#include <u-boot/crc.h>
#define COPYFILE_BUFSIZE (64 * 1024)
void fit_print_header(const void *fit, struct image_tool_params *params)
{
fit_print_contents(fit);
@ -145,14 +147,14 @@ int copyfile(const char *src, const char *dst)
goto out;
}
buf = calloc(1, 512);
buf = calloc(1, COPYFILE_BUFSIZE);
if (!buf) {
printf("Can't allocate buffer to copy file\n");
goto out;
}
while (1) {
size = read(fd_src, buf, 512);
size = read(fd_src, buf, COPYFILE_BUFSIZE);
if (size < 0) {
printf("Can't read file %s\n", src);
goto out;