Djam/u-boot
1
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-05-08 10:39:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

stdio: Pass device pointer to stdio methods

Browse source 
At present stdio device functions do not get any clue as to which stdio
device is being acted on. Some implementations go to great lengths to work
around this, such as defining a whole separate set of functions for each
possible device.

For driver model we need to associate a stdio_dev with a device. It doesn't
seem possible to continue with this work-around approach.

Instead, add a stdio_dev pointer to each of the stdio member functions.

Note: The serial drivers have the same problem, but it is not strictly
necessary to fix that to get driver model running. Also, if we convert
serial over to driver model the problem will go away.

Code size increases by 244 bytes for Thumb2 and 428 for PowerPC.

22: stdio: Pass device pointer to stdio methods
       arm: (for 2/2 boards)  all +244.0  bss -4.0  text +248.0
   powerpc: (for 1/1 boards)  all +428.0  text +428.0

Signed-off-by: Simon Glass <sjg@chromium.org>
Acked-by: Marek Vasut <marex@denx.de>
Reviewed-by: Marek Vasut <marex@denx.de>
This commit is contained in:
Simon Glass 2014-07-23 06:54:59 -06:00
parent 91d0be1dd8
commit 709ea543b9
30 changed files with 189 additions and 101 deletions
Download patch file Download diff file Expand all files Collapse all files

34
common/stdio.c
View file

@ -35,23 +35,43 @@ char *stdio_names[MAX_FILES] = { "stdin", "stdout", "stderr" };
#ifdef CONFIG_SYS_DEVICE_NULLDEV
void nulldev_putc(const char c)
void nulldev_putc(struct stdio_dev *dev, const char c)
{
/* nulldev is empty! */
}
void nulldev_puts(const char *s)
void nulldev_puts(struct stdio_dev *dev, const char *s)
{
/* nulldev is empty! */
}
int nulldev_input(void)
int nulldev_input(struct stdio_dev *dev)
{
/* nulldev is empty! */
return 0;
}
#endif
void stdio_serial_putc(struct stdio_dev *dev, const char c)
{
serial_putc(c);
}
void stdio_serial_puts(struct stdio_dev *dev, const char *s)
{
serial_puts(s);
}
int stdio_serial_getc(struct stdio_dev *dev)
{
return serial_getc();
}
int stdio_serial_tstc(struct stdio_dev *dev)
{
return serial_tstc();
}
/**************************************************************************
* SYSTEM DRIVERS
**************************************************************************
@ -65,10 +85,10 @@ static void drv_system_init (void)
strcpy (dev.name, "serial");
dev.flags = DEV_FLAGS_OUTPUT | DEV_FLAGS_INPUT | DEV_FLAGS_SYSTEM;
dev.putc = serial_putc;
dev.puts = serial_puts;
dev.getc = serial_getc;
dev.tstc = serial_tstc;
dev.putc = stdio_serial_putc;
dev.puts = stdio_serial_puts;
dev.getc = stdio_serial_getc;
dev.tstc = stdio_serial_tstc;
stdio_register (&dev);
#ifdef CONFIG_SYS_DEVICE_NULLDEV